[Due for payment 2025-07-25] [$250] Expense - When deleting distance rate, error appears in two expenses with different rates

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.74-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+1216@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Prerequisite: Account has at least one workspace created.
Prerequisite 2: Distance rates enabled and at least two rates created.

1. Open the Expensify app.
2. Open any workspace chat.
3. Create two different distance expenses.
4. Open the report of the just created expenses.
5. Open any of the expenses and select "Rate" field.
6. Change the rate of the expense.
7. Navigate to "Workspaces" and open the workspace where the expenses were created.
8. Tap on "Distance Rates"
9. Select the rate of the edited expense and delete it.
10. Navigate to workspace chat again.
11. Note that now, both expenses display a "Rate not valid for this workspace" error.
12. Open the reportagain.
13. Note that the error disappears from one of the expenses.

Expected Result:

When deleting distance rate used for an expense, the error that appears with this action, should only appear for the expense with that rate and not for every expense on the same report.

Actual Result:

When deleting a distance rate used for an expense, the "Rate not valid for this workspace" appears also for different distance expenses that are part of the same report, despite those expenses having different rates.
Error is cleared on expense with valid rates after opening report again.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6876257_1751477014319.Rates.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021943541455984823529
• Upwork Job ID: 1943541455984823529
• Last Price Increase: 2025-07-11
• Automatic offers:
• FitseTLT | Contributor | 108034904

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - When deleting distance rate, error appears in two expenses with different rates

What is the root cause of that problem?

We are setting violations for all transactions with the specific customUnitID instead of checking for the customUnitRateID

App/src/libs/actions/Policy/DistanceRate.ts

Line 572 in 39f3cf4

const transactions = Object.values(allTransactions ?? {}).filter((transaction) => transaction?.comment?.customUnit?.customUnitID === customUnit.customUnitID);

What changes do you think we should make in order to solve the problem?

We need to filter for transactions with customUnitRateID as the deleted one

    const transactions = Object.values(allTransactions ?? {}).filter((transaction) => rateIDsToDelete.includes(transaction?.comment?.customUnit?.customUnitRateID));

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Test deletePolicyDistanceRates that it only sets the violation on transactions with the deleted rate set.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@adelekennedy Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@adelekennedy Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021943541455984823529

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)