[Due for payment 2025-08-01] [$250] mweb-chat-On deleting message, delete dialog box flickers and get closed

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.77-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6444617
Email or phone of affected tester (no customers): Slottwo1 csm@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Chat Report View

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Open a chat
3. Send a message
4. Delete the message
5. Note delete dialog box

Expected Result:

On deleting message, delete dialog box must not flicker and get closed.

Actual Result:

On deleting message, delete dialog box flickers and get closed.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6880928_1751935291907.Screenrecorder-2025-07-08-06-08-01-631.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021942577742373158067
• Upwork Job ID: 1942577742373158067
• Last Price Increase: 2025-07-15
• Automatic offers:
• thelullabyy | Contributor | 108097167

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @maddylewis

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nabi-ebrahimi]

couldn't reproduce it in latest main.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021942577742373158067

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[PiyushChandra17]

I can confirm this is reproducible on latest main

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

mweb-chat-On deleting message, delete dialog box flickers and get closed

What is the root cause of that problem?

This isVisible check is the root cause

App/src/components/ConfirmModal.tsx

Line 173 in be0c82b

onConfirm={() => (isVisible ? onConfirm() : null)}

What changes do you think we should make in order to solve the problem?

Remove that check,

Replace that line with just,

onConfirm={onConfirm}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

Result

fix-flickering.mov

android-mweb-fix.mov

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dangrous]

Happy to help with internal review here when it's ready!