[Due for payment 2025-08-01] [$250] Reports - App crashes when group-by:reports is manually added to type:chat search query

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.78-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #65159
Email or phone of affected tester (no customers): sdoijoisjiodnj@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Search

Action Performed:

1. Go to staging.expensify.com
2. Go to Reports.
3. Go to Chats.
4. Add group-by:reports to the search query and hit Enter.

Expected Result:

App will not crash.

Actual Result:

App crashes when group-by:reports is manually added to type:chat search query.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6882132_1752040688765!staging.new.expensify.com-1752040436495.txt

Bug6882132_1752040688773.20250709_135329.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when group-by:reports is manually added to type:chat search query.

What is the root cause of that problem?

We have the error here when the item don't have any transactions

App/src/components/Search/SearchList.tsx

Lines 110 to 111 in 1bba92b

	const flattenedTransactions = groupBy ? (data as TransactionGroupListItemType[]).flatMap((item) => item.transactions) : data;
	const flattenedTransactionWithoutPendingDelete = flattenedTransactions.filter((t) => t.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);

What changes do you think we should make in order to solve the problem?

Update this line to

    const flattenedTransactionWithoutPendingDelete = flattenedTransactions.filter((t) => t?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);

App/src/components/Search/SearchList.tsx

Line 111 in 1bba92b

const flattenedTransactionWithoutPendingDelete = flattenedTransactions.filter((t) => t.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[linhvovan29546]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - App crashes when group-by:reports is manually added to type:chat search query

What is the root cause of that problem?

The flattenedTransactions array contains [undefined,undefined]

App/src/components/Search/SearchList.tsx

Lines 110 to 111 in 1bba92b

	const flattenedTransactions = groupBy ? (data as TransactionGroupListItemType[]).flatMap((item) => item.transactions) : data;
	const flattenedTransactionWithoutPendingDelete = flattenedTransactions.filter((t) => t.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);

When we attempt to filter with t.pendingAction, the code crashes because t is undefined.
This happens because we are using flatMap on data that does not contain transactions specifically for types that are not transactions, such as chat and task.

What changes do you think we should make in order to solve the problem?

The issue occurs for types chat and task, so we should add a type check before applying flatMap. This will prevent us from attempting to flatten data that does not contain transactions.

App/src/components/Search/SearchList.tsx

Lines 110 to 111 in 1bba92b

	const flattenedTransactions = groupBy ? (data as TransactionGroupListItemType[]).flatMap((item) => item.transactions) : data;
	const flattenedTransactionWithoutPendingDelete = flattenedTransactions.filter((t) => t.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);

    const isChat = type === CONST.SEARCH.DATA_TYPES.CHAT;
    const isTask = type === CONST.SEARCH.DATA_TYPES.TASK;
 //   const isInvoice = type === CONST.SEARCH.DATA_TYPES.INVOICE;

    const flattenedTransactions = (groupBy && !isChat && !isTask) ? (data as TransactionGroupListItemType[]).flatMap((item) => item.transactions) : data;

We can apply this approach to INVOICE type as well. Additionally, it's safer to check t?.pendingAction to avoid potential crashes.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

If we decide to apply the alternative solution, we can write unit tests for getSections.

What alternative solutions did you explore? (Optional)

We can return an empty array if the type is chat or task and groupBy exist.

App/src/libs/SearchUIUtils.ts

Line 1021 in 1bba92b

function getSections(type: SearchDataTypes, status: SearchStatus, data: OnyxTypes.SearchResults['data'], metadata: OnyxTypes.SearchResults['search'], groupBy?: SearchGroupBy) {

   if(groupBy&&(type === CONST.SEARCH.DATA_TYPES.CHAT || type === CONST.SEARCH.DATA_TYPES.TASK)) {
    return []
   }

[mountiny]

@nkdengineer Can you raise a PR please the proposals are similar and you were first

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021942912349281884886