[$250] Duplicate tool tip displayed on page refresh

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.82-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @MarioExpensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Create a new account and choose "Something else" as onboarding intent
2. Click + > Create Expense
3. Choose "Scan" option if not selected by default
4. Observe the Scan our test receipt tool tip
5. Refresh the page

Expected Result:

Page reloads without any error

Actual Result:

Duplicate tooltips appear now (one in the correct position, a second one at the top left of the screen)

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1428.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021947337752988532223
• Upwork Job ID: 1947337752988532223
• Last Price Increase: 2025-07-21

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Duplicate tooltips appear now (one in the correct position, a second one at the top left of the screen)

What is the root cause of that problem?

When the page is refreshed, we navigate to the deeplink route, which is the scan page. The problem is that the IOURequestStartPage is an OnyxTabNavigator. At the time we navigate to the scan tab here, the tab isn't init

App/src/libs/actions/Report.ts

Line 3447 in 38e0501

Navigation.navigate(route as Route);

That causes the navigation to be skipped here, and another scan page is added to the navigation stack.

App/src/libs/Navigation/helpers/linkTo/index.ts

Lines 100 to 102 in 371c8f3

	if (areNamesAndParamsEqual(currentState, stateFromPath) || arePathAndBackToEqual(stateFromPath)) {
	return;
	}

Then two tool tips appear.

What changes do you think we should make in order to solve the problem?

If the user is already signed in, we shouldn't navigate to this route again to prevent the duplicate

App/src/libs/actions/Report.ts

Line 3447 in 38e0501

Navigation.navigate(route as Route);

To do that, we can return early before the logic here. Only navigate to the report screen if need

if (isAuthenticated) {
    const report = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];
    // If the report does not exist, navigate to the last accessed report or Concierge chat
    if (reportID && !report) {
        const lastAccessedReportID = findLastAccessedReport(false, shouldOpenOnAdminRoom(), undefined, reportID)?.reportID;
        if (lastAccessedReportID) {
            const lastAccessedReportRoute = ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID);
            Navigation.navigate(lastAccessedReportRoute);
            return;
        }
        navigateToConciergeChat(false, () => true);
        return;
    }
    return;
}

App/src/libs/actions/Report.ts

Line 3392 in 38e0501

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

We should move the interaction manager from here to the navigation logic here

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dupe educational tooltip after refresh scan page.

What is the root cause of that problem?

We setup a linking getInitialUrl which is triggered after refresh.

App/src/Expensify.tsx

Lines 204 to 213 in 67242be

	// If the app is opened from a deep link, get the reportID (if exists) from the deep link and navigate to the chat report
	Linking.getInitialURL().then((url) => {
	// We use custom deeplink handler in setup/hybridApp
	if (CONFIG.IS_HYBRID_APP) {
	Report.doneCheckingPublicRoom();
	return;
	}
	setInitialUrl(url);
	Report.openReportFromDeepLink(url ?? '');
	});

The function is responsible to navigate the user to the URL from getInitialUrl.

App/src/libs/actions/Report.ts

Lines 3364 to 3470 in 67242be

	function openReportFromDeepLink(url: string) {
	const reportID = getReportIDFromLink(url);
	const isAuthenticated = hasAuthToken();
	if (reportID && !isAuthenticated) {
	// Call the OpenReport command to check in the server if it's a public room. If so, we'll open it as an anonymous user
	openReport(reportID, '', [], undefined, '0', true);
	// Show the sign-in page if the app is offline
	if (networkStatus === CONST.NETWORK.NETWORK_STATUS.OFFLINE) {
	doneCheckingPublicRoom();
	}
	} else {
	// If we're not opening a public room (no reportID) or the user is authenticated, we unblock the UI (hide splash screen)
	doneCheckingPublicRoom();
	}
	let route = getRouteFromLink(url);
	// Bing search results still link to /signin when searching for “Expensify”, but the /signin route no longer exists in our repo, so we redirect it to the home page to avoid showing a Not Found page.
	if (normalizePath(route) === CONST.SIGNIN_ROUTE) {
	route = '';
	}
	// If we are not authenticated and are navigating to a public screen, we don't want to navigate again to the screen after sign-in/sign-up
	if (!isAuthenticated && isPublicScreenRoute(route)) {
	return;
	}
	// Navigate to the report after sign-in/sign-up.
	InteractionManager.runAfterInteractions(() => {
	waitForUserSignIn().then(() => {
	const connection = Onyx.connect({
	key: ONYXKEYS.NVP_ONBOARDING,
	callback: (val) => {
	if (!val && !isAnonymousUser()) {
	return;
	}
	Navigation.waitForProtectedRoutes().then(() => {
	if (route && isAnonymousUser() && !canAnonymousUserAccessRoute(route)) {
	signOutAndRedirectToSignIn(true);
	return;
	}
	// We don't want to navigate to the exitTo route when creating a new workspace from a deep link,
	// because we already handle creating the optimistic policy and navigating to it in App.setUpPoliciesAndNavigate,
	// which is already called when AuthScreens mounts.
	if (!CONFIG.IS_HYBRID_APP && url && new URL(url).searchParams.get('exitTo') === ROUTES.WORKSPACE_NEW) {
	return;
	}
	const handleDeeplinkNavigation = () => {
	// We want to disconnect the connection so it won't trigger the deeplink again
	// every time the data is changed, for example, when re-login.
	Onyx.disconnect(connection);
	const state = navigationRef.getRootState();
	const currentFocusedRoute = findFocusedRoute(state);
	if (isOnboardingFlowName(currentFocusedRoute?.name)) {
	setOnboardingErrorMessage(Localize.translateLocal('onboarding.purpose.errorBackButton'));
	return;
	}
	if (shouldSkipDeepLinkNavigation(route)) {
	return;
	}
	// Check if the report exists in the collection
	const report = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];
	// If the report does not exist, navigate to the last accessed report or Concierge chat
	if (reportID && !report) {
	const lastAccessedReportID = findLastAccessedReport(false, shouldOpenOnAdminRoom(), undefined, reportID)?.reportID;
	if (lastAccessedReportID) {
	const lastAccessedReportRoute = ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID);
	Navigation.navigate(lastAccessedReportRoute);
	return;
	}
	navigateToConciergeChat(false, () => true);
	return;
	}
	Navigation.navigate(route as Route);
	};
	if (isAnonymousUser()) {
	handleDeeplinkNavigation();
	return;
	}
	// We need skip deeplinking if the user hasn't completed the guided setup flow.
	isOnboardingFlowCompleted({
	onNotCompleted: () =>
	startOnboardingFlow({
	onboardingValuesParam: val,
	hasAccessiblePolicies: !!account?.hasAccessibleDomainPolicies,
	isUserFromPublicDomain: !!account?.isFromPublicDomain,
	}),
	onCompleted: handleDeeplinkNavigation,
	onCanceled: handleDeeplinkNavigation,
	});
	});
	},
	});
	});
	});
	}

This causes another IOU scan page added to the stack. We already have a logic to prevent that to happen if we are navigating to the same currently focused route.

App/src/libs/Navigation/helpers/linkTo/index.ts

Lines 99 to 102 in 67242be

	// We don't want to dispatch action to push/replace with exactly the same route that is already focused.
	if (areNamesAndParamsEqual(currentState, stateFromPath) || arePathAndBackToEqual(stateFromPath)) {
	return;
	}

But the current state after refresh doesn't contain the IOU scan tab screen yet because we render null when the data is still loading,

App/src/libs/Navigation/OnyxTabNavigator.tsx

Lines 161 to 163 in 67242be

	if (isLoadingOnyxValue(selectedTabResult)) {
	return null;
	}

so it passes the check. We previously ignored the openReportFromDeeplink when the user is authenticated, but it was removed in #64056 because the deep link is being used in the hybrid app, and it's preventing the deep link from working on the hybrid. The initial purpose of openReportFromDeeplink is to handle the link when the user is logged out, so after login, the user is redirected to the link that they went on when logged out.

What changes do you think we should make in order to solve the problem?

We should add back the early return when the user is authenticated, but only if the app is not hybrid.

if (isAuthenticated && !CONFIG.IS_HYBRID_APP) {
    return;
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test openReportFromDeeplink and make sure the navigation code isn't called if authenticated on non hybrid app, but called on hybrid app.

[bernhardoj]

Oh, they will add the code back in #65506

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021947337752988532223

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-d (External)