[Due for payment 2025-08-13] [$250] Fix crash on onTextContextMenuItem

[luacmartins]

Problem

We have the following crash on Firebase

          Fatal Exception: java.lang.NullPointerException: Attempt to invoke interface method 'java.lang.String java.lang.CharSequence.toString()' on a null object reference
       at com.facebook.react.views.textinput.ReactEditText.onTextContextMenuItem(ReactEditText.java:371)
       at android.widget.Editor$TextActionModeCallback.onActionItemClicked(Editor.java:4512)
       at com.android.internal.policy.DecorView$ActionModeCallback2Wrapper.onActionItemClicked(DecorView.java:3076)
       at miuix.toolbar.FloatingActionModeHelper$ActionModeCallback2Wrapper.onActionItemClicked(FloatingActionModeHelper.java:51)
       at miuix.toolbar.FloatingActionMode$3.onMenuItemSelected(FloatingActionMode.java:115)
       at miuix.toolbar.internal.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:796)
       at miuix.toolbar.internal.menu.MenuItemImpl.invoke(MenuItemImpl.java:147)
       at miuix.toolbar.internal.menu.MenuBuilder.performItemAction(MenuBuilder.java:938)
       at miuix.toolbar.FloatingActionMode$4.onMenuItemClick(FloatingActionMode.java:123)
       at miuix.toolbar.internal.FloatingToolbar$3.onClick(FloatingToolbar.java:197)
       at android.view.View.performClick(View.java:7560)
       at android.view.View.performClickInternal(View.java:7533)
       at android.view.View.-$$Nest$mperformClickInternal()
       at android.view.View$PerformClick.run(View.java:29756)
       at android.os.Handler.handleCallback(Handler.java:942)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loopOnce(Looper.java:211)
       at android.os.Looper.loop(Looper.java:300)
       at android.app.ActivityThread.main(ActivityThread.java:8232)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1028)
        

Why is this important?

Fixes crashes

Solution

The crash seems to come from these two lines:

App/patches/react-native/react-native+0.79.2+011+Add-onPaste-to-TextInput.patch

Line 506 in a56164a

+ data = itemUri.toString();

App/patches/react-native/react-native+0.79.2+011+Add-onPaste-to-TextInput.patch

Line 516 in a56164a

+ data = item.getText().toString();

Let's fix it

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021946323008620095185
• Upwork Job ID: 1946323008620095185
• Last Price Increase: 2025-07-18
• Automatic offers:
• daledah | Contributor | 108142162

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @garrettmknight

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021946323008620095185

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-07-18 21:44:45 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crash

What is the root cause of that problem?

App crash because item.getText() can be null

App/patches/react-native/react-native+0.79.2+011+Add-onPaste-to-TextInput.patch

Line 518 in 577692f

+ data = item.getText().toString();

What changes do you think we should make in order to solve the problem?

We should check item.getText() != null here

+        if (clipData.getDescription().hasMimeType(ClipDescription.MIMETYPE_TEXT_PLAIN) && item?.getText() != null) {

App/patches/react-native/react-native+0.79.2+011+Add-onPaste-to-TextInput.patch

Lines 516 to 518 in 577692f

	+ if (clipData.getDescription().hasMimeType(ClipDescription.MIMETYPE_TEXT_PLAIN)) {
	+ type = ClipDescription.MIMETYPE_TEXT_PLAIN;
	+ data = item.getText().toString();

Or we can update like this

        if (clipData.getDescription().hasMimeType(ClipDescription.MIMETYPE_TEXT_PLAIN)) {
          type = ClipDescription.MIMETYPE_TEXT_PLAIN;
          CharSequence text = item.getText();
          if (text != null) {
            data = text.toString();
            if (mPasteWatcher != null) {
              mPasteWatcher.onPaste(type, data);
            }
          }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[suneox]

Based on the current crash log, @daledah proposal to check text != null LGTM
Also, itemUri.toString() will not cause a crash because itemUri != null is already checked.

App/patches/react-native/react-native+0.79.2+011+Add-onPaste-to-TextInput.patch

Line 503 in a56164a

+ if (itemUri != null) {

🎀 👀 🎀 C+ reviewed