[Due for payment 2025-09-19] [$250] Web - Rooms - The user can invite a member to the archived room

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.85-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/Expensify/issues/308051
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: macOS Sequoia 15.4.1
App Component: Other

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Create a new room
3. Delete the workspace link to that room
4. Go to members page of the archived room

Expected Result:

If chat room is archived, PageNotFound should be shown.

Actual Result:

The members page is accessible, the user can invite a member to the archived room.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6895836_1753233878338.Recording__308.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021949895400243942150
• Upwork Job ID: 1949895400243942150
• Last Price Increase: 2025-08-18
• Automatic offers:
• samranahm | Contributor | 108492519

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The members page is accessible, the user can invite a member to the archived room.

What is the root cause of that problem?

In room members page, we don't check if room is archived to show not found page:

App/src/pages/RoomMembersPage.tsx

Line 386 in 4775ecf

shouldShow={isEmptyObject(report) || (!isChatThread(report) && ((isUserCreatedPolicyRoom(report) && !isPolicyEmployee) || isDefaultRoom(report)))}

What changes do you think we should make in order to solve the problem?

We should add check for archived room in this case

    const isReportArchived = useReportIsArchived(report.reportID);

App/src/pages/RoomMembersPage.tsx

Line 386 in 4775ecf

shouldShow={isEmptyObject(report) || (!isChatThread(report) && ((isUserCreatedPolicyRoom(report) && !isPolicyEmployee) || isDefaultRoom(report)))}

shouldShow={isReportArchived || isEmptyObject(report) || (!isChatThread(report) && ((isUserCreatedPolicyRoom(report) && !isPolicyEmployee) || isDefaultRoom(report)))}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Rooms - The user can invite a member to the archived room

What is the root cause of that problem?

We only check if policy.policyID is equal to report.policyID to determine the user is an employee

App/src/pages/RoomMembersPage.tsx

Line 305 in 8f5942b

const isPolicyEmployee = useMemo(() => isPolicyEmployeeUtils(report.policyID, policy), [report?.policyID, policy]);

but the policy exists with partial data and id is populated so the condition will not fail and we wrongly assume the user is still an employee

What changes do you think we should make in order to solve the problem?

We need to make sure that the user is employee of the policy via checking the proper props of the policy like role of the user etc. We can use shouldShowPolicy for instance for this purpose

    const isPolicyEmployee = useMemo(() => shouldShowPolicy(policy, false, session?.email) && isPolicyEmployeeUtils(report.policyID, policy), [report?.policyID, policy]);

or

    const isPolicyEmployee = useMemo(() => isPolicyMember(session?.email, policy?.id) && isPolicyEmployeeUtils(report.policyID, policy), [session?.email, policy, report.policyID]);

Note we can isArchived check additionally (though checking policy member suffices) but checking if the user is proper member is still needed because partial policy data can sometimes be populated from BE in case of invitation of the user to a policy report which it is not a member. We can also add isPendingDeletePolicy check to include pending delete policies.

We can take this logic in isPolicyEmployeeUtils for generic fix because we use isPolicyEmployeeUtil in other places too to show menu items only for employees like here and the function doesn't properly check whether the user is an employee.

On a wider scope I also see we haven't implemented displaying NotFoundPage when the user can't edit in RoomDescriptionPage we can also check and fix other cases because I also see description menu displayed for an archived report here and also RoomInvitePage here and others so these can be handled in the PR phase.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-07-28 19:30:16 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Rooms - The user can invite a member to the archived room

What is the root cause of that problem?

When we delete the workspace and policy room get archived, will stil access the RoomMembersPage via
/members url and RoomInvitePage via /invite url because we don't check for archived report in both locations

here

App/src/pages/RoomInvitePage.tsx

Lines 242 to 243 in b04e219

	<FullPageNotFoundView
	shouldShow={isEmptyObject(report)}

and

App/src/pages/RoomMembersPage.tsx

Lines 385 to 386 in b04e219

	<FullPageNotFoundView
	shouldShow={isEmptyObject(report) || (!isChatThread(report) && ((isUserCreatedPolicyRoom(report) && !isPolicyEmployee) || isDefaultRoom(report)))}

What changes do you think we should make in order to solve the problem?

we should explicitly check for archived report like this

const isReportArchived = useReportIsArchived(report.reportID);

and add this to check to RoomMembersPage and RoomInvitePage FullPageNotFoundView component here

App/src/pages/RoomMembersPage.tsx

Line 386 in b04e219

shouldShow={isEmptyObject(report) || (!isChatThread(report) && ((isUserCreatedPolicyRoom(report) && !isPolicyEmployee) || isDefaultRoom(report)))}

and

App/src/pages/RoomInvitePage.tsx

Line 243 in b04e219

shouldShow={isEmptyObject(report)}

Note

We need to update the shouldShow on both invite and members url so when a user paste a next url to members page they should still see not found page.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021949895400243942150

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)