[HOLD for payment 2021-12-28] New Room - Translate Room visibility - Reported by: @mananjadhav

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com
2. Log in with expensifail account
3. Set language to Spanish
4. Click on Plus button and Click on New Room
5. Check room visibility options

Expected Result:

Room visibility options should be translated

Actual Result:

The translation is missing in WorkspaceNewRoomPage for ExpensiPicker .
Room visibility options are in English only even if I've set the language as Spanish

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.20-0
Reproducible in staging?: Y
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @mananjadhav
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1639334834136500

View all open jobs on GitHub

view this job on upwork

[MelvinBot]

Triggered auto assignment to @jboniface (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[MelvinBot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mananjadhav]

Proposal if made external

The translation is missing in ‘WorkspaceNewRoomPage’ for ‘ExpensiPicker’. We should reference them then with translate and relevant language files.

  <ExpensiPicker
                        value={CONST.REPORT.VISIBILITY.RESTRICTED}
                        label={this.props.translate('newRoomPage.visibility')}
                        items={[
                            {label: this.props.translate(CONST.REPORT.VISIBILITY.RESTRICTED), value: CONST.REPORT.VISIBILITY.RESTRICTED},
                            {label: this.props.translate(CONST.REPORT.VISIBILITY.PRIVATE), value: CONST.REPORT.VISIBILITY.PRIVATE},
                        ]}
                        onChange={visibility => this.setState({visibility})}
                    />
                    

and add relevant restricted and private keys to en.js and es.js

[MelvinBot]

Current assignee @jboniface is eligible for the External assigner, not assigning anyone new.

[mehtamanan]

unsubscribe

…

On Tue, Dec 14, 2021 at 4:34 AM MelvinBot ***@***.***> wrote: Current assignee @jboniface <https://github.com/jboniface> is eligible for the External assigner, not assigning anyone new. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6733 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACG62DQBJNDGNISG5VDLIDUQYVD7ANCNFSM5J6KEB4Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[mananjadhav]

@mvtglobally My Github username is @mananjadhav. Guessing the space caused it to send the notification to somebody else. Can you please correct it?

[jboniface]

https://www.upwork.com/jobs/~01e07d655b1bb33138 posted