[Due for payment 2025-12-05] Fix free trial message display order

[carlosmiceli]

See the video below, the Free Trial message appears briefly below the task list, and then moves to the top where it should be. Let's fix that flashing bug

Screen.Recording.2025-07-28.at.11.43.35.PM.mov

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021968469432619817709
• Upwork Job ID: 1968469432619817709
• Last Price Increase: 2025-09-18

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

the Free Trial message appears briefly below the task list, and then moves to the top where it should be.

What is the root cause of that problem?

After we complete the onboarding, GetMissingOnyxMessages is called, and the free trial message is returned from the backend. At this time, the current created of the onboarding task isn't updated due to some APIs are still calling. Then the free trial message is displayed as the last message.

What changes do you think we should make in order to solve the problem?

In the same way we create the welcome sign-off message, we can also create the free trial message if we create the task in the admin room

App/src/libs/ReportUtils.ts

Line 10281 in a23ee2d

const welcomeSignOffText =

1. This action should be created first before the text message to correct the order.

App/src/libs/ReportUtils.ts

Line 10200 in a23ee2d

2. We need to push this message data to the guidedSetupData like the same here

App/src/libs/ReportUtils.ts

Line 10698 in a23ee2d

guidedSetupData.push({type: 'message', ...welcomeSignOffMessage});

3. Maybe we need the backend change to support creating the free trial message with the data we passed to guidedSetupData

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update prepareOnboardingOnyxData unit test to verify that the free trial message is created if the user is not the test user.

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nabi-ebrahimi]

This is not reproducible on my end.

Screen.Recording.1404-05-13.at.7.33.08.PM.mp4

[carlosmiceli]

@nabi-ebrahimi you should test in production.

[melvin-bot]

@akinwale Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@akinwale 6 days overdue. This is scarier than being forced to listen to Vogon poetry!