[Due for payment 2025-10-22] [HOLD #69341][$500] Invoice - Invoice details page opens when clicking Concierge on the whisper in invoice thread

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.92-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-119/folder/13177075/41237841/830240812
Email or phone of affected tester (no customers): sjodijnsojdsoij@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Invoice feature is enabled

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit an expense to workspace chat
4. Open expense report
5. Mention a user who is not a member of the report and send the message
6. Click Concierge on the whisper
   → Concierge profile opens
7. Open FAB > Send invoice
8. Send an invoice to any user
9. Open invoice thread
10. Mention a user who is not a member of the report and send the message
11. Click Concierge on the whisper

Expected Result:

Concierge profile opens

Actual Result:

Invoice details page opens when clicking on Concierge on the whisper in invoice thread

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6913015_1754833179454.Screen_Recording_2025-08-10_at_21.32.21.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021955556600223096668
• Upwork Job ID: 1955556600223096668
• Last Price Increase: 2025-09-03
• Automatic offers:
• QichenZhu | Reviewer | 108972310

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dmkt9]

🚨 Edited by proposal-police: This proposal was edited at 2025-08-15 02:36:03 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invoice details page opens when clicking on Concierge on the whisper in invoice thread

What is the root cause of that problem?

1. With isWorkspaceActor === true we will display workspace details:
   

   App/src/pages/home/report/ReportActionItemSingle.tsx

   Lines 114 to 117 in dd11c95

   	const showActorDetails = useCallback(() => {
   	if (details.isWorkspaceActor) {
   	showWorkspaceDetails(reportID);
   	} else {

2. isWorkspaceActor will always be true for invoice reports:
   

   App/src/components/ReportActionAvatars/useReportActionAvatars.ts

   Line 149 in dd11c95

   const isWorkspaceActor = isAInvoiceReport || (isAWorkspaceChat && (!actorAccountID || displayAllActors));

What changes do you think we should make in order to solve the problem?

In the case of a workspace actor, the avatar type is displayed as a subscript avatar:

App/src/components/ReportActionAvatars/useReportActionAvatars.ts

Lines 171 to 172 in 8dcc9d3

	if (shouldUseSubscriptAvatar) {
	avatarType = CONST.REPORT_ACTION_AVATARS.TYPE.SUBSCRIPT;

Therefore, we can use the shouldUseSubscriptAvatar condition for isWorkspaceActor.

Why this works: If the avatar is rendered as a subscript avatar, it will definitely require opening the workspace details.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Add a condition to check if it is Concierge then isWorkspaceActor is always false:

App/src/components/ReportActionAvatars/useReportActionAvatars.ts

Line 149 in dd11c95

const isWorkspaceActor = isAInvoiceReport || (isAWorkspaceChat && (!actorAccountID || displayAllActors));

const isWorkspaceActor = accountID !== CONST.ACCOUNT_ID.CONCIERGE && (isAInvoiceReport || (isAWorkspaceChat && (!actorAccountID || displayAllActors)));

Note: We can add a similar Concierge check to displayAllActors to ensure that only the Concierge profile is displayed:

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-08-14 03:54:00 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invoice details page opens when clicking on Concierge on the whisper in invoice thread

What is the root cause of that problem?

isWorkspaceActor is always true for the invoice report, then any action's avatar in the invoice report will open the report detail page.

App/src/components/ReportActionAvatars/useReportActionAvatars.ts

Line 175 in 15e889b

const isWorkspaceActor = isAInvoiceReport || (isAWorkspaceChat && (!actorAccountID || displayAllActors));

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 114 to 119 in 15e889b

	const showActorDetails = useCallback(() => {
	if (details.isWorkspaceActor) {
	showWorkspaceDetails(reportID);
	} else {
	// Show participants page IOU report preview
	if (iouReportID && details.shouldDisplayAllActors) {

What changes do you think we should make in order to solve the problem?

isWorkspaceActor should only true if the report action is report preview

const isWorkspaceActor = isAReportPreviewAction && (isAInvoiceReport || (isAWorkspaceChat && (!actorAccountID || displayAllActors)));

App/src/components/ReportActionAvatars/useReportActionAvatars.ts

Line 175 in 15e889b

const isWorkspaceActor = isAInvoiceReport || (isAWorkspaceChat && (!actorAccountID || displayAllActors));

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[JmillsExpensify]

I'll open this up since there are proposals though I'm also adding weekly since this is lower priority.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021955556600223096668