[Due for payment 2025-12-26] [$250] When tapping back, not here page is seen

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.95-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #68285
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Macbook Pro 2023 / Sequoia 15.2
App Component: Other

Action Performed:

1. Access www.staging.new.expensify.com and sign into a valid account
2. Input: workspaces/:workspaceID/change-owner/78878/failure.
3. Tap on "Back" button

Expected Result:

User expects to be redirected to previous page

Actual Result:

User is taken to a "Not here" page.

Note: The Green icon also looks a tad bit off center position

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021957975793558408058
• Upwork Job ID: 1957975793558408058
• Last Price Increase: 2025-08-20
• Automatic offers:
• daledah | Contributor | 108490782

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ChavdaSachin]

This should be fixed in This PR

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is taken to a "Not here" page.

What is the root cause of that problem?

We get the accountID and policyID from the route here

App/src/pages/workspace/members/WorkspaceOwnerChangeErrorPage.tsx

Lines 28 to 29 in 4d29406

	const accountID = Number(route.params.accountID) ?? -1;
	const policyID = route.params.policyID;

And will navigate to the member detail page when clicking the header back button and confirm button even in case the account id is invalid

App/src/pages/workspace/members/WorkspaceOwnerChangeErrorPage.tsx

Lines 31 to 35 in 4d29406

	const closePage = useCallback(() => {
	clearWorkspaceOwnerChangeFlow(policyID);
	Navigation.goBack();
	Navigation.navigate(ROUTES.WORKSPACE_MEMBER_DETAILS.getRoute(policyID, accountID));
	}, [accountID, policyID]);

What changes do you think we should make in order to solve the problem?

We should only navigate to the member details page when that user is a member of the workspace.

    const closePage = useCallback(() => {
        MemberActions.clearWorkspaceOwnerChangeFlow(policyID);
        if (isPolicyMember(getLoginByAccountID(accountID), policyID)) {
            Navigation.goBack();
            Navigation.navigate(ROUTES.WORKSPACE_MEMBER_DETAILS.getRoute(policyID, accountID));
        } else {
            Navigation.dismissModal();
        }
    }, [accountID, policyID]);

App/src/pages/workspace/members/WorkspaceOwnerChangeErrorPage.tsx

Lines 31 to 35 in 4d29406

	const closePage = useCallback(() => {
	clearWorkspaceOwnerChangeFlow(policyID);
	Navigation.goBack();
	Navigation.navigate(ROUTES.WORKSPACE_MEMBER_DETAILS.getRoute(policyID, accountID));
	}, [accountID, policyID]);

The same thing happens with the WorkspaceOwnerChangeSuccessPage and WorkspaceOwnerChangeWrapperPage pages so I think we should fix it in this issue too

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

If that accountID is not of a member in the workspace then we can show not found page

    const isMember = isPolicyMember(getLoginByAccountID(accountID), policyID);
    if(!isMember){
        return <NotFoundPage />
    }

Or we can add the condition like here, If the user is not admin or the user is owner, we will show not found page.

App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

Lines 323 to 330 in 1e8ec1b

	{isSelectedMemberOwner && isCurrentUserAdmin && !isCurrentUserOwner ? (
	shouldRenderTransferOwnerButton() && (
	<ButtonDisabledWhenOffline
	text={translate('workspace.people.transferOwner')}
	onPress={startChangeOwnershipFlow}
	icon={Expensicons.Transfer}
	style={styles.mb5}
	/>

or we can add useEffect to navigate back to member page when that account id is not eligible to transfer owner

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021957975793558408058

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[lorretheboy]

🚨 Edited by proposal-police: This proposal was edited at 2025-08-20 07:35:31 UTC.

Not duplicate since 2 proposals are handling in different ways

Proposal

Please re-state the problem that we are trying to solve in this issue.

When tapping back, not here page is seen

What is the root cause of that problem?

The problem is due to invalid member validation: The code was trying to navigate to member details pages for accounts that might not be valid members of the workspace, triggering the AccessOrNotFoundWrapper to show the "Not here" page

App/src/pages/workspace/members/WorkspaceOwnerChangeErrorPage.tsx

Lines 28 to 35 in b4aba98

	const accountID = Number(route.params.accountID) ?? -1;
	const policyID = route.params.policyID;
	const closePage = useCallback(() => {
	clearWorkspaceOwnerChangeFlow(policyID);
	Navigation.goBack();
	Navigation.navigate(ROUTES.WORKSPACE_MEMBER_DETAILS.getRoute(policyID, accountID));
	}, [accountID, policyID]);

What changes do you think we should make in order to solve the problem?

Use this code to get needed data

    const memberExists = isPolicyMember(getLoginByAccountID(accountID), policyID);

So in here we could update to check if the account ID corresponds to a valid workspace member before deciding where to navigate

Note: By using this way, we can safely remove the Navigation.goBack() which looks like a hack solution so that it can also prevent no navigation history issue where it fails silently and does nothing

    const closePage = useCallback(() => {
        clearWorkspaceOwnerChangeFlow(policyID);

        // If member exists, navigate to member details; otherwise go to workspace members page
        if (memberExists) {
            Navigation.goBack(ROUTES.WORKSPACE_MEMBER_DETAILS.getRoute(policyID, accountID));
        } else {
            Navigation.goBack(ROUTES.WORKSPACE_MEMBERS.getRoute(policyID));
        }
    }, [accountID, policyID, memberExists]);

We can apply to similar places such as WorkspaceOwnerChangeErrorPage.tsx, WorkspaceOwnerChangeSuccessPage.tsx, and WorkspaceOwnerChangeWrapperPage.tsx

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.