[Due for payment 2025-11-21] [$250] Full story : Missing direct link to fix broken bank connection in violation message

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): #Convert

Description:

When a bank connection is broken, the violation message shown on an expense says:
"Can't auto-match receipt due to broken bank connection which you need to fix."
However, unlike other violation messages, it does not include a clickable link that takes the user directly to the location where they can resolve the issue.

Expected Result:

The violation message should include a short clickable link (e.g., “fix”) that takes the user directly to the bank connection page.

Actual Result:

No clickable link is provided to take the user directly to the bank connection fix screen.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021957604054474119342
• Upwork Job ID: 1957604054474119342
• Last Price Increase: 2025-09-09
• Automatic offers:
• samranahm | Contributor | 109336360

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-08-30 07:18:26 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Missing direct link to fix broken bank connection in violation message

What is the root cause of that problem?

new feat

What changes do you think we should make in order to solve the problem?

we have the translation copy for rter here

App/src/languages/en.ts

Lines 6502 to 6510 in 4d29406

	rter: ({brokenBankConnection, email, isAdmin, isTransactionOlderThan7Days, member, rterType}: ViolationsRterParams) => {
	if (rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION_530) {
	return "Can't auto-match receipt due to broken bank connection";
	}
	if (brokenBankConnection || rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION) {
	return isAdmin
	? `Can't auto-match receipt due to broken bank connection which ${email} needs to fix`
	: "Can't auto-match receipt due to broken bank connection which you need to fix";
	}

Since we already have Parser here to convert html to text

App/src/libs/Violations/ViolationsUtils.ts

Lines 608 to 609 in ae5f666

	const textMessage = Parser.htmlToText(message);
	return textMessage.endsWith('.') ? message : `${message}.`;

we should update this translation to meet new expected results

App/src/languages/en.ts

Lines 6599 to 6603 in d4645bf

	if (brokenBankConnection || rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION) {
	return isAdmin
	? `Can't auto-match receipt due to broken bank connection which ${email} needs to fix`
	: "Can't auto-match receipt due to broken bank connection which you need to fix";
	}

return isAdmin
    ? `Bank connection broken. <a href="${companyCardPageURL}">Reconnect to match receipt</a>`
    : 'Bank connection broken. Ask an admin to reconnect to match receipt.';

and add the companyCardPageURL in violation.data to pass it to rter

    companyCardPageURL: `${environmentURL}/${ROUTES.WORKSPACE_COMPANY_CARDS.getRoute(policyID)}`,

We should also remove the email param from rter data since it's not being used in copy anymore.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We should update our getViolationTranslation unit test to get the updated copy of violation

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[VictoriaExpensify]

Chatted in thread about the message that should be surfaced - agreed on this:

Bank connection broken. Reconnect to match receipt.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021957604054474119342

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)