[$125] Expense - When approving non-reimbursable expense, "Approve" does not change to "👍 Approved"

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.97-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #68581
Email or phone of affected tester (no customers): sdjoidsnjdosijods@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com

2. Go to workspace chat.

3. Submit two reimbursable expenses to the workspace chat.

4. Open expense report.

5. Select any expense via checkbox > Click More > Hold.

6. Enter reason and save it.

7. Click Submit and Approve.

8. Approve the pending (unheld) amount.
   → Note that Approve button changes to 👍 Approved and disappears.

9. Go back to workspace chat and open the held expense, then click More > Submit.

10. Go back to workspace chat.

11. Submit two expenses to the workspace chat - one is reimbursable, the other one is not reimbursable.

12. Open the expense report.

13. Select the reimbursable expense via checkbox > Click More > Hold.

14. Enter reason and save it.

15. Click Submit and Approve.

Expected Result:

When the pending expense is not reimbursable, Approve button will change to 👍 Approved and disappear.

Actual Result:

When the pending expense is not reimbursable, Approve button does not change to 👍 Approved. It remains as Approve and then disappears.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6923676_1755853061273.Screen_Recording_2025-08-22_at_16.49.13.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021958834314051300581
• Upwork Job ID: 1958834314051300581
• Last Price Increase: 2025-08-22

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[twisterdotcom]

Wow, niche. The button disappears almost immediately, so one time we see:

And another time we see:

I imagine it's due to the fact one time we show the pay button after. This has very little customer impact, so I'm downgrading to weekly and $125.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021958834314051300581

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[melvin-bot]

⚠️ Failed to update price automatically. The BZ team member will need to update the price manually in Upwork.