[Due for payment 2025-10-27] [$250] Expense - "On Hold" status is not removed after expense is moved to Self DM

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.98-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-417/folder/13176670/44210700/856397657
Email or phone of affected tester (no customers): ibellicotest+1648@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Prerequisite: Account has at least one workspace available
Prerequisite 2: Account has a Self DM

1. Open the Expensify app
2. Open any workspace chat
3. Create a manual expense
4. Open the just created expense
5. Tap on "More" and select "Hold"
6. Enter any reason and hold the expense
7. Once redireted to report, tap on the report field
8. Tap on "Remove from report"
9. Navigate to Self DM
10. Note that "On Hold" status was not removed from expense

Expected Result:

"On hold" status should be removed from expense after being moved to Self DM

Actual Result:

Expense remains with "On Hold" status after being moved to Self DM

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.3684.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021961434673449718572
• Upwork Job ID: 1961434673449718572
• Last Price Increase: 2025-09-05
• Automatic offers:
• daledah | Contributor | 108743841

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense remains with "On Hold" status after being moved to Self DM

What is the root cause of that problem?

We don't clear the comment.hold in the transaction when calling the CHANGE_TRANSACTIONS_REPORT api

App/src/libs/actions/Transaction.ts

Lines 763 to 780 in 86123f4

	// Optimistically clear all violations for the transaction when moving to self DM report
	if (reportID === CONST.REPORT.UNREPORTED_REPORT_ID) {
	const duplicateViolation = currentTransactionViolations?.[transaction.transactionID]?.find((violation) => violation.name === CONST.VIOLATIONS.DUPLICATED_TRANSACTION);
	const duplicateTransactionIDs = duplicateViolation?.data?.duplicates;
	if (duplicateTransactionIDs) {
	duplicateTransactionIDs.forEach((id) => {
	optimisticData.push({
	onyxMethod: Onyx.METHOD.SET,
	key: `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${id}`,
	value: allTransactionViolations.filter((violation: TransactionViolation) => violation.name !== CONST.VIOLATIONS.DUPLICATED_TRANSACTION),
	});
	});
	}
	optimisticData.push({
	onyxMethod: Onyx.METHOD.SET,
	key: `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transaction.transactionID}`,
	value: null,
	});

=> isOnHold still return true

App/src/libs/TransactionUtils/index.ts

Lines 1176 to 1185 in 86123f4

	/**
	* Check if transaction is on hold
	*/
	function isOnHold(transaction: OnyxEntry<Transaction>): boolean {
	if (!transaction) {
	return false;
	}
	return !!transaction.comment?.hold;
	}

What changes do you think we should make in order to solve the problem?

We should do the same way that we did with the deleteAppReport API here

App/src/libs/actions/Report.ts

Lines 4873 to 4879 in 86123f4

	optimisticData.push(
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`,
	value: {reportID: CONST.REPORT.UNREPORTED_REPORT_ID, comment: {hold: null}},
	},
	{

1. We should clear the hold comment there to clear the hold status in the optimistic data

            optimisticData.push({
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transaction.transactionID}`,
                value: {comment: {hold: null}},
            });

and revert this in failureData

            failureData.push(
                {
                    onyxMethod: Onyx.METHOD.MERGE,
                    key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transaction.transactionID}`,
                    value: {comment: {hold: transaction?.comment?.hold}},
                },
            );

2. Build the unhold report action in the expense chat like we did here

App/src/libs/actions/Report.ts

Lines 4899 to 4905 in 86123f4

	if (isOnHold(transaction)) {
	const unHoldAction = buildOptimisticUnHoldReportAction();
	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${childReportID}`,
	value: {[unHoldAction.reportActionID]: unHoldAction},
	});

3. The backend change is required here to clear the hold comment from the transaction

Note: with the same root cause and the behaviour, we can implement the same as this PR did for deleteAppReport api

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update changeTransactionsReport test to verify that the transaction's hold status is cleared.

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dylanexpensify]

Hm, I don't agree that the hold should be removed once moved to selfDM if the submitter held the expense. Confirming logic.

[daledah]

@dylanexpensify could you please confirm the expected here?

[dylanexpensify]

asking internally!

[dylanexpensify]

Tis a bug!