[Due for payment 2025-09-17] [$250] Copilot - Copilot mode persists after logout and re-login as regular user

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.98-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory
Email or phone of affected tester (no customers): applausetester+dp267@applause.expensifail.com and applausetester+dp305@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac / Safari
App Component: User Settings

Action Performed:

1. Ensure User A has User B set as a copilot.
2. Login as User B.
3. Switch to copilot mode of User A.
4. Logout from the application.
5. Login as User A.

Expected Result:

User A should log in as a regular account.
No copilot mode should be active.
No copilot-specific UI or restrictions should be visible.

Actual Result:

After logging in as User A, the account is still in copilot mode.
Copilot-specific restrictions are applied.
Hovering over the avatar shows a “Copilot Mode” tag.
Only after attempting to switch to the copilot account, the app finally refreshes and displays the regular User A account view.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021960013539809758454
• Upwork Job ID: 1960013539809758454
• Last Price Increase: 2025-09-01

Issue Owner

Current Issue Owner: @clarajones-expensify

[melvin-bot]

Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After logging in as User A, the account is still in copilot mode.
Copilot-specific restrictions are applied.
Hovering over the avatar shows a “Copilot Mode” tag.
Only after attempting to switch to the copilot account, the app finally refreshes and displays the regular User A account view.

What is the root cause of that problem?

After logout, we still preserve the account

App/src/libs/actions/App.ts

Line 608 in afa5bf8

Onyx.clear(KEYS_TO_PRESERVE)

App/src/libs/actions/App.ts

Line 103 in afa5bf8

ONYXKEYS.ACCOUNT,

so the delegatedAccess.delegate is not removed

when login to new account, new account data from BE will be merged with current data so delegatedAccess.delegate is not cleared

if delegatedAccess.delegate has data, we will show the copilot mode

App/src/pages/home/sidebar/NavigationTabBarAvatar.tsx

Lines 37 to 44 in afa5bf8

	if (delegateEmail) {
	children = (
	<AvatarWithDelegateAvatar
	delegateEmail={delegateEmail}
	isSelected={isSelected}
	containerStyle={styles.sidebarStatusAvatarWithEmojiContainer}
	/>
	);

What changes do you think we should make in order to solve the problem?

We should clear the account data in

App/src/libs/actions/App.ts

Lines 624 to 626 in afa5bf8

	if (shouldUseStagingServer) {
	Onyx.set(ONYXKEYS.ACCOUNT, {shouldUseStagingServer});
	}

no matter shouldUseStagingServer is

Onyx.set(ONYXKEYS.ACCOUNT, {shouldUseStagingServer});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

We can consider to set only delegatedAccess to null in here

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021960013539809758454

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[clarajones-expensify]

Hi @hoangzinh ! Would you review the above proposal when you get a chance? thanks!

[mukhrr]

🚨 Edited by proposal-police: This proposal was edited at 2025-08-25 19:02:53 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Copilot mode persists after logout and re-login as regular user

What is the root cause of that problem?

The issue is in the clearStorageAndRedirect function in src/libs/actions/SignInRedirect.ts. The ONYXKEYS.ACCOUNT is included in the keysToPreserve array, which means that when a user logs out, the account data (including the delegatedAccess information) is not cleared from Onyx storage:

App/src/libs/actions/SignInRedirect.ts

Lines 35 to 44 in 5a6bab7

	return Onyx.clear(keysToPreserve).then(() => {
	clearAllPolicies();
	if (!errorMessage) {
	return;
	}
	// `Onyx.clear` reinitializes the Onyx instance with initial values so use `Onyx.merge` instead of `Onyx.set`
	Onyx.merge(ONYXKEYS.SESSION, {errors: getMicroSecondOnyxErrorWithMessage(errorMessage)});
	});

Here's what happens in the bug scenario:
-> User A sets User B as copilot - This stores delegatedAccess data in the account
-> User B logs in and switches to copilot mode - This sets delegatedAccess.delegate to User A's email
-> User B logs out - The clearStorageAndRedirect function preserves the ONYXKEYS.ACCOUNT data, so delegatedAccess.delegate remains set
-> User A logs in - The app still shows copilot mode because delegatedAccess.delegate is still present in the account data

What changes do you think we should make in order to solve the problem?

The fix is to ensure that delegatedAccess is properly cleared during logout. We need to set it to null in the clearStorageAndRedirect:

  return Onyx.clear(keysToPreserve).then(() => {
           // we will clear `delegatedAccess` from account data to ensure copilot mode is properly reset on logout
        Onyx.merge(ONYXKEYS.ACCOUNT, {delegatedAccess: null});
        
        clearAllPolicies();
        if (!errorMessage) {
            return;
        }

        // `Onyx.clear` reinitializes the Onyx instance with initial values so use `Onyx.merge` instead of `Onyx.set`
        Onyx.merge(ONYXKEYS.SESSION, {errors: getMicroSecondOnyxErrorWithMessage(errorMessage)});
    });

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

I think we should keep user's shouldUseStagingServer‎ value

App/src/libs/actions/App.ts

Line 65 in afa5bf8

preservedShouldUseStagingServer = value?.shouldUseStagingServer;

Regarding this, I'd suggest the solution in clearStorageAndRedirect

Onyx.set(ONYXKEYS.ACCOUNT, {...CONST.DEFAULT_ACCOUNT_DATA, shouldUseStagingServer });

[github-actions]

⚠️ @mukhrr Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[mukhrr]

Updated proposal