[Due for payment 2025-09-17] [Change Approver] Expense - No error above Change approver button when Bypass approvers is not selected

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.99-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #66899
Email or phone of affected tester (no customers): sdondsijsodios@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Admin invites User A and User B to the workspace.
• Create a new approval workflow where User A submits to User B (approver).

1. Go to staging.new.expensify.com
2. [User A] Go to workspace chat.
3. [User A] Create an expense in the workspace chat and click Submit on the expense preview.
4. [Admin] Open workspace chat with User A.
5. [Admin] Open the expense report.
6. [Admin] Click More > Change approver.
7. [Admin] Click Change approver without selecting Bypass approvers.

Expected Result:

Error will show up above Change approver button because a selection must be made.

Actual Result:

There is no error above Change approver button when Bypass approvers is not selected.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6927205_1756211714790.Screen_Recording_2025-08-26_at_20.31.36.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[marufsharifi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - No error above Change approver button when Bypass approvers is not selected

What is the root cause of that problem?

We only return if selectedApproverType is not selected.

App/src/pages/ReportChangeApproverPage.tsx

Lines 40 to 44 in 22df923

	const changeApprover = useCallback(() => {
	if (!selectedApproverType) {
	return;
	}

What changes do you think we should make in order to solve the problem?

We should disable the Change Approver button if selectedApproverType is not selected. Add the following prop to the selection list component

   isConfirmButtonDisabled={!selectedApproverType}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

We can show an error on top of the Change approver button if selectedApproverType is not selected.

Define a local state for error

  const [hasError, setHasError] = useState(false);

Then in changeApprover, when selectedApproverType is not selected, setHasError(true)

    const changeApprover = useCallback(() => {
        if (!selectedApproverType) {
            setHasError(true);
            return;
        }

And update the the jsx to show the error and remove the error when the user selects an option.

        <SelectionList
                ListItem={RadioListItem}
                sections={sections}
                isAlternateTextMultilineSupported
                onSelectRow={(option) => {
                    setSelectedApproverType(option.keyForList);
                    setHasError(false);
                }}
                showConfirmButton
                confirmButtonText={translate('iou.changeApprover.title')}
                onConfirm={changeApprover}
                customListHeader={
                    <>
                        <Text style={[styles.ph5, styles.mb5]}>{translate('iou.changeApprover.subtitle')}</Text>
                        <View style={[styles.ph5, styles.mb5, styles.renderHTML, styles.flexRow]}>
                            <RenderHTML html={translate('iou.changeApprover.description', {workflowSettingLink: `${environmentURL}/${ROUTES.WORKSPACE_WORKFLOWS.getRoute(policy?.id)}`})} />
                        </View>
                    </>
                }
            >
                <View style={[styles.ph5, styles.mb3]}>
                    {hasError && (
                        <FormHelpMessage
                            isError={hasError}
                            message={translate('common.error.pleaseSelectOne')}
                        />
                    )}
                </View>
            </SelectionList>

We can add a new text for the error, other than the common error message when no option is selected. And we can create a callback for onSelectRow instead of an inline function.