[$250] [Due for payment 2026-02-19] Expense not greyed out in search when deleted offline

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.0-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @Ollyws
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Submit an expense
2. Go to Reports > Expenses
3. Go offline
4. Click on the submitted expense
5. Click More > Delete
6. Delete the expense

Expected Result:

Expense should be greyed out or struck-though

Actual Result:

Expense is not greyed out aside from the submit button

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1585.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @laurenreidexpensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022024812602397917166
• Upwork Job ID: 2024812602397917166
• Last Price Increase: 2026-02-20

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[aadil42]

@m-natarajan, can you tell me what is the shortcut for bringing up the troubleshoot menu as popup? I know I can do it from the settings. but shortcut would be convenient for future as well. Thank you.

[lorretheboy]

@aadil42 cmd + D

[aadil42]

Thanks.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense not greyed out in search when deleted offline

What is the root cause of that problem?

Improvement, we haven't handled this case

What changes do you think we should make in order to solve the problem?

Add new props isPendingDelete?: boolean in TransactionItemRowProps

App/src/components/TransactionItemRow/index.tsx

Line 81 in b18a398

type TransactionItemRowProps = {

Then pass the props to here

App/src/components/TransactionItemRow/index.tsx

Line 273 in b18a398

<MerchantOrDescriptionCell

App/src/components/TransactionItemRow/index.tsx

Line 287 in b18a398

<MerchantOrDescriptionCell

App/src/components/TransactionItemRow/index.tsx

Line 428 in b18a398

<MerchantOrDescriptionCell

In MerchantCell, update to:

        <TextWithTooltip
            shouldShowTooltip={shouldShowTooltip}
            text={html}
            style={[
                !shouldUseNarrowLayout ? styles.lineHeightLarge : styles.lh20,
                styles.pre,
                styles.justifyContentCenter,
                styles.flex1,
                isPendingDelete && styles.lineThrough,
            ]}
            shouldRenderAsHTML={shouldRenderAsHTML}
        />

App/src/components/TransactionItemRow/DataCells/MerchantCell.tsx

Lines 27 to 32 in b5c4653

	<TextWithTooltip
	shouldShowTooltip={shouldShowTooltip}
	text={html}
	style={[!shouldUseNarrowLayout ? styles.lineHeightLarge : styles.lh20, styles.pre, styles.justifyContentCenter, styles.flex1]}
	shouldRenderAsHTML={shouldRenderAsHTML}
	/>

Note: isPendingDelete is a prop with default value is false in MerchantCell

Add here

                    isPendingDelete={item.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE}

App/src/components/SelectionList/Search/TransactionListItem.tsx

Line 134 in 3ff92d1

<TransactionItemRow

IMPORTANT: In this proposal, I only do for MerchantOrDescriptionCell, we should do similar this approach to all other fields such as TotalCell, DateCell, TypeCell, CategoryCell,... It will be similar (just need update to add props and style like in MerchantCell)

Example for style:

 isPendingDelete && styles.lineThrough

One more note: Here I suggest strikethrough style to several fields, we can adjust which col we should add based on design team if needed

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[aadil42]

@lorretheboy, I think the root cause is this. But I don't know how to solve it. I hope it helps you solve. Below is my RCA:

This is where we're getting all the data to display.

App/src/pages/Search/SearchPage.tsx

Line 94 in d4645bf

const [currentSearchResults] = useOnyx(`${ONYXKEYS.COLLECTION.SNAPSHOT}${queryJSON?.hash ?? CONST.DEFAULT_NUMBER_ID}`, {canBeMissing: true});

The transaction we're deleting doesn't have pendingAction property set.
the pendingAction is set in transaction_id in onyx but in snap_hash you can see all the transactions. There our transaction is present and you'll find we don't have pendingAction set there.

In this screenshot we're logging snapshot_hash in console. You can see transaction_id data in the onyx in application tab.

I hope it helps other people solve it.

Thank you.

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)