[DUE for PAYMENT 2025-10-20] [$250] Approve Button in Secondary Actions Menu Incorrectly Displays Amount

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.12-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dannymcclain
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Go to a workspace chat
2. Submit duplicate expenses
3. Open the more action menu
4. Observe the text of the Approve button.

Expected Result:

The Approve button should display only “Approve” (no amount).

Actual Result:

The Approve button displays “Approve [amount]”.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021968406260555459573
• Upwork Job ID: 1968406260555459573
• Last Price Increase: 2025-09-17
• Automatic offers:
• abzokhattab | Contributor | 108895987

Issue Owner

Current Issue Owner: @jasperhuangg

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Approve button in the Secondary Actions Menu incorrectly displays "Approve [amount]" instead of just "Approve".

What is the root cause of that problem?

• The getAmount() function is being called with CONST.REPORT.SECONDARY_ACTIONS.APPROVE parameter here
• This function expects a REPORT_PREVIEW_ACTIONS parameter, not SECONDARY_ACTIONS
• The function returns {formattedAmount: string} which gets passed to the translation function
• The translation function iou.approve displays the amount when formattedAmount is provided

What changes do you think we should make in order to solve the problem?

• Remove the getAmount() call from the Approve button text in MoneyReportHeader here and change it to

            text: translate('iou.approve'),

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA .. just a ui button change

What alternative solutions did you explore? (Optional)

NA

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Approve Button in Secondary Actions Menu Incorrectly Displays Amount

What is the root cause of that problem?

We get amount here for approve button

App/src/components/MoneyReportHeader.tsx

Lines 581 to 583 in 9ada65e

	const getAmount = (actionType: ValueOf<typeof CONST.REPORT.REPORT_PREVIEW_ACTIONS>) => ({
	formattedAmount: getTotalAmountForIOUReportPreviewButton(moneyRequestReport, policy, actionType),
	});

What changes do you think we should make in order to solve the problem?

We should check to not return amount for approve button in secondary actions menu (If we only need to apply it for duplicated transactions, we can add this condition as well hasDuplicateTransactions(report?.reportID))

    if (reportPreviewAction === CONST.REPORT.REPORT_PREVIEW_ACTIONS.APPROVE) {
         return '';
    }

App/src/libs/MoneyRequestReportUtils.ts

Line 152 in 49ebfc1

Or

We should update for APPROVE actions on reports with duplicate expenses (Similar if we want to apply to all cases not just duplicated expenses, can remove this condition hasDuplicates), don't show an amount

    const getAmount = (actionType: ValueOf<typeof CONST.REPORT.REPORT_PREVIEW_ACTIONS>) => {
        if (actionType === CONST.REPORT.REPORT_PREVIEW_ACTIONS.APPROVE && hasDuplicates) {
            return {formattedAmount: ''};
        }
        return {formattedAmount: getTotalAmountForIOUReportPreviewButton(moneyRequestReport, policy, actionType)};
    };

App/src/components/MoneyReportHeader.tsx

Lines 581 to 583 in 9ada65e

	const getAmount = (actionType: ValueOf<typeof CONST.REPORT.REPORT_PREVIEW_ACTIONS>) => ({
	formattedAmount: getTotalAmountForIOUReportPreviewButton(moneyRequestReport, policy, actionType),
	});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mukhrr]

But this is not intended behavior?! #61926

[dannymcclain]

But this is not intended behavior?! #61926

We recently updated the buttons displayed on the preview to not include amounts because it can create a lot of confusion when reports have a mix of held and unheld expenses. When we made that change, I think we just missed updating these secondary action menu items.

[ganzz4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Approve button in the secondary action menu (more actions menu) displays "Approve [amount]" instead of just "Approve". This creates confusion when reports have a mix of held and unheld expenses, as the amount shown may not represent the full context of what's being approved.

What is the root cause of that problem?

The root cause is that the Approve button text is being generated with amount formatting in multiple places throughout the codebase:

1. The iou.approve translation function in src/languages/en.ts and other language files automatically appends the amount when formattedAmount is provided
2. Several components directly pass formattedAmount parameters to the translation function
3. Some components manually concatenate amounts to the approve text

What changes do you think we should make in order to solve the problem?

As noted in this comment, we need to update all locations where the Approve button text includes amounts to show only "Approve" without any monetary values:

Components:

text: translate('iou.approve'),

App/src/components/MoneyReportHeader.tsx

Line 968 in 3938e13

text: translate('iou.approve', getAmount(CONST.REPORT.SECONDARY_ACTIONS.APPROVE)),

text: translate('iou.approve'),

App/src/hooks/usePaymentOptions.ts

Line 123 in 3938e13

text: translate('iou.approve', {formattedAmount}),

text: translate('iou.approve'),

App/src/components/SettlementButton/index.tsx

Line 197 in 3938e13

text: translate('iou.approve', {formattedAmount}),

secondOptionText={isApprove ? translate('iou.approve') : `${translate('iou.pay')} ${fullAmount}`}

App/src/components/ProcessMoneyReportHoldMenu.tsx

Line 99 in 3938e13

secondOptionText={`${translate(isApprove ? 'iou.approve' : 'iou.pay')} ${fullAmount}`}

Translation files:

approve: () => 'Approve',

App/src/languages/en.ts

Line 1057 in 3938e13

approve: ({formattedAmount}: {formattedAmount?: string} = {}) => (formattedAmount ? `Approve ${formattedAmount}` : 'Approve'),

approve: () => 'Aprobar',

App/src/languages/es.ts

Line 1050 in 3938e13

approve: ({formattedAmount}: {formattedAmount?: string} = {}) => (formattedAmount ? `Aprobar ${formattedAmount}` : 'Aprobar'),

approve: () => 'Zatwierdź',

App/src/languages/pl.ts

Lines 1062 to 1066 in 3938e13

	approve: ({
	formattedAmount,
	}: {
	formattedAmount?: string;
	} = {}) => (formattedAmount ? `Zatwierdź ${formattedAmount}` : 'Zatwierdź'),

approve: () => '批准',

App/src/languages/zh-hans.ts

Lines 1056 to 1060 in 3938e13

	approve: ({
	formattedAmount,
	}: {
	formattedAmount?: string;
	} = {}) => (formattedAmount ? `批准 ${formattedAmount}` : '批准'),

Note: The files listed above represent the main affected locations. Additional language files (fr.ts, it.ts, nl.ts, ja.ts, etc.) should be reviewed to ensure complete consistency across the application.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A, UI issue

What alternative solutions did you explore? (Optional)

[melvin-bot]

@flaviadefaria Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021968406260555459573