[Due for payment 2025-11-04] [$250] Workspace Order Briefly Changes or flickers

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.14-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @linhvovan29546
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Navigate to Workspaces
2. Select any workspace
3. Click the back arrow to navigate back to "Workspaces"

Expected Result:

The order of the workspaces should remain consistent , no flickering and not change.

Actual Result:

The order of the workspaces changes briefly.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2025-09-16.at.16.09.33.mov

Recording.1656.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021971256843889554346
• Upwork Job ID: 1971256843889554346
• Last Price Increase: 2025-09-25
• Automatic offers:
• daledah | Contributor | 109026069

Issue Owner

Current Issue Owner: @johncschuster

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace Order Briefly Changes or flickers

What is the root cause of that problem?

We dont sort initial data, so we get a flick

App/src/hooks/useSearchResults.ts

Line 22 in 9147092

const [result, setResult] = useState(() => (shouldSortInitialData ? sortData(data) : data));

App/src/pages/workspace/WorkspacesListPage.tsx

Line 441 in 9147092

const [inputValue, setInputValue, filteredWorkspaces] = useSearchResults(workspaces, filterWorkspace, sortWorkspace);

What changes do you think we should make in order to solve the problem?

We should pass shouldSortInitialData as true to useSearchResults

const [inputValue, setInputValue, filteredWorkspaces] = useSearchResults(workspaces, filterWorkspace, sortWorkspace, true);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The order of the workspaces changes briefly.

What is the root cause of that problem?

We added the shouldSortInitialData in this PR to fix in company cards page

In WorkspacesListPage we don't pass shouldSortInitialData as true

App/src/hooks/useSearchResults.ts

Line 22 in 9147092

const [result, setResult] = useState(() => (shouldSortInitialData ? sortData(data) : data));

App/src/pages/workspace/WorkspacesListPage.tsx

Line 441 in 9147092

const [inputValue, setInputValue, filteredWorkspaces] = useSearchResults(workspaces, filterWorkspace, sortWorkspace);

What changes do you think we should make in order to solve the problem?

We should set the default value of shouldSortInitialData prop to true to prevent this problem with other pages as well

function useSearchResults<TValue extends ListItem>(
    ... 
    /**
     * Whether to sort data immediately on mount to prevent briefly displaying unsorted data,
     * since sorting is handled inside startTransition.
     */
    shouldSortInitialData = true,
)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@johncschuster 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021971256843889554346