[Due for payment 2025-10-15] [$250] Company cards - Downgrade workspace RHP appears briefly when navigating to Company cards

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.15-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-825/folder/13176706/41236840/899329345
Email or phone of affected tester (no customers): sdjoinsjidosjois@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Company cards.
3. Add two card feeds
4. Click Add Card > United States > Commerical feed > click on one of the options > enter random numbers (ex. '1'), Next > Submit.
5. Click on the card feed > click Add Card to add the second feed.
6. Go to Overview > Plan type.
7. Click Collect.
8. Click Downgrade workspace.
9. Click "keep only one card feed" link.

BUG 1: Company card page is blanked out briefly.

12. Click on one of the feeds > Settings > Remove card feed
13. Go to Overview > Plan type.
14. Click Collect.
15. Click Save.
16. Click Downgrade workspace.
17. Click Got it, thanks.
18. Go to Company cards.

BUG 2: Downgrade workspace RHP appears briefly when navigating to Company cards.

Expected Result:

BUG 1: Company card page will not blank out after clicking "keep only one card feed" link.
BUG 2: Downgrade workspace RHP will not appear when navigating to Company cards.

Actual Result:

BUG 1: Company card page is blanked out briefly after clicking "keep only one card feed" link.
BUG 2: Downgrade workspace RHP appears briefly when navigating to Company cards.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6946795_1758093224227.Screen_Recording_2025-09-17_at_15.05.15.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021968437489418238158
• Upwork Job ID: 1968437489418238158
• Last Price Increase: 2025-09-17
• Automatic offers:
• nkdengineer | Contributor | 108899009

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

BUG 1: Company card page is blanked out briefly after clicking "keep only one card feed" link.
BUG 2: Downgrade workspace RHP appears briefly when navigating to Company cards.

What is the root cause of that problem?

We are calling navigate twice in a row here

App/src/pages/workspace/downgrade/WorkspaceDowngradePage.tsx

Lines 57 to 64 in f14fa0c

	const onMoveToCompanyCardFeeds = () => {
	if (!policyID) {
	return;
	}
	setIsDowngradeWarningModalOpen(false);
	Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS.getRoute(policyID));
	Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS_SELECT_FEED.getRoute(policyID));
	};

What changes do you think we should make in order to solve the problem?

1. For BUG 1: Company card page is blanked out briefly after clicking "keep only one card feed" link. I don't think it's a black screen but it's a loading screen when we are loading data

2. For BUG 2: Downgrade workspace RHP appears briefly when navigating to Company cards.

We are calling navigate twice in a row and do not dismiss the downgrade modal but instead open another modal on top when navigating to the route WORKSPACE_COMPANY_CARDS_SELECT_FEED so we should call dismissModal first

    const onMoveToCompanyCardFeeds = () => {
        if (!policyID) {
            return;
        }
        setIsDowngradeWarningModalOpen(false);
        Navigation.dismissModal(); // or we can use `goBack` here
        Navigation.isNavigationReady().then(() => { // we can use `runAfterInteractions` here
            Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS.getRoute(policyID)); // we can add the delay here by using `isNavigationReady` or `runAfterInteractions`
            Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS_SELECT_FEED.getRoute(policyID));
         });
    };

App/src/pages/workspace/downgrade/WorkspaceDowngradePage.tsx

Lines 57 to 64 in f14fa0c

	const onMoveToCompanyCardFeeds = () => {
	if (!policyID) {
	return;
	}
	setIsDowngradeWarningModalOpen(false);
	Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS.getRoute(policyID));
	Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS_SELECT_FEED.getRoute(policyID));
	};

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[Christinadobrzyn]

I can reproduce both of these with the steps in the OP - adding external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021968437489418238158

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[Christinadobrzyn]

@ishpaul777, can you please review the above proposal when you have a moment? TY!