[Due for payment 2025-11-03] [$250] Reports - Footer on "Reports", is briefly shown when submitting, approving or paying report.

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.15-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-828/folder/13176923/41237527/899332482
Email or phone of affected tester (no customers): ibellicotest+1811@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 11 / Chrome
App Component: Search

Action Performed:

Prerequisite: Account has at least one workspace.
Prerequisite 2: Delayed submissions and approvals enabled.

1. Open the Expensify app.
2. Open any workspace chat.
3. Create at least two manual expenses.
4. Navigate to "Reports" > "Reports"
5. Note that no footer is displayed on section.
6. Open the report of the just created expenses.
7. Tap on "Submit"
8. Return to "Reports"
9. Note that footer with "Expenses" and "Total Spend" fields, appears and disappears.
10. Reopen report and tap on "Approve"
11. Return to "Reports"
12. Note that footer appears and disappears again.

Expected Result:

Footer on "Reports" section should not be briefly displayed when an expense is submitted, approved or paid via report.

Actual Result:

After submitting, approving or paying an expense via report, and returning to "Reports" section, footer with expenses information, appears and disappears.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6946736_1758086858634.Footer.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021970237779916738167
• Upwork Job ID: 1970237779916738167
• Last Price Increase: 2025-09-22

Issue Owner

Current Issue Owner: @trjExpensify / @stephanieelliott

Issue Owner

Current Issue Owner: @trjExpensify / @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Total footer shown briefly after submit, approve, or pay report.

What is the root cause of that problem?

When we submit, approve, or pay, we trigger the search API and pass the shouldCalculateTotals as true.

App/src/components/MoneyReportHeader.tsx

Lines 417 to 420 in 24fe08c

	if (currentSearchQueryJSON) {
	search({
	searchKey: currentSearchKey,
	shouldCalculateTotals: true,

When we go back, another search API is triggered with shouldCalculateTotals as false, as decided here.

App/src/components/Search/index.tsx

Lines 269 to 303 in 24fe08c

	const shouldCalculateTotals = useMemo(() => {
	if (offset !== 0) {
	return false;
	}
	const savedSearchValues = Object.values(savedSearches ?? {});
	if (!savedSearchValues.length && !searchKey) {
	return false;
	}
	const eligibleSearchKeys: Partial<SearchKey[]> = [
	CONST.SEARCH.SEARCH_KEYS.SUBMIT,
	CONST.SEARCH.SEARCH_KEYS.APPROVE,
	CONST.SEARCH.SEARCH_KEYS.PAY,
	CONST.SEARCH.SEARCH_KEYS.EXPORT,
	CONST.SEARCH.SEARCH_KEYS.STATEMENTS,
	CONST.SEARCH.SEARCH_KEYS.UNAPPROVED_CASH,
	CONST.SEARCH.SEARCH_KEYS.UNAPPROVED_CARD,
	CONST.SEARCH.SEARCH_KEYS.RECONCILIATION,
	];
	if (eligibleSearchKeys.includes(searchKey)) {
	return true;
	}
	for (const savedSearch of savedSearchValues) {
	const searchData = buildSearchQueryJSON(savedSearch.query);
	if (searchData && searchData.similarSearchHash === similarSearchHash) {
	return true;
	}
	}
	return false;
	}, [offset, savedSearches, searchKey, similarSearchHash]);

What changes do you think we should make in order to solve the problem?

We need to use the same shouldCalculateTotals from Search/index component in MoneyReportHeader. To make it DRY, we can either create a util or a hook (useSearchShouldCalculateTotals). Every data can be get from the SearchContext, except the offset.

App/src/components/Search/index.tsx

Lines 269 to 272 in 24fe08c

	const shouldCalculateTotals = useMemo(() => {
	if (offset !== 0) {
	return false;
	}

To fix that, we can move the offset state to the SearchContext and name it currentOffset.

App/src/components/Search/index.tsx

Line 242 in 24fe08c

const [offset, setOffset] = useState(0);

We can reset the offset here.

App/src/components/Search/index.tsx

Lines 316 to 329 in 24fe08c

	const clearTransactionsAndSetHashAndKey = useCallback(() => {
	clearSelectedTransactions(hash);
	setCurrentSearchHashAndKey(hash, searchKey);
	setCurrentSearchQueryJSON(queryJSON);
	}, [hash, searchKey, clearSelectedTransactions, setCurrentSearchHashAndKey, setCurrentSearchQueryJSON, queryJSON]);
	useFocusEffect(clearTransactionsAndSetHashAndKey);
	useEffect(() => {
	clearTransactionsAndSetHashAndKey();
	// Trigger once on mount (e.g., on page reload), when RHP is open and screen is not focused
	// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
	}, []);

But I don't think making the offset global is a good idea. Maybe we can check the offset only in Search/index file. Let me know which one is preferable.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021970237779916738167

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)