[Due for payment 2025-10-31] [$250] Mentions - User's name is not displayed in mention, when user was selected from suggestion list

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.15-12
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/folder/13176681/test-cases/41236999
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacBook Air 15.6.1 Chrome, iPhone 15 iOS 18.5 Safari
App Component: Chat Report View

Action Performed:

Preconditions: User gmail accounts. Main User has chats with other accounts, that have names set up, there is a suggestion list of users when typing @ in the chat

1. Sign in to ND
2. Open any chat, type @ and enter an email of the other user, who has a name set up, but you did not interact before
3. Enter the mention - it is displayed as "@[User's name]"
4. Type @, select any other user with the name from the suggestion list
5. Enter the mention - it appears as "@[User's email]", user's name is not displayed in the mention

Expected Result:

User's name is displayed in the mention, if it is set up

Actual Result:

User's name is not displayed in the mention, when the user was selected from the suggestion list. Mention appears as email address

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021975129125311185232
• Upwork Job ID: 1975129125311185232
• Last Price Increase: 2025-10-06
• Automatic offers:
• nkdengineer | Contributor | 109068848

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The issue is that when users select a mention from the suggestion list in Expensify Chat, the mention displays the user's email address instead of their display name, even when a display name is set up.

What is the root cause of that problem?

The root cause is in the getMentionCode function located in src/pages/home/report/ReportActionCompose/SuggestionMention.tsx at line 166.

The function was incorrectly using mention.handle (which contains the user's email address) as both parameters when calling formatLoginPrivateDomain():

App/src/pages/home/report/ReportActionCompose/SuggestionMention.tsx

Line 166 in ad6baec

return mention.text === CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT ? CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT : `@${formatLoginPrivateDomain(mention.handle, mention.handle)}`;

This caused the function to process the email address instead of the display name. The mention object structure contains:

• mention.text: The display name (e.g., "John Doe")
• mention.handle: The email address (e.g., "john.doe@company.com")

When formatLoginPrivateDomain(mention.handle, mention.handle) was called, it would return the email or username part instead of the display name, resulting in mentions showing email addresses rather than user names.

What changes do you think we should make in order to solve the problem?

The fix is to modify the getMentionCode function to use mention.text (the display name) as the first parameter instead of mention.handle (the email address):

return mention.text === CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT ? CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT : `@${formatLoginPrivateDomain(mention.text, mention.handle)}`;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Unit Tests for getMentionCode function:

• Test that mentions selected from suggestion list display user names instead of email addresses
• Test that mentions with display names are formatted correctly
• Test that mentions without display names fall back to email addresses appropriately
• Test that "here" mentions are handled correctly

Integration Tests for mention selection flow:

• Test the complete flow from typing "@" to selecting a user from the suggestion list
• Verify that the selected mention displays the correct user name in the chat input
• Test with users from the same domain vs different domains
• Test with users who have display names vs users who only have email addresses

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User's name is not displayed in the mention, when the user was selected from the suggestion list. Mention appears as email address

What is the root cause of that problem?

We prioritize the email instead of the display name

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.tsx

Line 61 in 5aef19b

mentionDisplayText = Str.removeSMSDomain(mentionDisplayText);

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.tsx

Line 46 in 5aef19b

mentionDisplayText = formatPhoneNumber(user?.login ?? '') || getDisplayNameOrDefault(user);

What changes do you think we should make in order to solve the problem?

We should prioritize the display name first

mentionDisplayText = getDisplayNameOrDefault(user) || formatPhoneNumber(user?.login ?? '');

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.tsx

Line 46 in 5aef19b

mentionDisplayText = formatPhoneNumber(user?.login ?? '') || getDisplayNameOrDefault(user);

if (accountID !== -1) {
    const user = personalDetails?.[accountID];
    mentionDisplayText = getDisplayNameOrDefault(user) || formatPhoneNumber(user?.login ?? '');
    mentionDisplayText = getShortMentionIfFound(mentionDisplayText, htmlAttributeAccountID, currentUserPersonalDetails, user?.login ?? '') ?? '';
} else {
    mentionDisplayText = Str.removeSMSDomain(mentionDisplayText);
}
navigationRoute = ROUTES.PROFILE.getRoute(accountID, Navigation.getReportRHPActiveRoute(), mentionDisplayText);

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.tsx

Line 61 in 5aef19b

mentionDisplayText = Str.removeSMSDomain(mentionDisplayText);

{(accountID && accountID !== -1) ? `@${mentionDisplayText}` : <TNodeChildrenRenderer tnode={tnodeClone ?? tnode} />}

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.tsx

Line 117 in 5aef19b

{htmlAttribAccountID ? `@${mentionDisplayText}` : <TNodeChildrenRenderer tnode={tnodeClone ?? tnode} />}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[strepanier03]

@dylanexpensify - I am heading out of the office this afternoon and have a super full K2 to get through on top of travel stuff. I won't get through this one today so I'm pre-emptively reassigning.

[dylanexpensify]

Sounds good!! Have a great ooo time!

…

On Fri, 19 Sep 2025 at 20:58, Sheena Trepanier ***@***.***> wrote: *strepanier03* left a comment (Expensify/App#70893) <#70893 (comment)> @dylanexpensify <https://github.com/dylanexpensify> - I am heading out of the office this afternoon and have a super full K2 to get through on top of travel stuff. I won't get through this one today so I'm pre-emptively reassigning. — Reply to this email directly, view it on GitHub <#70893 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOKVCABEHND5EGEIVMHE7TL3TRG47AVCNFSM6AAAAACG7YFDNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMJTGQZDSOBQG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[melvin-bot]

@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!