[Due for payment 2025-11-11] [$250] Expense - In self dm, app crashes on merging distance expense in offline

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.2.16-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/a
Email or phone of affected tester (no customers): Slottwo1 galefish@gmail.com
Issue reported by: Applause Internal Team
Device used: Samsung galaxy m21 android 12
App Component: Money Requests

Action Performed:

1. Launch app
2. Open workpace chat
3. Tap plus icon - create expense - distance
4. Select 2 waypoints
5. Go offline
6. Create distance expense
7. Go to self dm
8. Create a track expense (click on plus icon > Expense > create an Expense and select 'do nothing' as the option to track it
9. Open the expense
10. Tap more - merge - select distance expense in step 6
11. Tap continue
12. Select any details and tap continue

Expected Result:

In self dm, app must not crash on merging distance expense in offline.

Actual Result:

In self dm, app crashes on merging distance expense in offline.

Note:
In mweb, there is infinite loading when trying to reproduce this issue

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6951272_1758444734703.az_recorder_20250921_135231.mp4

Bug6951272_1758444832455!Crash.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021970178191135494833
• Upwork Job ID: 1970178191135494833
• Last Price Increase: 2025-09-29
• Automatic offers:
• QichenZhu | Reviewer | 108945947
• nkdengineer | Contributor | 108945950

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abzokhattab]

🚨 Edited by proposal-police: This proposal was edited at 2025-09-24 09:36:01 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - In self dm, app crashes on merging distance expense in offline

What is the root cause of that problem?

• When importing image assets on native platforms, Metro bundler assigns numeric IDs (like 492) to represent the asset in the compiled bundle
• The codebase already points out to this at tryResolveUrlFromApiRoot with proper type checking
• The source field is typed as string but receives numeric values
• The getReceiptFileName function only handles string sources and fails when encountering numeric values

What changes do you think we should make in order to solve the problem?

• Update getReceiptFileName function to handle numeric receipt.source values by falling back to receipt.filename

function getReceiptFileName(receipt?: Receipt) {
    if (receipt?.source && typeof receipt.source === 'number') {
        return receipt.filename ?? receipt?.source ??'';   // or any other fallback value depending on the expected behaviour here
    }

    return receipt?.source?.split('/').pop() ?? '';
}

• See if the issue occurs in other places and fix it. potentially the getFileName

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add test cases for covering the prev scenarios for the getReceiptFileName inside the MergeTransactionUtilsTest and FileUtilsTest

What alternative solutions did you explore? (Optional)

NA

[lorretheboy]

Looks like BE returns wrong data type

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In self dm, app crashes on merging distance expense in offline.

What is the root cause of that problem?

The app crashes because the source type is number and we're trying to get the receipt file name with receipt?.source?.split('/')?.pop()

App/src/libs/MergeTransactionUtils.ts

Line 295 in 154efef

filename: getReceiptFileName(mergeTransaction.receipt),

App/src/pages/TransactionMerge/ConfirmationPage.tsx

Line 51 in 154efef

const mergedTransactionData = useMemo(() => buildMergedTransactionData(targetTransaction, mergeTransaction), [targetTransaction, mergeTransaction]);

App/src/libs/MergeTransactionUtils.ts

Lines 49 to 52 in 154efef

	function getReceiptFileName(receipt?: Receipt) {
	return receipt?.source?.split('/')?.pop();
	}

The question here is why the source type is a number. When we create the distance request offline, the optimistic source receipt is a static image. On native, the static image has type number. That is why the bug is only reproducible with the distance expense in offline.

App/src/libs/actions/IOU.ts

Lines 7597 to 7599 in 154efef

	const optimisticReceipt: Receipt = {
	source: ReceiptGeneric as ReceiptSource,
	state: CONST.IOU.RECEIPT_STATE.OPEN,

What changes do you think we should make in order to solve the problem?

We can return filename/source/empty string if the receipt?.source is not a string.

if (typeof receipt?.source === 'string') {
    return receipt?.source?.split('/')?.pop();
}
return `${receipt?.filename ?? receipt?.source}`;

App/src/libs/MergeTransactionUtils.ts

Lines 49 to 52 in 154efef

	function getReceiptFileName(receipt?: Receipt) {
	return receipt?.source?.split('/')?.pop();
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add getReceiptFileName unit test to verify the correct filename is returned in the case the source is not a string.

What alternative solutions did you explore? (Optional)

Update the ReceiptSource type and fix all related type errors to prevent this from going back again

type ReceiptSource = string | number;

App/src/types/onyx/Transaction.ts

Line 164 in f4b107e

type ReceiptSource = string;

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[Christinadobrzyn]

I can reproduce this, let's start external first.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021970178191135494833

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (External)