[Due for payment 2025-11-06] [$250] Wallet - Blank popup on selecting Transfer balance option when BA has Business bank account

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.19-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory
Email or phone of affected tester (no customers): kiatest.78+ck92725@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/Chrome
App Component: User Settings

Action Performed:

Precondition: User logged in with gmail account & has created new workspace

1. Navigate to staging.new.expensify.com
2. Navigate to WS settings >> Workflows >> Make & track payments
3. Add VBA (Regions bank) going through plaid flow
4. Navigate to Accounts >> Wallet >> click Enable wallet
5. Go through the enable wallet flow
6. Tap on Transfer balance option
7. Observe blank popup displayed

Expected Result:

Transfer balance page RHP (or if popup appears, it should display relevant info) should be displayed when wallet has added business bank account

Actual Result:

Blank popup on selecting Transfer balance option when BA has only Business bank account. Issue happens when wallet has only business bank account

Note: If bank account has both Personal BA & Business BA, transfer balance RHP opens as expected on selecting transfer balance option.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6958169_1759029116764.27.09.2025_13.18.46_REC51.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021972730652326576464
• Upwork Job ID: 1972730652326576464
• Last Price Increase: 2025-10-13
• Automatic offers:
• gijoe0295 | Contributor | 109146761

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The issue occurs when a user has only a business bank account connected to their wallet. When they tap "Transfer balance", they see a blank popup instead of the expected transfer balance page

What is the root cause of that problem?

The problem is in the hasExpensifyPaymentMethod function. The function only checked for CONST.BANK_ACCOUNT.TYPE.PERSONAL bank accounts. It ignored CONST.BANK_ACCOUNT.TYPE.BUSINESS bank accounts.

App/src/libs/PaymentUtils.ts

Line 31 in 94132fc

function hasExpensifyPaymentMethod(fundList: Record<string, Fund>, bankAccountList: Record<string, BankAccount>, shouldIncludeDebitCard = true): boolean {

So that when only business bank accounts were present, hasExpensifyPaymentMethod returned false
This caused shouldShowTransferView to be false in TransferBalancePage

App/src/pages/settings/Wallet/TransferBalancePage.tsx

Line 146 in 8e3482b

const shouldShowTransferView = hasExpensifyPaymentMethod(paymentCardList, bankAccountList ?? {}) && TRANSFER_TIER_NAMES.includes(userWallet?.tierName ?? '');

The page showed empty page instead of the transfer balance content

What changes do you think we should make in order to solve the problem?

Update to include BUSINESS account check as well

            (bankAccount.getType() === CONST.BANK_ACCOUNT.TYPE.PERSONAL || bankAccount.getType() === CONST.BANK_ACCOUNT.TYPE.BUSINESS) &&

App/src/libs/PaymentUtils.ts

Line 38 in 94132fc

bankAccount.getType() === CONST.BANK_ACCOUNT.TYPE.PERSONAL &&

Also need to update type here and all other type missing places

App/src/types/onyx/BankAccount.ts

Line 46 in a5f0694

accountType?: typeof CONST.PAYMENT_METHODS.PERSONAL_BANK_ACCOUNT;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update PaymentUtilsTest to test the business case in hasExpensifyPaymentMethod

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Blank popup on selecting Transfer balance option when BA has Business bank account

What is the root cause of that problem?

BaseKYCWall checks if you had a valid personal bank account by hasExpensifyPaymentMethod here to display the add payment method menu if you don't. But since the linked account is a business one, the AddPaymentMethodMenu shows nothing because all the conditions here fails.

However the problem here is not about the AddPaymentMethodMenu shows nothing but that the add bank account step in enable wallet flow is mistakenly skipped because it incorrectly assumes that user already has a valid personal bank account even though he only has a business account.

App/src/pages/EnablePayments/EnablePayments.tsx

Line 56 in b624dc2

const currentStep = isEmptyObject(bankAccountList) ? CONST.WALLET.STEP.ADD_BANK_ACCOUNT : userWallet?.currentStep || CONST.WALLET.STEP.ADDITIONAL_DETAILS;

Taking a look at the condition to render initial step in EnablePaymentsPage above, we incorrectly assume that if bankAccountList is not empty, the initial step will be ADDITIONAL_DETAILS (personal info step) => the add bank account step is skipped. But bankAccountList can have accounts of either BUSINESS or PERSONAL type. To enable the wallet, we must have a PERSONAL one. If you only have a business bank account, you still need to go through the add bank account step in enable wallet flow.

What changes do you think we should make in order to solve the problem?

App/src/pages/EnablePayments/EnablePayments.tsx

Line 56 in b624dc2

const currentStep = isEmptyObject(bankAccountList) ? CONST.WALLET.STEP.ADD_BANK_ACCOUNT : userWallet?.currentStep || CONST.WALLET.STEP.ADDITIONAL_DETAILS;

Modify this condition to check if user actually has a valid personal bank account using hasExpensifyPaymentMethod.

So it would become:

const hasActivatedWallet = ([CONST.WALLET.TIER_NAME.GOLD, CONST.WALLET.TIER_NAME.PLATINUM]).includes(userWallet.tierName);
const enablePaymentsStep = !hasExpensifyPaymentMethod(paymentCardList, bankAccountList, hasActivatedWallet) ? CONST.WALLET.STEP.ADD_BANK_ACCOUNT : userWallet?.currentStep || CONST.WALLET.STEP.ADDITIONAL_DETAILS;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Wallet › Transfer balance entry point renders a blank right-hand panel on web when a workspace has enabled the business wallet flow but the user only linked a business bank account. Transfer should still be possible for business-only wallets, so the RN/web page must render their balance and payout options instead of blocking them behind an empty KYC wall.

What is the root cause of that problem?

The helper that decides whether a user has an eligible payout method, hasExpensifyPaymentMethod, only treated personal bank accounts as valid

App/src/libs/PaymentUtils.ts

Lines 29 to 41 in b315370

	* Check to see if user has either a debit card or personal US bank account added that can be used with a wallet.
	*/
	function hasExpensifyPaymentMethod(fundList: Record<string, Fund>, bankAccountList: Record<string, BankAccount>, shouldIncludeDebitCard = true): boolean {
	const validBankAccount = Object.values(bankAccountList).some((bankAccountJSON) => {
	const bankAccount = new BankAccountModel(bankAccountJSON);
	return (
	bankAccount.getPendingAction() !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
	bankAccount.isOpen() &&
	bankAccount.getType() === CONST.BANK_ACCOUNT.TYPE.PERSONAL &&
	bankAccount?.getCountry() === CONST.COUNTRY.US
	);
	});

Because the KYC wall’s transfer-balance gate reuses that helper, it still rejected business-only customers even after the wallet had been upgraded

App/src/components/KYCWall/BaseKYCWall.tsx

Lines 193 to 225 in b315370

	// Check to see if user has a valid payment method on file and display the add payment popover if they don't
	if (
	(isExpenseReport && reimbursementAccount?.achData?.state !== CONST.BANK_ACCOUNT.STATE.OPEN) ||
	(!isExpenseReport && bankAccountList !== null && !hasExpensifyPaymentMethod(paymentCardList, bankAccountList, shouldIncludeDebitCard))
	) {
	Log.info('[KYC Wallet] User does not have valid payment method');
	if (!shouldIncludeDebitCard) {
	selectPaymentMethod(CONST.PAYMENT_METHODS.PERSONAL_BANK_ACCOUNT);
	return;
	}
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	if (paymentMethod || policy) {
	setShouldShowAddPaymentMenu(false);
	selectPaymentMethod(paymentMethod, policy);
	return;
	}
	if (iouPaymentType && isExpenseReport) {
	setShouldShowAddPaymentMenu(false);
	selectPaymentMethod(CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT);
	return;
	}
	const clickedElementLocation = getClickedTargetLocation(targetElement as HTMLDivElement);
	const position = getAnchorPosition(clickedElementLocation);
	setPositionAddPaymentMenu(position);
	setShouldShowAddPaymentMenu(true);
	return;
	}

As a result, both the Wallet page and the stand-alone transfer view bailed out early, leaving users with an empty screen.

What changes do you think we should make in order to solve the problem?

We can allow consumers of the helper method hasExpensifyPaymentMethod to opt into business-bank-account eligibility when they explicitly need to support that flow and pass the new flag from the transfer UI and its KYC gate.

// src/libs/PaymentUtils.ts
function hasExpensifyPaymentMethod(
    fundList: Record<string, Fund>,
    bankAccountList: Record<string, BankAccount>,
    shouldIncludeDebitCard = true,
    shouldIncludeBusinessBankAccount = false,
): boolean {
    const validBankAccount = Object.values(bankAccountList).some((bankAccountJSON) => {
        const bankAccount = new BankAccountModel(bankAccountJSON);

        const isSupportedType =
            bankAccount.getType() === CONST.BANK_ACCOUNT.TYPE.PERSONAL ||
            (shouldIncludeBusinessBankAccount && bankAccount.getType() === CONST.BANK_ACCOUNT.TYPE.BUSINESS);

        return (
            bankAccount.getPendingAction() !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
            bankAccount.isOpen() &&
            isSupportedType &&
            bankAccount?.getCountry() === CONST.COUNTRY.US
        );
    });

    const validDebitCard = Object.values(fundList).some((card) => card?.accountData?.additionalData?.isP2PDebitCard ?? false);

    return validBankAccount || (shouldIncludeDebitCard && validDebitCard);
}

// src/pages/settings/Wallet/TransferBalancePage.tsx
const shouldShowTransferView =
    hasExpensifyPaymentMethod(paymentCardList, bankAccountList ?? {}, true, true) && TRANSFER_TIER_NAMES.includes(userWallet?.tierName ?? '');

// src/components/KYCWall/BaseKYCWall.tsx
const shouldIncludeBusinessBankAccount = currentSource === CONST.KYC_WALL_SOURCE.TRANSFER_BALANCE;

if (
    (isExpenseReport && reimbursementAccount?.achData?.state !== CONST.BANK_ACCOUNT.STATE.OPEN) ||
    (!isExpenseReport &&
        bankAccountList !== null &&
        !hasExpensifyPaymentMethod(paymentCardList, bankAccountList, shouldIncludeDebitCard, shouldIncludeBusinessBankAccount))
) {
    Log.info('[KYC Wallet] User does not have valid payment method');
    ...
}

// src/types/onyx/BankAccount.ts
accountType?: typeof CONST.PAYMENT_METHODS.PERSONAL_BANK_ACCOUNT | typeof CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT;

Screen.Recording.2025-09-29.at.11.25.45.AM.mov

Together, these changes let the transfer flow short-circuit in favour of business banking whenever the source is the wallet transfer entry point while keeping existing behaviour intact for the other KYC wall use cases.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Unit test for hasExpensifyPaymentMethod that exercises personal-only, debit-only, and business-only input combinations when the business flag is on or off.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021972730652326576464

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)