[Due for payment 2025-11-26] [$250] Multi scan - Transaction details appear twice and broken after deleting one of the expenses

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.27-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1184/folder/13177049/49475610/940179685
Email or phone of affected tester (no customers): jsdoijnsojsonidjsij@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Open 1:1 DM.
3. Click + > Create expense > Scan.
4. Upload a photo.
5. On confirm page, click RHP back button.
6. Upload a photo.
7. On confirm page, click Create 2 expenses.
8. Open the expense report.
9. Open any expense row.
10. Click More > Delete.
11. After deleting the expense, scroll up the expense report.

Expected Result:

The expense report will not show the transaction details twice after deleting one of the expenses.

Actual Result:

The expense report shows the transaction details twice after deleting one of the expenses. The duplicate view also looks broken.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6968276_1759913872607.Screen_Recording_2025-10-08_at_16.52.19.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021977847568048893670
• Upwork Job ID: 1977847568048893670
• Last Price Increase: 2025-10-13

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When creating a scan request with 2 receipts and then deleting one of the transactions, there are 2 created actions shown.

What is the root cause of that problem?

When we create a request with multiple receipts, we call the requestMoney twice. We also pass the optimisticIOUReportID to the function, so that even though we call requestMoney multiple times, it will still use the same iouReportID.

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines 497 to 514 in 52e92f7

	const optimisticChatReportID = generateReportID();
	const optimisticCreatedReportActionID = rand64();
	const optimisticIOUReportID = generateReportID();
	const optimisticReportPreviewActionID = rand64();
	transactions.forEach((item, index) => {
	const receipt = receiptFiles[item.transactionID];
	const isTestReceipt = receipt?.isTestReceipt ?? false;
	const isTestDriveReceipt = receipt?.isTestDriveReceipt ?? false;
	const isLinkedTrackedExpenseReportArchived =
	!!item.linkedTrackedExpenseReportID && archivedReportsIdSet.has(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${item.linkedTrackedExpenseReportID}`);
	if (isTestDriveReceipt) {
	completeTestDriveTask(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived);
	}
	requestMoneyIOUActions({
	report,

App/src/libs/actions/IOU.ts

Lines 3442 to 3448 in 52e92f7

	const shouldCreateNewMoneyRequestReport = isSplitExpense ? false : shouldCreateNewMoneyRequestReportReportUtils(iouReport, chatReport, isScanRequest);
	if (!iouReport || shouldCreateNewMoneyRequestReport) {
	const nonReimbursableTotal = reimbursable ? 0 : amount;
	iouReport = isPolicyExpenseChat
	? buildOptimisticExpenseReport(chatReport.reportID, chatReport.policyID, payeeAccountID, amount, currency, nonReimbursableTotal, undefined, optimisticIOUReportID)
	: buildOptimisticIOUReport(payeeAccountID, payerAccountID, amount, chatReport.reportID, currency, undefined, undefined, optimisticIOUReportID);

However, this becomes a problem for the IOU report CREATED action because we currently create it twice with different reportActionID.

App/src/libs/ReportUtils.ts

Lines 8148 to 8152 in 52e92f7

	const createdActionForChat = buildOptimisticCreatedReportAction(payeeEmail, undefined, optimisticCreatedReportActionID);
	// The `CREATED` action must be optimistically generated before the IOU action so that it won't appear after the IOU action in the chat.
	const iouActionCreationTime = DateUtils.getDBTime();
	const createdActionForIOUReport = buildOptimisticCreatedReportAction(payeeEmail, DateUtils.subtractMillisecondsFromDateTime(iouActionCreationTime, 1));

Notice that we also pass the optimistic reportActionID for the chat report CREATED action, but we don't do the same for IOU report.

So, after deleting the 2nd transaction, the user now sees 2 CREATED actions on the report screen.

What changes do you think we should make in order to solve the problem?

We also need to generate the reportActionID for IOU report CREATED action and then pass it down to here.

App/src/libs/ReportUtils.ts

Line 8152 in 52e92f7

const createdActionForIOUReport = buildOptimisticCreatedReportAction(payeeEmail, DateUtils.subtractMillisecondsFromDateTime(iouActionCreationTime, 1));

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The expense report shows the transaction details twice after deleting one of the expenses. The duplicate view also looks broken.

What is the root cause of that problem?

1. When creating a new money request with multiple receipts, transactions.length > 1, so IOUs will be created consecutively at this point:
   

   App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

   Lines 502 to 513 in 6ea9c3f

   	transactions.forEach((item, index) => {
   	const receipt = receiptFiles[item.transactionID];
   	const isTestReceipt = receipt?.isTestReceipt ?? false;
   	const isTestDriveReceipt = receipt?.isTestDriveReceipt ?? false;
   	const isLinkedTrackedExpenseReportArchived =
   	!!item.linkedTrackedExpenseReportID && archivedReportsIdSet.has(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${item.linkedTrackedExpenseReportID}`);
   	if (isTestDriveReceipt) {
   	completeTestDriveTask(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived);
   	}
   	requestMoneyIOUActions({

2. Since iouReport and chatReport haven't actually been merged into the Onyx data yet, shouldCreateNewMoneyRequestReport will be set to true:
   

   App/src/libs/actions/IOU.ts

   Lines 3434 to 3442 in 6ea9c3f

   	let iouReport: OnyxInputValue<OnyxTypes.Report> = null;
   	if (moneyRequestReportID) {
   	iouReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${moneyRequestReportID}`] ?? null;
   	} else if (!allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${chatReport.iouReportID}`]?.errorFields?.createChat) {
   	iouReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${chatReport.iouReportID}`] ?? null;
   	}
   	const isScanRequest = isScanRequestTransactionUtils({amount, receipt});
   	const shouldCreateNewMoneyRequestReport = isSplitExpense ? false : shouldCreateNewMoneyRequestReportReportUtils(iouReport, chatReport, isScanRequest);

3. Because shouldCreateNewMoneyRequestReport === true, iou.createdAction will be merged:
   

   App/src/libs/actions/IOU.ts

   Lines 1614 to 1629 in 6ea9c3f

   	shouldCreateNewMoneyRequestReport
   	? {
   	onyxMethod: Onyx.METHOD.SET,
   	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${iou.report.reportID}`,
   	value: {
   	[iou.createdAction.reportActionID]: iou.createdAction as OnyxTypes.ReportAction,
   	[iou.action.reportActionID]: iou.action as OnyxTypes.ReportAction,
   	},
   	}
   	: {
   	onyxMethod: Onyx.METHOD.MERGE,
   	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${iou.report.reportID}`,
   	value: {
   	[iou.action.reportActionID]: iou.action as OnyxTypes.ReportAction,
   	},
   	},

What changes do you think we should make in order to solve the problem?

We should pass a parameter like shouldNotCreateNewMoneyRequestReport from requestMoneyIOUActions and forward it to getMoneyRequestInformation:

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 558 in 6ea9c3f

});

+   shouldNotCreateNewMoneyRequestReport: index > 0,
});

App/src/libs/actions/IOU.ts

Line 3442 in 6ea9c3f

const shouldCreateNewMoneyRequestReport = isSplitExpense ? false : shouldCreateNewMoneyRequestReportReportUtils(iouReport, chatReport, isScanRequest);

const shouldCreateNewMoneyRequestReport =
    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
    isSplitExpense || shouldNotCreateNewMoneyRequestReport ? false : shouldCreateNewMoneyRequestReportReportUtils(iouReport, chatReport, isScanRequest);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@RachCHopkins Huh... This is 4 days overdue. Who can take care of this?

[RachCHopkins]

Tested on native iOS app and these repro steps don't seem to apply

1. Go to staging.new.expensify.com
2. Open 1:1 DM.
3. Click + > Create expense > Scan.
4. Upload a photo.
5. On confirm page, click RHP back button. - I don't have a confirm page.
6. Upload a photo.
7. On confirm page, click Create 2 expenses. - I don't have a confirm page.
8. Open the expense report. - There is no expense report
9. Open any expense row.
10. Click More > Delete.
11. After deleting the expense, scroll up the expense report.

This is what I did:

1. Go to staging.new.expensify.com or native app with staging server enabled
2. Open 1:1 DM.
3. Click + > Create expense > Scan. Select multi scan option
4. Take/upload a receipt photo > Next arrow
5. On confirm page, click RHP back button.
6. Upload/take another receipt photo.
7. On confirm page, click Create 2 expenses.
8. Go back to the chat
9. Select "nothing for now" when asked what to do with expenses.
10. Open any expense.
11. Click More > Delete.
12. After deleting the expense, scroll up the chat.

It worked normally. I will try to repro on chome web instead.

[RachCHopkins]

Ok, repro steps seem to apply to the web app, but I don't get an expense report, and I still get a step where I'm prompted to submit to someone. I select "nothing for now" and then I get the usual chat, no report:

I have no idea how to repro what the OP has reported.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[ZhenjaHorbach]

Can reproduce
And there are no specific steps here
Easily reproduced by following the QA steps

And I can be a reviewer here following this!
@RachCHopkins
Could you assign me here, please?

2025-10-13.22.45.44.mov

[RachCHopkins]

@ZhenjaHorbach I've been trying to repro this for days. How have you managed to create a report in a self-DM? Or is it supposed to be a DM with another person?