[Due for payment 2025-11-17] [$250] [CFI] Delayed submit - Change Submit button to primary action and make available in the bulk select menu

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.27-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jliexpensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

Preconditions
Workspace is set to automated Delayed Submission frequency (e.g. weekly)

1. Create a report and add expenses to it
2. Resolve all errors and ensure receipts are added to all expenses in the report (i.e. it should be ready for submission, but not submitted)
3. Click on Report tab
4. Click on Submit
5. Select the checkbox next to the Report
6. Click on Selected
7. See that you cannot submit the Report from this drop-down

Expected Result:

We should be able to manually submit a Report by selecting it in the Reports tab, assuming the Report has no errors and has receipts on each expense.

Actual Result:

No option for Submit appears

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1739.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021976454933858004710
• Upwork Job ID: 1976454933858004710
• Last Price Increase: 2025-10-10
• Automatic offers:
• nkdengineer | Contributor | 109134873

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-10-10 18:56:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to bulk select Report in Reports tab and manually submit Report

What is the root cause of that problem?

• NEW FEAT

What changes do you think we should make in order to solve the problem?

We should the Submit option here

App/src/pages/Search/SearchPage.tsx

Lines 230 to 234 in 52e92f7

	const headerButtonsOptions = useMemo(() => {
	if (selectedTransactionsKeys.length === 0 || status == null || !hash) {
	return CONST.EMPTY_ARRAY as unknown as Array<DropdownOption<SearchHeaderOptionValue>>;
	}

const shouldShowSubmitOption =
    !isOffline &&
    (selectedReports.length
        ? selectedReports.every((report) => report.allActions.includes(CONST.SEARCH.ACTION_TYPES.SUBMIT))
        : selectedTransactionsKeys.every((id) => selectedTransactions[id].action === CONST.SEARCH.ACTION_TYPES.SUBMIT));

if (shouldShowSubmitOption) {
    options.push({
        icon: Expensicons.Send,
        text: translate('search.bulkActions.submit'),
        value: CONST.SEARCH.BULK_ACTION_TYPES.SUBMIT,
        shouldCloseModalOnSelect: true,
        onSelected: () => {
            if (isOffline) {
                setIsOfflineModalVisible(true);
                return;
            }

            const transactionIDList = selectedReports.length ? undefined : Object.keys(selectedTransactions);
            const reportIDList = !selectedReports.length
                ? Object.values(selectedTransactions).map((transaction) => transaction.reportID)
                : (selectedReports?.filter((report) => !!report).map((report) => report.reportID) ?? []);
            
            submitMoneyRequestOnSearch(hash, reportIDList, transactionIDList);
            InteractionManager.runAfterInteractions(() => {
                clearSelectedTransactions();
            });
        },
    });
}

We also need to include the Submit button in report header as primary action in MoneyRequestReportTransactionList and other places as mention here #72083 (comment)

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[trjExpensify]

Just a heads up on context from this thread...

• With this configuration (delayed submit set to daily+), we don't show the Submit button as it stands. In addition to the bulk select menu, we want to show the Submit button in these places too:

Search result

Report header as primary action button (instead of hidden in "More")

Report preview in workspace chat

@samranahm can you make sure your proposal accommodates that? Thanks!

[JmillsExpensify]

Yeah, coming from that Slack thread, I agree we should just always show the Submit button, no matter whether the report submission is automated or not.

[trjExpensify]

@samranahm any movement? We'd love to keep this moving today.

[trjExpensify]

Ah.. @nkdengineer too... #72085 (comment) - that other "bug report" isn't a bug, but we're advocating to change it here. CC: @luacmartins