[Due for payment 2025-11-18] [$250] Per diem - Search bar is missing from list of workspaces when creating per diem expense

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.30-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #71976
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome, Android 13/ Chrome
App Component: Money Requests

Action Performed:

Pre-condition:
Account has 15+workspaces with per diem enabled

Steps:

1. Sign in to staging.new.expensify.com with an account fulfils the pre-condition
2. Click on FAB > Create expense
3. Switch to Per diem tab

Expected Result:

List of workspaces created in pre-condition is displayed with search bar the top

Actual Result:

No search bar is displayed on top of the list of workspaces.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021979237162108284353
• Upwork Job ID: 1979237162108284353
• Last Price Increase: 2025-10-24

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No search bar is displayed on top of the list of workspaces.

What is the root cause of that problem?

We don't have search bar here

App/src/pages/iou/request/step/IOURequestStepPerDiemWorkspace.tsx

Lines 101 to 109 in a97165c

	<SelectionList
	key={selectedWorkspace?.policyID}
	data={workspaceOptions}
	onSelectRow={selectWorkspace}
	shouldSingleExecuteRowSelect
	ListItem={UserListItem}
	initiallyFocusedItemKey={selectedWorkspace?.policyID}
	/>
	</>

What changes do you think we should make in order to solve the problem?

We should pass props shouldShowTextInput and use the useSearchResults hook to handle search input like we did with other pages

    const filterWorkspace = useCallback((workspace: WorkspaceListItem, inputValue: string) => workspace.text?.toLowerCase().includes(inputValue) ?? false, []);
    const sortWorkspace = useCallback((workspaceItems: WorkspaceListItem[]) => workspaceItems, []);
    const [inputValue, setInputValue, filteredWorkspaces] = useSearchResults(workspaceOptions, filterWorkspace, sortWorkspace);

        textInputOptions={{
            value: searchTerm,
            label: translate('workspace.common.findWorkspace'),
            onChangeText: setSearchTerm,
        }}
        shouldShowTextInput={workspaceOptions.length > CONST.SEARCH_ITEM_LIMIT}

App/src/pages/iou/request/step/IOURequestStepPerDiemWorkspace.tsx

Lines 101 to 109 in a97165c

	<SelectionList
	key={selectedWorkspace?.policyID}
	data={workspaceOptions}
	onSelectRow={selectWorkspace}
	shouldSingleExecuteRowSelect
	ListItem={UserListItem}
	initiallyFocusedItemKey={selectedWorkspace?.policyID}
	/>
	</>

Optional: We can remove the header text here when we show the search input

App/src/pages/iou/request/step/IOURequestStepPerDiemWorkspace.tsx

Lines 98 to 100 in a97165c

	<View style={[styles.optionsListSectionHeader]}>
	<Text style={[styles.ph5, styles.textLabelSupporting]}>{translate('iou.chooseWorkspace')}</Text>
	</View>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Result:

Screen.Recording.2025-10-16.at.01.51.54.mov

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Per diem - Search bar is missing from list of workspaces when creating per diem expense

What is the root cause of that problem?

We don't support search feature in IOURequestStepPerDiemWorkspace

App/src/pages/iou/request/step/IOURequestStepPerDiemWorkspace.tsx

Lines 96 to 111 in a97165c

	return (
	<>
	<View style={[styles.optionsListSectionHeader]}>
	<Text style={[styles.ph5, styles.textLabelSupporting]}>{translate('iou.chooseWorkspace')}</Text>
	</View>
	<SelectionList
	key={selectedWorkspace?.policyID}
	data={workspaceOptions}
	onSelectRow={selectWorkspace}
	shouldSingleExecuteRowSelect
	ListItem={UserListItem}
	initiallyFocusedItemKey={selectedWorkspace?.policyID}
	/>
	</>
	);
	}

What changes do you think we should make in order to solve the problem?

We need to add search bar above here like what we did in WorkspaceCategoriesPage

{workspaceOptions.length > CONST.SEARCH_ITEM_LIMIT && (
    <SearchBar
        label={translate('workspace.common.findWorkspace')}
        inputValue={inputValue}
        onChangeText={setInputValue}
        shouldShowEmptyState={hasVisibleWorkspaces && !isLoading && filteredWorkspaceOptions.length === 0}
    />
)}

App/src/pages/iou/request/step/IOURequestStepPerDiemWorkspace.tsx

Line 101 in a97165c

<SelectionList

For the search logic we can use tokenizedSearch like what we did here so that the search behavior is consist with other screens

App/src/libs/tokenizedSearch.ts

Line 10 in afc8336

export default function tokenizedSearch<T>(items: T[], searchValue: string, getTextTokens: (item: T) => string[]): T[] {

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021979237162108284353

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[sakluger]

I've added this to the Quality project because it stems from this previous quality issue: #65212.