[HOLD for payment 2022-02-01] Used Emoji are shown twice in search result - Reported by @Tushu17

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Chat and use multiple emojis few times
3. Navigate to emoji picker and search any emoji

Expected Result:

Emoji should display only once

Actual Result:

Emoji displayed twice

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.29-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

recording.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mananjadhav]

I had worked on this piece and I am not sure if I would count this as a scope of that PR. But happy to do whatever we decide from the team.

Proposal

1. The solution can be we either skip the search in "frequently used" category
2. Or we just run uniq by code on the filteredEmojis.

I will recommend the second one:

App/src/pages/home/report/EmojiPickerMenu/index.js

Lines 308 to 312 in 74cf52f

	const newFilteredEmojiList = _.filter(this.emojis, emoji => (
	!emoji.header
	&& emoji.code !== CONST.EMOJI_SPACER
	&& _.find(emoji.keywords, keyword => keyword.includes(normalizedSearchTerm))
	));

In this block, we update the code as:

const newFilteredEmojiList = _.uniq(_.filter(this.emojis, emoji => (
            !emoji.header
            && emoji.code !== CONST.EMOJI_SPACER
            && _.find(emoji.keywords, keyword => keyword.includes(normalizedSearchTerm))
        )), false, (emoji => emoji.code));

[ctkochan22]

We should probably skip search in frequently used since the search parameters are the same for both. But I supposed there is merit in the second, as it would promote recently used within the search results. Lets go with the second one.

[MelvinBot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[ctkochan22]

@mananjadhav your second plan sounds good

[jboniface]

posted job and invited @mananjadhav https://www.upwork.com/jobs/~012625040bdf7302d7