[Due for payment 2025-10-28] [$250] Report - "Submitted" system message doesn´t appear while offline, but "Reopened" does.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.32-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1306/folder/13176741/41237131/955759332
Email or phone of affected tester (no customers): ibellicotest+1930@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least one workspace.
Prerequisite 2: Delayed submissions enabled and approvals disabled.

1. Open the Expensify app.
2. Open any workspace chat.
3. Turn off internet connection.
4. Create a manual expense.
5. Open the report of the just created expense.
6. Tap on "Submit"
7. Note that "Submitted" system message doesn´t appear on report.
8. Tap on "More" and select "Retract"
9. Note that a "Reopened" system message appears on report.
10. Turn on internet connection.
11. Note that now, "Submitted" message, appears above "Reopened"

Expected Result:

When an expense is submitted while in offline mode, a grayed out "Submitted" message, should appear on report.

Actual Result:

When an expense is submitted in offline mode, "Submitted" system message doesn´t appear on report, but if expense is retracted, a grayed out "Reopened" system message appears.
When recovering internet connection, "Submitted" system message appears above "Reopened".

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021978899822361652080
• Upwork Job ID: 1978899822361652080
• Last Price Increase: 2025-10-16

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When an expense is submitted in offline mode, "Submitted" system message doesn´t appear on report, but if expense is retracted, a grayed out "Reopened" system message appears.
When recovering internet connection, "Submitted" system message appears above "Reopened".

What is the root cause of that problem?

We don’t create a submitted action for isSubmitAndClosePolicy due to this PR:

App/src/libs/actions/IOU.ts

Line 10725 in e4aabe2

const optimisticData: OnyxUpdate[] = !isSubmitAndClosePolicy

What changes do you think we should make in order to solve the problem?

Since the "Submitted" system message still appears after reconnecting to the internet, we should still add a submitted action in submitReport.

If we truly want the "Submitted" system message not to appear, then we need to update the backend and apply similar changes to submitReport for reopenReport as well.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

While offline, submitting an expense from a workspace with delayed submissions enabled never shows the muted “Submitted” system message. Users only see the message after reconnecting, and if they retract the report while offline the timeline looks out of order.

What is the root cause of that problem?

submitReport only added the optimistic report action when the workspace was not in Submit & Close mode. For Submit & Close policies, we skipped the REPORT_ACTIONS merge, so no local “Submitted” action was rendered while offline.

App/src/libs/actions/IOU.ts

Lines 10703 to 10738 in f8e2af1

	const optimisticData: OnyxUpdate[] = !isSubmitAndClosePolicy
	? [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${expenseReport.reportID}`,
	value: {
	[optimisticSubmittedReportAction.reportActionID]: {
	...(optimisticSubmittedReportAction as OnyxTypes.ReportAction),
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	},
	},
	},
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${expenseReport.reportID}`,
	value: {
	...expenseReport,
	managerID,
	lastMessageText: getReportActionText(optimisticSubmittedReportAction),
	lastMessageHtml: getReportActionHtml(optimisticSubmittedReportAction),
	stateNum: CONST.REPORT.STATE_NUM.SUBMITTED,
	statusNum: CONST.REPORT.STATUS_NUM.SUBMITTED,
	},
	},
	]
	: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${expenseReport.reportID}`,
	value: {
	...expenseReport,
	stateNum: CONST.REPORT.STATE_NUM.APPROVED,
	statusNum: CONST.REPORT.STATUS_NUM.CLOSED,
	},
	},
	];

What changes do you think we should make in order to solve the problem?

Always enqueue the optimistic “Submitted” report action, regardless of the policy approval mode, and keep the report metadata in sync. That way the UI can render the gray action bubble immediately while offline and still clear pending or error states correctly.

const optimisticData: OnyxUpdate[] = [
    {
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${expenseReport.reportID}`,
        value: {
            [optimisticSubmittedReportAction.reportActionID]: {
                ...(optimisticSubmittedReportAction as OnyxTypes.ReportAction),
                pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
            },
        },
    },
];

if (!isSubmitAndClosePolicy) {
    optimisticData.push({
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.REPORT}${expenseReport.reportID}`,
        value: {
            ...expenseReport,
            managerID,
            lastMessageText: getReportActionText(optimisticSubmittedReportAction),
            lastMessageHtml: getReportActionHtml(optimisticSubmittedReportAction),
            stateNum: CONST.REPORT.STATE_NUM.SUBMITTED,
            statusNum: CONST.REPORT.STATUS_NUM.SUBMITTED,
        },
    });
} else {
    optimisticData.push({
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.REPORT}${expenseReport.reportID}`,
        value: {
            ...expenseReport,
            lastMessageText: getReportActionText(optimisticSubmittedReportAction),
            lastMessageHtml: getReportActionHtml(optimisticSubmittedReportAction),
            stateNum: CONST.REPORT.STATE_NUM.APPROVED,
            statusNum: CONST.REPORT.STATUS_NUM.CLOSED,
        },
    });
}

const successData: OnyxUpdate[] = [
    {
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${expenseReport.reportID}`,
        value: {
            [optimisticSubmittedReportAction.reportActionID]: {
                pendingAction: null,
            },
        },
    },
];

const failureData: OnyxUpdate[] = [
    {
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.REPORT}${expenseReport.reportID}`,
        value: {
            statusNum: CONST.REPORT.STATUS_NUM.OPEN,
            stateNum: CONST.REPORT.STATE_NUM.OPEN,
        },
    },
    {
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.NEXT_STEP}${expenseReport.reportID}`,
        value: currentNextStep,
    },
    {
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${expenseReport.reportID}`,
        value: {
            [optimisticSubmittedReportAction.reportActionID]: {
                errors: getMicroSecondOnyxErrorWithTranslationKey('iou.error.other'),
            },
        },
    },
];

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021978899822361652080

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[jjcoffee]

@dmkt9's proposal sounds good to me!

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details.