[Due for payment 2025-11-11] [$250] FAB - “Test drive” task sound plays twice

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.34-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176926/test-cases/41237617
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 11, Chrome | Samsung A15, Android 15, Chrome
App Component: Other

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Sign up with a Gmail address that includes a +
3. Select "Manage my team's expenses" > 1-10 employees > QBO > Skip the remaining steps.
4. Click on FAB > Take a 2-minute test drive

Expected Result:

The “Test drive” task should trigger the sound effect only once.

Actual Result:

The sound associated with the “Test drive” task completion plays two times in quick succession.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021981480880218737002
• Upwork Job ID: 1981480880218737002
• Last Price Increase: 2025-10-23

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

FAB - "Test drive" task sound plays twice

What is the root cause of that problem?

completeTestDriveTask is called twice:

App/src/libs/actions/Tour.ts

Line 29 in f9ee4f0

completeTestDriveTask(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived, shouldUpdateSelfTourViewedOnlyLocally);

App/src/components/TestDrive/TestDriveDemo.tsx

Line 46 in f9ee4f0

completeTestDriveTask(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived);

When a user clicks the FAB button to start the test drive, the task is completed and the sound plays. Then when the TestDriveDemo component mounts, it completes the task again, playing the sound a second time

What changes do you think we should make in order to solve the problem?

Remove the completeTestDriveTask call from the useEffect

App/src/components/TestDrive/TestDriveDemo.tsx

Line 46 in f9ee4f0

completeTestDriveTask(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived);

Or here

App/src/libs/actions/Tour.ts

Line 29 in f9ee4f0

completeTestDriveTask(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived, shouldUpdateSelfTourViewedOnlyLocally);

What alternative solutions did you explore? (Optional)

Add a shouldPlaySound parameter to the task completion functions and disable sound when completing from FAB

function completeTask(taskReport: OnyxEntry<OnyxTypes.Report>, reportIDFromAction?: string, shouldPlaySound = true): OnyxData {
    const taskReportID = taskReport?.reportID ?? reportIDFromAction;

    if (!taskReportID) {
        return {};
    }

    const {optimisticData, successData, failureData, parameters} = buildTaskData(taskReport, taskReportID);

    if (shouldPlaySound) {
        playSound(SOUNDS.SUCCESS);
    }
    API.write(WRITE_COMMANDS.COMPLETE_TASK, parameters, {optimisticData, successData, failureData});
    return {optimisticData, successData, failureData};
}

App/src/libs/actions/Task.ts

Line 451 in f9ee4f0

function completeTask(taskReport: OnyxEntry<OnyxTypes.Report>, reportIDFromAction?: string): OnyxData {

Make getFinishOnboardingTaskOnyxData to accept and pass through shouldPlaySound

function getFinishOnboardingTaskOnyxData(taskReport: OnyxEntry<OnyxTypes.Report>, taskParentReport: OnyxEntry<OnyxTypes.Report>, isParentReportArchived: boolean, shouldPlaySound = true): OnyxData {
    if (taskReport && canActionTask(taskReport, currentUserAccountID, taskParentReport, isParentReportArchived)) {
        if (taskReport) {
            if (taskReport.stateNum !== CONST.REPORT.STATE_NUM.APPROVED || taskReport.statusNum !== CONST.REPORT.STATUS_NUM.APPROVED) {
                return completeTask(taskReport, undefined, shouldPlaySound);
            }
        }
    }

    return {};
}

App/src/libs/actions/Task.ts

Line 1295 in f9ee4f0

function getFinishOnboardingTaskOnyxData(taskReport: OnyxEntry<OnyxTypes.Report>, taskParentReport: OnyxEntry<OnyxTypes.Report>, isParentReportArchived: boolean): OnyxData {

Then completeTestDriveTask as well

function completeTestDriveTask(
    viewTourTaskReport: OnyxEntry<OnyxTypes.Report>,
    viewTourTaskParentReport: OnyxEntry<OnyxTypes.Report>,
    isViewTourTaskParentReportArchived: boolean,
    shouldUpdateSelfTourViewedOnlyLocally = false,
    shouldPlaySound = true,
) {
    setSelfTourViewed(shouldUpdateSelfTourViewedOnlyLocally);
    getFinishOnboardingTaskOnyxData(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived, shouldPlaySound);
}

App/src/libs/actions/Task.ts

Line 1306 in f9ee4f0

function completeTestDriveTask(

ChangestartTestDrive to disable the sound

            completeTestDriveTask(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived, shouldUpdateSelfTourViewedOnlyLocally, false);

App/src/libs/actions/Tour.ts

Line 29 in f9ee4f0

completeTestDriveTask(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived, shouldUpdateSelfTourViewedOnlyLocally);

[paulnjs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The sound associated with the “Test drive” task completion plays two times in quick succession.

What is the root cause of that problem?

The task sound is played twice because completeTestDriveTask is called twice. Once from startTestDrive, once from TestDriveDemo

App/src/components/TestDrive/TestDriveDemo.tsx

Line 46 in f9ee4f0

completeTestDriveTask(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived);

App/src/libs/actions/Tour.ts

Line 29 in f9ee4f0

completeTestDriveTask(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived, shouldUpdateSelfTourViewedOnlyLocally);

What changes do you think we should make in order to solve the problem?

1. Since we navigate to the test drive modal in this case, we can remove completeTestDriveTask here

App/src/libs/actions/Tour.ts

Line 29 in f9ee4f0

completeTestDriveTask(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived, shouldUpdateSelfTourViewedOnlyLocally);

2. We can go to this page by deeplink or from other pages, so we should prevent completeTestDriveTask from being called if this task is completed. We should move this line to another useEffect

const [hasSeenTour = false] = useOnyx(ONYXKEYS.NVP_ONBOARDING, {
    selector: hasSeenTourSelector,
    canBeMissing: true,
});
useEffect(() => {
    if (hasSeenTour) {
        return;
    }
    completeTestDriveTask(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived);
}, [hasSeenTour]);

App/src/components/TestDrive/TestDriveDemo.tsx

Line 46 in f9ee4f0

completeTestDriveTask(viewTourTaskReport, viewTourTaskParentReport, isViewTourTaskParentReportArchived);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021981480880218737002

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[rojiphil]

@paulnjs Agree that it is better to remove the completeTestDriveTask from startTestDrive as mentioned in step 1.
However, I don’t quite understand the need for step 2 of the solution.
Can you please detail the test steps that would fail without step 2?