[$250] To-do-"Something went wrong" briefly shown after paying offline, going back to pay and online

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.39-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176923/test-cases/53628502
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacBook Air 15.6.1 Chrome, iPhone 15 iOS 18.5 Safari
App Component: Search

Action Performed:

1. Sign in to ND
2. Create a workspace
3. Create an expense in the workspace chat, submit it and approve
4. Navigate to the Reports tab - To-do section - Pay
5. Go offline
6. Expand the report and click View, click Pay green button at the top, Mark as paid
7. Go online and navigate back to the To-do - Pay

Expected Result:

"Something went wrong" is not shown after paying the report offline, navigating back to "To-do: Pay" and going online

Actual Result:

"Something went wrong" is shown briefly after paying the report offline, navigating back to "To-do: Pay" and going online

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6986312_1761609946336.Oops.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021985720471636242136
• Upwork Job ID: 1985720471636242136
• Last Price Increase: 2025-11-11

Issue Owner

Current Issue Owner: @thesahindia

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mukhrr]

🚨 Edited by proposal-police: This proposal was edited at 2025-11-13 17:20:13 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user pays a report offline, navigates to "To-do: Pay", and then goes online, a "Something went wrong" error briefly appears, even though the action completed successfully offline.

What is the root cause of that problem?

when paying offline we got searchResults?.errors

App/src/components/Search/index.tsx

Line 387 in 805a21f

const hasErrors = Object.keys(searchResults?.errors ?? {}).length > 0 && !isOffline;

and this makes error message to exist until we fetch fresh data

App/src/components/Search/index.tsx

Lines 868 to 880 in 805a21f

	if (hasErrors) {
	const isInvalidQuery = searchRequestResponseStatusCode === CONST.JSON_CODE.INVALID_SEARCH_QUERY;
	return (
	<View style={[shouldUseNarrowLayout ? styles.searchListContentContainerStyles : styles.mt3, styles.flex1]}>
	<FullPageErrorView
	shouldShow
	subtitleStyle={styles.textSupporting}
	title={translate('errorPage.title', {isBreakLine: shouldUseNarrowLayout})}
	subtitle={translate(isInvalidQuery ? 'errorPage.wrongTypeSubtitle' : 'errorPage.subtitle')}
	/>
	</View>
	);
	}

And the reason when paying offline and returning back to online we use failureData of getOnyxLoadingData here. And it always returns error message

App/src/libs/actions/Search.ts

Lines 246 to 259 in 805a21f

	const failureData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.SNAPSHOT}${hash}`,
	value: {
	...(isOffline ? {} : {data: []}),
	search: {
	status: queryJSON?.status,
	type: queryJSON?.type,
	isLoading: false,
	},
	errors: getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage'),
	},
	},

What changes do you think we should make in order to solve the problem?

We should not return error message when it's offline

const failureData: OnyxUpdate[] = [
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.SNAPSHOT}${hash}`,
            value: {
                ...(isOffline ? {} : {data: []}),
                search: {
                    status: queryJSON?.status,
                    type: queryJSON?.type,
                    isLoading: false,
                },
                errors: isOffline ? null : getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage'),
            },
        }

We can add this check for paying request payMoneyRequestOnSearch also if we need

What alternative solutions did you explore? (Optional)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Something went wrong" is shown briefly after paying the report offline, navigating back to "To-do: Pay" and going online

What is the root cause of that problem?

When users pay in offline mode, we'll trigger Search API

App/src/components/MoneyReportHeader.tsx

Line 444 in f2b8cc1

search({

and it'll fail, then we'll update the errors field

App/src/libs/actions/Search.ts

Line 257 in f2b8cc1

errors: getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage'),

so we can see the Something went wrong util the new Search API is triggered successfully

What changes do you think we should make in order to solve the problem?

Solution 1: Disable pay button in offline mode like what we did in search page while offline

Update this line

to isDisabled={isOffline} or isDisabled={isOffline || !canAllowSettlement}

we can check other action if needed

Solution 2: Do not call Search API in offline mode because it'll fail

update these lines to

if (currentSearchQueryJSON && !isOffline) {

we can consider to update these Onyx value if needed while offline

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021985720471636242136

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)