Remove `Onyx.connect()` for the key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}` in `src/libs/actions/Report.ts`

[tgolen]

This is part of deprecating Onyx.connect. Parent Issue

Details

• Module: src/libs/actions/Report.ts
• Onyx Key: ${ONYXKEYS.COLLECTION.REPORT}${reportID}
• Reference: Line 3597: ${ONYXKEYS.COLLECTION.REPORT}${reportID}

Be sure to refactor methods using test driven development:

1. Create a unit test for methods before refactoring
2. Refactor the methods
3. Ensure the unit test still runs after refactoring
4. Reinforce the unit testing with a functional test and a QA test
5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code

Issue Owner

Current Issue Owner: @parasharrajat

[tgolen]

Warning

DO NOT POST PROPOSALS ON THIS ISSUE!!

Bug-Zero Instructions

• This issue is CLOSED for proposals
• It is a special issue and part of a bigger project
• A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
• The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
• There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Are we accepting External contributors on it, I’m ready to work on this one.

[tgolen]

@samranahm historically, this project has been for a closed group of contributors. However, I would be open to seeing what your proposal would be for this one. If it works out and you are solid and know what you're doing with few instuctions, then perhaps you can work on more of these for us. Can you post a quick proposal for this one, please?

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove Onyx.connect() for the key

What is the root cause of that problem?

Part of deprecating Onyx.connect

What changes do you think we should make in order to solve the problem?

Currently we use this key ${ONYXKEYS.COLLECTION.REPORT}${reportID} to get the associated report using Onyx.connect

App/src/libs/actions/Report.ts

Lines 3597 to 3607 in f2b8cc1

	const reportConnection = Onyx.connect({
	key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
	// eslint-disable-next-line rulesdir/prefer-early-return
	callback: (report) => {
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	if (report?.errorFields?.notFound || report?.reportID) {
	Onyx.disconnect(reportConnection);
	navigateHandler(report);
	}
	},
	});

• We should move the openReportFromDeepLink function to libs/actions/Link.ts from Report.ts
• Second we should change the Onyx.connect to Onyx.connectWithoutView

here

App/src/libs/actions/Link.ts

Lines 18 to 23 in c475261

	let isNetworkOffline = false;
	// Use connectWithoutView since this is to open an external link and doesn't affect any UI
	Onyx.connectWithoutView({
	key: ONYXKEYS.NETWORK,
	callback: (value) => (isNetworkOffline = value?.isOffline ?? false),
	});

We also need to add unit test and verify current test work as expected after the refactoring and decrease the max-warnings.

App/package.json

Line 50 in f2b8cc1

"lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=154 --cache --cache-location=node_modules/.cache/eslint",

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.