[Due for payment 2025-12-26] [$250] Expense - In offline, expense preview doesn't show paid tag and thread message is shown as msg

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.2.42-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1661/folder/13176924/41237585/987478631
Email or phone of affected tester (no customers): Slottwo1 72old.approver@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13 phone
App Component: Money Requests

Action Performed:

1.Go to https://staging.new.expensify.com/home
2. Login with new gmail account
3. Tap fab - scan - try it out
4. Tap create expense and complete the flow
5. Go forced offline
6. Tap plus icon and create a manual expense
7. Note preview 1 expense is shown
8. Open the expense details
9. Long press paid message and select reply thread
10. Send a message in thread page
11. Go back to expense details page
12. Note thread message is shown in expense details page and in thread page
13. Tap reply
14. Confirm again thread message is shown in expense details page and in thread page
15. Go back to main chat page
16. Note expense paid but in preview still 1 expense is shown
17. Toggle off forced offline
18. Note after turning online only paid tag is shown in preview
19. Open the expense details
20 Note thread message is shown as main chat message

Expected Result:

In offline, expense preview must show paid tag and thread message musnt shown as parent message in online.

Actual Result:

In offline, expense preview doesn't show paid tag and thread message is shown as parent message in online.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021986891362510594739
• Upwork Job ID: 1986891362510594739
• Last Price Increase: 2025-11-21

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[paulnjs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In offline, expense preview doesn't show paid tag and thread message is shown as parent message in online.

What is the root cause of that problem?

1. In offline, expense preview must show paid tag

we didn't update stateNum: 2 and statusNum: 4 for the iou report like what Be returns so we don't see the paid status

App/src/libs/actions/IOU.ts

Lines 1789 to 1795 in 515655a

	key: `${ONYXKEYS.COLLECTION.REPORT}${iou.report.reportID}`,
	value: {
	...iou.report,
	...(!isScanRequest || isTestReceipt ? {lastActionType: CONST.REPORT.ACTIONS.TYPE.MARKED_REIMBURSED, statusNum: CONST.REPORT.STATUS_NUM.REIMBURSED} : undefined),
	hasOutstandingChildRequest: false,
	lastActorAccountID: currentUserPersonalDetails?.accountID,
	},

2. Thread message musnt shown as parent message in online.

In offline mode, we're building the reportAction for the iou report with childReportID (transaction thread report id) and originalMessage. type: create

then override it in

App/src/libs/actions/IOU.ts

Lines 1769 to 1779 in 515655a

	const optimisticIOUReportAction = buildOptimisticIOUReportAction({
	type: isScanRequest && !isTestReceipt ? CONST.IOU.REPORT_ACTION_TYPE.CREATE : CONST.IOU.REPORT_ACTION_TYPE.PAY,
	amount: iou.report?.total ?? 0,
	currency: iou.report?.currency ?? '',
	comment: '',
	participants: [managerMcTestParticipant],
	paymentType: isScanRequest && !isTestReceipt ? undefined : CONST.IOU.PAYMENT_TYPE.ELSEWHERE,
	iouReportID: iou.report.reportID,
	transactionID: transaction.transactionID,
	reportActionID: iou.action.reportActionID,
	});

with the type is pay

so we can see the message marked as paid

App/src/pages/home/report/PureReportActionItem.tsx

Lines 1192 to 1197 in 515655a

	} else if (isActionOfType(action, CONST.REPORT.ACTIONS.TYPE.IOU) && getOriginalMessage(action)?.type === CONST.IOU.REPORT_ACTION_TYPE.PAY) {
	const wasAutoPaid = getOriginalMessage(action)?.automaticAction ?? false;
	const paymentType = getOriginalMessage(action)?.paymentType;
	if (paymentType === CONST.IOU.PAYMENT_TYPE.ELSEWHERE) {
	children = <ReportActionItemBasicMessage message={translate('iou.paidElsewhere')} />;

when users reply in thread, we'll check for childReportID, in this case it's transaction thread report id so we add the new message to this report.

Unfortunately, the iou report in this case is also the one transaction thread report, so we combine the actions from these reports to display => we can see the replied message in the iou report

What changes do you think we should make in order to solve the problem?

1. Update

stateNum: 2,
statusNum: 4,

to this

2. Create a separate action for type: pay instead of overriding the create one, like what BE did

In here, create the new id

const id=NumberUtils.rand64()

use the id in here and here

we also need to update BE to accept the new actionID

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Evidence

Screen.Recording.2025-11-03.at.00.29.19.mov

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[alexpensify]

Reassigning the label so this one doesn't get lost.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021986891362510594739