[Due for payment 2026-02-12] [HOLD for #76189] [$250] Tags - Missing tag violation for first expense is shown only after creating second expense

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.2.43-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): Slottwo1 72old.approver@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Money Requests

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Go to workspace settings -more features
3. Enable Tags
4. Create a manual expense entering merchant and category
5. Go to tags page
6. Add few tags
7. Tap settings
8. Enable members must tag all expenses
9. Go to workspace chat
10. Note in preview missing tag violation is not shown
11. Open the expense and now tag required is not shown
12. Go back to workspace chat
13. Create a manual expense entering merchant
14. Now note in preview missing tag violation is shown for both expenses
15. Open the expense report and details page and note violation is now shown for both expenses

Expected Result:

Missing tag violation for first expense must be shown after changing settings members must tag all expenses.

Actual Result:

Missing tag violation for first expense is shown only after creating second expense.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021986535910600778021
• Upwork Job ID: 1986535910600778021
• Last Price Increase: 2025-12-25

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tags - Missing tag violation for first expense is shown only after creating second expense

What is the root cause of that problem?

When the user enables "members must tag all expenses" setting, we only updates the policy setting but does not recalculate violations for existing transactions

App/src/libs/actions/Policy/Tag.ts

Lines 917 to 986 in 28ede48

	function setPolicyRequiresTag(policyID: string, requiresTag: boolean) {
	const policyTags = allPolicyTags?.[`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`] ?? {};
	const onyxData: OnyxData = {
	optimisticData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	requiresTag,
	errors: {requiresTag: null},
	pendingFields: {
	requiresTag: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},
	},
	},
	],
	successData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	errors: {
	requiresTag: null,
	},
	pendingFields: {
	requiresTag: null,
	},
	},
	},
	],
	failureData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	requiresTag: !requiresTag,
	errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('workspace.tags.genericFailureMessage'),
	pendingFields: {
	requiresTag: null,
	},
	},
	},
	],
	};
	const getUpdatedTagsData = (required: boolean): OnyxUpdate => ({
	key: `${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`,
	onyxMethod: Onyx.METHOD.MERGE,
	value: {
	...Object.keys(policyTags).reduce<PolicyTagLists>((acc, key) => {
	acc[key] = {
	...acc[key],
	required,
	};
	return acc;
	}, {}),
	},
	});
	onyxData.optimisticData?.push(getUpdatedTagsData(requiresTag));
	onyxData.failureData?.push(getUpdatedTagsData(!requiresTag));
	onyxData.successData?.push(getUpdatedTagsData(requiresTag));
	const parameters = {
	policyID,
	requiresTag,
	};
	API.write(WRITE_COMMANDS.SET_POLICY_REQUIRES_TAG, parameters, onyxData);

Unlike the setWorkspaceRequiresCategory function which properly calls pushTransactionViolationsOnyxData to recalculate violations for all existing transactions when the category requirement setting changes

App/src/libs/actions/Policy/Category.ts

Lines 892 to 953 in 28ede48

	function setWorkspaceRequiresCategory(
	policyID: string,
	requiresCategory: boolean,
	policyTagLists: PolicyTagLists = {},
	policyCategories: PolicyCategories = {},
	allTransactionViolations: OnyxCollection<TransactionViolations> = {},
	) {
	const onyxData: OnyxData = {
	optimisticData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	requiresCategory,
	errors: {
	requiresCategory: null,
	},
	pendingFields: {
	requiresCategory: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},
	},
	},
	],
	successData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	errors: {
	requiresCategory: null,
	},
	pendingFields: {
	requiresCategory: null,
	},
	},
	},
	],
	failureData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	requiresCategory: !requiresCategory,
	errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('workspace.categories.updateFailureMessage'),
	pendingFields: {
	requiresCategory: null,
	},
	},
	},
	],
	};
	pushTransactionViolationsOnyxData(onyxData, policyID, policyTagLists, policyCategories, allTransactionViolations, {
	requiresCategory,
	} as Partial<Policy>);
	const parameters = {
	policyID,
	requiresCategory,
	};
	API.write(WRITE_COMMANDS.SET_WORKSPACE_REQUIRES_CATEGORY, parameters, onyxData);
	}

What changes do you think we should make in order to solve the problem?

We need to add the violation recalculation logic to the setPolicyRequiresTag, following the same pattern used in setWorkspaceRequiresCategory

function setPolicyRequiresTag(
    policyID: string,
    requiresTag: boolean,
    policyCategories: PolicyCategories = {},
    allTransactionViolations: OnyxCollection<TransactionViolations> = {},
) {
    ...
    onyxData.optimisticData?.push(getUpdatedTagsData(requiresTag));
    onyxData.failureData?.push(getUpdatedTagsData(!requiresTag));
    onyxData.successData?.push(getUpdatedTagsData(requiresTag));

    pushTransactionViolationsOnyxData(onyxData, policyID, policyTags, policyCategories, allTransactionViolations, {
        requiresTag,
    });

App/src/libs/actions/Policy/Tag.ts

Lines 917 to 986 in 28ede48

	function setPolicyRequiresTag(policyID: string, requiresTag: boolean) {
	const policyTags = allPolicyTags?.[`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`] ?? {};
	const onyxData: OnyxData = {
	optimisticData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	requiresTag,
	errors: {requiresTag: null},
	pendingFields: {
	requiresTag: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},
	},
	},
	],
	successData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	errors: {
	requiresTag: null,
	},
	pendingFields: {
	requiresTag: null,
	},
	},
	},
	],
	failureData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	requiresTag: !requiresTag,
	errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('workspace.tags.genericFailureMessage'),
	pendingFields: {
	requiresTag: null,
	},
	},
	},
	],
	};
	const getUpdatedTagsData = (required: boolean): OnyxUpdate => ({
	key: `${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`,
	onyxMethod: Onyx.METHOD.MERGE,
	value: {
	...Object.keys(policyTags).reduce<PolicyTagLists>((acc, key) => {
	acc[key] = {
	...acc[key],
	required,
	};
	return acc;
	}, {}),
	},
	});
	onyxData.optimisticData?.push(getUpdatedTagsData(requiresTag));
	onyxData.failureData?.push(getUpdatedTagsData(!requiresTag));
	onyxData.successData?.push(getUpdatedTagsData(requiresTag));
	const parameters = {
	policyID,
	requiresTag,
	};
	API.write(WRITE_COMMANDS.SET_POLICY_REQUIRES_TAG, parameters, onyxData);

Then update the function call to pass the additional parameters

    const [policyCategories] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`, {canBeMissing: true});
    const [allTransactionViolations] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS);
    const updateWorkspaceRequiresTag = useCallback(
        (value: boolean) => {
            setPolicyRequiresTag(policyID, value, policyCategories, allTransactionViolations);
        },
        [policyID, policyCategories, allTransactionViolations],
    );

App/src/pages/workspace/tags/WorkspaceTagsSettingsPage.tsx

Lines 63 to 68 in 28ede48

	const updateWorkspaceRequiresTag = useCallback(
	(value: boolean) => {
	setPolicyRequiresTag(policyID, value);
	},
	[policyID],
	);

What alternative solutions did you explore? (Optional)

None

[daledah]

i can't reproduce

[CortneyOfstad]

I'm also having trouble recreating. Going to see if QA can retest

[CortneyOfstad]

Request here — https://expensify.enterprise.slack.com/archives/C9YU7BX5M/p1762285757906329

[m-natarajan]

Reproduce, MacOS Monterey / Chrome, Web v9.2.43-2

Screen.Recording.2025-11-04.at.22.10.06.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021986535910600778021