"Waiting for admin to pay" shown after approving offline, then changes to "you"

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.45-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #72892, offline tests, step 2
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacBook Air 15.6.1 Chrome
App Component: Money Requests

Action Performed:

Preconditions: Main user is an owner of a workspace, invited a submitter and approver. Set approver as an approver in Workflows
Submitter created expense report with two expenses and submitted it.

1. Sign in as an owner of a workspace
2. Open the submitted report, go offline
3. Select "Change approver" → "Bypass approvers", the next action says "Waiting for you to approve expenses"
4. Go online and refresh the page - the next action shows the same
5. Go offline, approve the report
6. The next action message says "Waiting for admin to pay expenses"
7. Go online - the action message now says "Waiting for you to pay expenses"

Expected Result:

After workspace owner bypassed the approver and approved the report offline, the next action is "Waiting for you to pay expenses" (as it shows online)

Actual Result:

After workspace owner bypassed the approver and approved the report offline, the next action is "Waiting for admin to pay expenses", and changes to "Waiting for you to pay expenses" after going online
(In Prod next step offline is Waiting for Submitter to submit the expense)

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[marcaaron]

@parasharrajat @fahimj this one also seems related to the PR we have been working on. personally, I am not too concerned about the offline behavior as the bug we are fixing with the changes is worse than this regression. But we should address it with urgency.