[Due for payment 2025-12-16] [$250] Workflows - Approver field disappears and "Expense from" opens Not here when remove approver

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.48-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1891/folder/13177080/41237948/1005352331
Email or phone of affected tester (no customers): gocemate+b2155105@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Login with new gmail account
2. Complete the onboarding process
3. Create Workspace
4. Invite 2 members
5. One of them set as Approver
6. Go to Members> Select both users> Delete> Confirm
7. Go to Workflows

Expected Result:

Owner of the Workspace should be signed as Approver

Actual Result:

Approver section disappears. When click on "Expense from" Not here page opens

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6999593_1762789789295.Recording__6717.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021988288111916126513
• Upwork Job ID: 1988288111916126513
• Last Price Increase: 2025-11-18
• Automatic offers:
• linhvovan29546 | Reviewer | 109529543

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021988288111916126513

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @linhvovan29546 (External)

[nabi-ebrahimi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workflows - Approver field disappears and "Expense from" opens Not here when remove approver

What is the root cause of that problem?

The root cause is in the removeUsers function in WorkspaceMembersPage.tsx. When removing members, it iterates over all selected employees and attempts to update approval workflows for each one using updateWorkflowDataOnApproverRemoval. However:

This function only processes approvers correctly. or non-approvers, it generates empty or invalid updatedWorkflows (e.g., no approvers left, leading to removeApprovalWorkflow being triggered incorrectly).

As a result, even non-approver removals can inadvertently clear the entire approval workflow, causing the section to disappear and breaking navigation to related pages like "Expense from."

This over-processing affects the global workflow state, preventing the fallback to the owner as the default approver.

What changes do you think we should make in order to solve the problem?

Update the removeUsers function in WorkspaceMembersPage.tsx to only process workflow updates for actual approvers among the selected employees. This ensures non-approvers don't interfere with workflow logic.

Change These:

App/src/pages/workspace/WorkspaceMembersPage.tsx

Lines 205 to 239 in 4892bca

	const removeUsers = () => {
	// Check if any of the members are approvers
	const hasApprovers = selectedEmployees.some((email) => isApprover(policy, email));
	if (hasApprovers) {
	const ownerEmail = ownerDetails.login;
	selectedEmployees.forEach((login) => {
	const accountID = policyMemberEmailsToAccountIDs[login];
	const removedApprover = personalDetails?.[accountID];
	if (!removedApprover?.login || !ownerEmail) {
	return;
	}
	const updatedWorkflows = updateWorkflowDataOnApproverRemoval({
	approvalWorkflows,
	removedApprover,
	ownerDetails,
	});
	updatedWorkflows.forEach((workflow) => {
	if (workflow?.removeApprovalWorkflow) {
	const {removeApprovalWorkflow, ...updatedWorkflow} = workflow;
	removeApprovalWorkflowAction(updatedWorkflow, policy);
	} else {
	updateApprovalWorkflow(workflow, [], [], policy);
	}
	});
	});
	}
	setRemoveMembersConfirmModalVisible(false);
	// eslint-disable-next-line @typescript-eslint/no-deprecated
	InteractionManager.runAfterInteractions(() => {
	setSelectedEmployees([]);
	removeMembers(policyID, selectedEmployees, policyMemberEmailsToAccountIDs);
	});
	};

To These:

 const removeUsers = () => {
        // Check if any of the members are approvers
        const hasApprovers = selectedEmployees.some((email) => isApprover(policy, email));

        if (hasApprovers) {
            const ownerEmail = ownerDetails.login;
            selectedEmployees.forEach((login) => {
            if (!isApprover(policy, login)) {
                    return;
                 }
                const accountID = policyMemberEmailsToAccountIDs[login];
                const removedApprover = personalDetails?.[accountID];
                if (!removedApprover?.login || !ownerEmail) {
                    return;
                }
                const updatedWorkflows = updateWorkflowDataOnApproverRemoval({
                    approvalWorkflows,
                    removedApprover,
                    ownerDetails,
                });
                updatedWorkflows.forEach((workflow) => {
                    if (workflow?.removeApprovalWorkflow) {
                        const {removeApprovalWorkflow, ...updatedWorkflow} = workflow;
                        removeApprovalWorkflowAction(updatedWorkflow, policy);
                    } else {
                        updateApprovalWorkflow(workflow, [], [], policy);
                    }
                });
            });
        }

        setRemoveMembersConfirmModalVisible(false);
        // eslint-disable-next-line @typescript-eslint/no-deprecated
        InteractionManager.runAfterInteractions(() => {
            setSelectedEmployees([]);
            removeMembers(policyID, selectedEmployees, policyMemberEmailsToAccountIDs);
        });
    };

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

[github-actions]

⚠️ @nabi-ebrahimi Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[linhvovan29546]

@nabi-ebrahimi Thank you for your proposal. It helps address this issue, but it seems that removeUsers violates the 1:1:1 API. I’ll check with the internal engineering team to clarify the next steps.