[$250] Enforcement settings appear under the wrong section in New Expensify

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.48-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): #Migrate

Action Performed:

1. Compare Classic and New Expensify workspace settings
2. In Classic: navigate to Workspace > Workflows > Enforcement
3. In New Expensify: the same settings appear under Workspace > Expenses > Expense Reports

Expected Result:

Enforcement settings should appear under Workspace > Workflows > Expense Reports, consistent with Classic and the nature of the settings (approvals and payments).

Actual Result:

Enforcement settings are currently located under Workspace > Expenses > Expense Reports, which is inconsistent with Classic

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1904.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021988251394559480113
• Upwork Job ID: 1988251394559480113
• Last Price Increase: 2025-11-11
• Automatic offers:
• nyomanjyotisa | Contributor | 109469265

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @dukenv0307

[melvin-bot]

Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Enforcement settings appear under the wrong section in New Expensify

What is the root cause of that problem?

ExpenseReportRulesSection component (which contains enforcement settings like prevent self-approvals, auto-approve compliant reports, and auto-pay approved reports) is currently rendered in PolicyRulesPage under the Rules section

App/src/pages/workspace/rules/PolicyRulesPage.tsx

Lines 13 to 44 in b3259ca

	import ExpenseReportRulesSection from './ExpenseReportRulesSection';
	import IndividualExpenseRulesSection from './IndividualExpenseRulesSection';
	type PolicyRulesPageProps = PlatformStackScreenProps<WorkspaceSplitNavigatorParamList, typeof SCREENS.WORKSPACE.RULES>;
	function PolicyRulesPage({route}: PolicyRulesPageProps) {
	const {translate} = useLocalize();
	const {policyID} = route.params;
	const styles = useThemeStyles();
	const {shouldUseNarrowLayout} = useResponsiveLayout();
	const illustrations = useMemoizedLazyIllustrations(['Rules'] as const);
	return (
	<AccessOrNotFoundWrapper
	policyID={policyID}
	featureName={CONST.POLICY.MORE_FEATURES.ARE_RULES_ENABLED}
	accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN, CONST.POLICY.ACCESS_VARIANTS.PAID]}
	>
	<WorkspacePageWithSections
	testID={PolicyRulesPage.displayName}
	shouldUseScrollView
	headerText={translate('workspace.common.rules')}
	shouldShowOfflineIndicatorInWideScreen
	route={route}
	icon={illustrations.Rules}
	shouldShowNotFoundPage={false}
	shouldShowLoading={false}
	addBottomSafeAreaPadding
	>
	<View style={[styles.mt3, shouldUseNarrowLayout ? styles.workspaceSectionMobile : styles.workspaceSection]}>
	<IndividualExpenseRulesSection policyID={policyID} />
	<ExpenseReportRulesSection policyID={policyID} />

What changes do you think we should make in order to solve the problem?

Move ExpenseReportRulesSection from PolicyRulesPage to WorkspaceWorkflowsPage

<View style={[styles.mt3, shouldUseNarrowLayout ? styles.workspaceSectionMobile : styles.workspaceSection]}>
    {optionItems.map(renderOptionItem)}
    <ExpenseReportRulesSection policyID={route.params.policyID} />
    ...
</View>

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Lines 429 to 453 in b3259ca

	<View style={[styles.mt3, shouldUseNarrowLayout ? styles.workspaceSectionMobile : styles.workspaceSection]}>
	{optionItems.map(renderOptionItem)}
	{isBetaEnabled(CONST.BETAS.GLOBAL_REIMBURSEMENTS_ON_ND) ? (
	<ConfirmModal
	title={translate('workspace.bankAccount.workspaceCurrencyNotSupported')}
	isVisible={isUpdateWorkspaceCurrencyModalOpen}
	onConfirm={confirmCurrencyChangeAndHideModal}
	onCancel={() => setIsUpdateWorkspaceCurrencyModalOpen(false)}
	prompt={updateWorkspaceCurrencyPrompt}
	confirmText={translate('workspace.bankAccount.updateWorkspaceCurrency')}
	cancelText={translate('common.cancel')}
	/>
	) : (
	<ConfirmModal
	title={translate('workspace.bankAccount.workspaceCurrency')}
	isVisible={isUpdateWorkspaceCurrencyModalOpen}
	onConfirm={confirmCurrencyChangeAndHideModal}
	onCancel={() => setIsUpdateWorkspaceCurrencyModalOpen(false)}
	prompt={translate('workspace.bankAccount.updateCurrencyPrompt')}
	confirmText={translate('workspace.bankAccount.updateToUSD')}
	cancelText={translate('common.cancel')}
	danger
	/>
	)}
	</View>

What alternative solutions did you explore? (Optional)

None

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Enforcement settings are currently located under Workspace > Expenses > Expense Reports, which is inconsistent with Classic

What is the root cause of that problem?

We are defining the ExpenseReportRulesSection component in PolicyRulesPage component

App/src/pages/workspace/rules/PolicyRulesPage.tsx

Lines 42 to 45 in b3259ca

	<View style={[styles.mt3, shouldUseNarrowLayout ? styles.workspaceSectionMobile : styles.workspaceSection]}>
	<IndividualExpenseRulesSection policyID={policyID} />
	<ExpenseReportRulesSection policyID={policyID} />
	</View>

What changes do you think we should make in order to solve the problem?

We will have to split ExpenseReportRulesSection into different components to be consistent with OD

• Auto-approve compliant reports section similar to Expense Approvals in OD here

• Auto-pay approved reports section similar to Manual Reimbursement in OD here

• Prevent self-approvals section similar to Enforcement in OD here

then we'll move these components to the WorkspaceWorkflowsPage component and we will need to pay attention to the order

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[tgolen]

This is an internal issue. We need to change OldDot to be like NewDot, not the other way around.

[tgolen]

Actually, sorry. I misunderstood the original thread. We want to change NewDot to be consistent with OldDot in this case because these settings are more about approvals and not "rules".