[Due for payment 2026-01-06] [$250] Reports - Submit button is shown for second admin when "Prevent self-approval" is enabled

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.58-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exp https://test-management.browserstack.com/projects/2219752/test-runs/TR-1965/41236821/1013855676?q=self+approval&issue_type=jira
Email or phone of affected tester (no customers): onijsoidjsoijdoijds2@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. [Owner] Go to a Control workspace
2. [Owner] Create a draft report
3. [Owner] Go to Rules > Enable "Prevent self-approvals"
4. [Owner] Go to the draft report
5. [Owner] Observe no Submit button greyed out.
6. [Owner] Disable prevent self-approvals
7. [Owner] Go back to the report, submit it
8. [Owner] Enable prevent self-approvals again
9. [Owner] Go back to the report
10. [Owner] Observe no Approve button greyed out.

__

1. [Owner] Invite another admin to the workspace
2. [Owner] Create a draft report
3. [Admin] Go to the Reports page
4. [Admin] Observe the Submit button on the owner's draft report
5. [Admin] Observe the Approve button on the owner's outstanding report

Expected Result:

• Show the Submit or Approve buttons disabled to the restricted approver. Those appear to be missing:

2025-11-18_01-12-21.mp4

• Don't show Submit or Approve buttons to other admins in report results:

2025-11-18_01-13-34.mp4

Actual Result:

• Submit and Approve buttons don't show to the restricted approver greyed out "disabled".
• Submit and Approve buttons show to other admins on the Reports page.

Workaround:

Disable prevent self-approvals.

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

In-line above.

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021990891960763515259
• Upwork Job ID: 1990891960763515259
• Last Price Increase: 2025-12-02
• Automatic offers:
• aimane-chnaif | Reviewer | 109716881

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[trjExpensify]

@nlemma - who's the set approver on the workspace? Is it the owner? I'm assuming it is, but the bug report doesn't specify that and it's a vital bit of information to understand what's going on.

Another thing to note is that it seems like there's no "Next steps" at the top of the report. What does the corresponding report say on Classic?

As for the handling of this case. @lakchote @JmillsExpensify IIRC, the intended solution for both submit and approve was:

• Show the Submit / Approve button like normal, but "disabled".
• Communicate why that is in the next steps alongside it.

Is that right?

[trjExpensify]

Asking for input, melv.

[JmillsExpensify]

As for the handling of this case. @lakchote @JmillsExpensify IIRC, the intended solution for both submit and approve was:

• Show the Submit / Approve button like normal, but "disabled".
• Communicate why that is in the next steps alongside it.

Is that right?

Yes, that sounds right to me.

[trjExpensify]

Okay cool, so doing some more testing. I can't seem to repro the next steps issue.

If it's the restricted approver submitting to themselves:

If it's another admin viewer:

---

So I think the two things to fix here are.

• Show the Submit or Approve buttons disabled to the restricted approver. Those appear to be missing:

2025-11-18_01-12-21.mp4

• Don't show Submit or Approve buttons to other admins in report results:

2025-11-18_01-13-34.mp4

[nlemma]

who's the set approver on the workspace? Is it the owner? I'm assuming it is, but the bug report doesn't specify that and it's a vital bit of information to understand what's going on.

@trjExpensify sorry for being a bit late to respond, but the owner is the approver.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021990891960763515259