[Due for payment 2025-12-31] [$250] Web - Public room - Page freezes when anon user close attachment after press Ctrl K

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.60-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2009/folder/13176964/41237765/1022757317
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Win 11/Chrome
App Component: Other

Action Performed:

1. Open https://staging.new.expensify.com/r/2091104345528462 without login
2. Click on any attachment
3. Press on CTRL + K
4. Click on X button for close attachment
5. Click on any button or attachment of page

Expected Result:

User can login

Actual Result:

Click on an attachment and press CTRL + K, Sign in modal appears but hidden under attachment. Close attachment, sign in modal also disappears and page freezes

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021993335557192555754
• Upwork Job ID: 1993335557192555754
• Last Price Increase: 2025-12-02

Issue Owner

Current Issue Owner: @yuwenmemon

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

🚨 Edited by proposal-police: This proposal was edited at 2025-12-04 08:39:54 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Page freezes when using search shortcut and then closes the attachment page.

What is the root cause of that problem?

When we use the search shortcut as anon user, we will open the sign in RHP, but the attachment page still shows. When we close the attachment page, it dismiss the attachment modal and closes the sign in RHP, but the attachment page is still in the stack.

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 285 to 292 in 9952437

	() => {
	Session.callFunctionIfActionIsAllowed(() => {
	if (Navigation.isOnboardingFlow()) {
	return;
	}
	toggleSearch();
	})();
	},

We already close any modal before opening the search router,

App/src/components/Search/SearchRouter/SearchRouterContext.tsx

Lines 75 to 82 in 9952437

	close(
	() => {
	setIsSearchRouterDisplayed(true);
	searchRouterDisplayedRef.current = true;
	},
	false,
	true,
	);

but this only happens if it passes teh callFunctionIfActionIsAllowed, which doesn't happen in this case.

What changes do you think we should make in order to solve the problem?

Use the Modal.close here instead

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 285 to 292 in 9952437

	() => {
	Session.callFunctionIfActionIsAllowed(() => {
	if (Navigation.isOnboardingFlow()) {
	return;
	}
	toggleSearch();
	})();
	},

OR

Move the callFunctionIfActionIsAllowed to here

App/src/components/Search/SearchRouter/SearchRouterContext.tsx

Lines 75 to 82 in 9952437

	close(
	() => {
	setIsSearchRouterDisplayed(true);
	searchRouterDisplayedRef.current = true;
	},
	false,
	true,
	);

close(
    callFunctionIfActionIsAllowed(() => {
        setIsSearchRouterDisplayed(true);
        searchRouterDisplayedRef.current = true;
    }),
    false,
    true,
);

OR

Use the Modal.close here instead if the user is anonymous because it'll always open a sign-in RHP.

App/src/libs/actions/Session/index.ts

Lines 425 to 430 in 2b2e960

	function callFunctionIfActionIsAllowed<TCallback extends ((...args: any[]) => any) | void>(callback: TCallback, isAnonymousAction = false): TCallback | (() => void) {
	if (isAnonymousUser() && !isAnonymousAction) {
	return () => {
	signOutAndRedirectToSignIn();
	};
	}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021993335557192555754

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)