[Due for Payment 12/26] [$250] Expense - Hold educational modal appears twice

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.60-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #75150
Email or phone of affected tester (no customers): djosijnoijsoijsoi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Open 1:1 DM with another user.
3. Submit an expense to the user.
4. Click More > Hold.
   → No hold educational modal is shown for IOU expense - Expected according to [CP Staging] Do not show HOLD educational modal in money requests from DMs #75150.
5. Close the RHP.
6. Submit one more expense to the user.
7. Open any expense.
8. Click More > Hold.
   → Hold educational modal is shown when there are at least two IOU expenses.
9. Close the RHP.
10. Go to workspace chat and create an expense.
11. Open the expense report.
12. Click More > Hold.
    → Hold educational modal appears for the second time.

Expected Result:

In Step 8, Hold educational modal should not display when there are at least two IOU expenses (according to #75150).

Actual Result:

In Step 8, Hold educational modal is displayed when there are at least two IOU expenses.

In Step 12, when holding workspace expense, Hold educational modal appears for the second time.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7008115_1763545778523.24.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021993736373490522541
• Upwork Job ID: 1993736373490522541
• Last Price Increase: 2025-12-03

Issue Owner

Current Issue Owner: @iwiznia

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Hold educational modal appears twice

What is the root cause of that problem?

Here we check if parenReport is DM:

App/src/components/MoneyRequestHeader.tsx

Line 136 in 65e9f4f

const isParentReportDM = isDM(parentReport);

But it will return false, since parentReport type is iou, not chat

What changes do you think we should make in order to solve the problem?

We should check not parentReport but chatIOUReport:

const isParentReportDM = isDM(chatIOUReport);

What alternative solutions did you explore? (Optional)

We can check for type iou not chat in this case and && !getChatType(report) && !isThread(report)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021993736373490522541

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[CortneyOfstad]

Hey @eVoloshchak! We have a proposal here for review – thanks!