-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Closed
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.Item broken or needs improvement.ReviewingHas a PR in reviewHas a PR in review
Description
Details
BaseVideoPlayer uses FullscreenLoadingIndicator, but it is not necessarily rendered fullscreen. With our recent changes to FullscreenLoadingIndicator which now renders a back button after 10 seconds to provide a recovery path in case of infinite loading, using this component on non-fullscreen pages could lead to a confusing UI, since those pages either aren’t fullscreen or already have their own navigation options. That’s why the Back Button feature is currently disabled by default.
We should change the component to ActivityIndicator while keeping the current design.
List of components to change:
src/components/VideoPlayer/BaseVideoPlayer.tsx
Parent issue: #69850, summary comment
Example of the FullscreenLoadingIndicator component:
Issue Owner
Current Issue Owner: @linhvovan29546Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022021302028999453909
- Upwork Job ID: 2021302028999453909
- Last Price Increase: 2026-02-10
- Automatic offers:
- linhvovan29546 | Reviewer | 110443501
- PiyushChandra17 | Contributor | 110443503
Reactions are currently unavailable
Metadata
Metadata
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.Item broken or needs improvement.ReviewingHas a PR in reviewHas a PR in review