[Due for payment 2025-12-19] [$250] Pay button show original amount in approved report after splitting amount again in 1st report

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.61-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory around https://test-management.browserstack.com/projects/2219752/test-runs/TR-2029/folder/13176791/41237173/1026030558
Email or phone of affected tester (no customers): kiatest.80+ck1119255@gmail.com
Issue reported by: Applause Internal Team
Device used: iPhone 16/iOS 18.3.1, Pixel 8a/Android 15
App Component: Money Requests

Action Performed:

Precondition : Create a workspace with Delay submission disabled and Add approvals enabled

1. Navigate to staging.new.expensify.com or launch hybrid app
2. Navigate to workspace chat & create a manual expense
3. Create an empty report (Report 2)
4. Split the expense previously created in the workspace chat into 2 child splits
5. Select one of the splits and move it to another report (Report 2)
6. Submit and approve Report 2
7. Open the other split expense in Report 1
8. Click on More > Edit Splits
9. Click Add Split >> Split the amount into 2 child splits
10. Go back to workspace chat
11. Observe the Pay button on approved report 2 show the original amount that was created in step 2

Expected Result:

Pay button on approved report 2 should show correct expense split amount after splitting amount in first report

Actual Result:

Pay button show original amount in approved second report after splitting amount again in first report

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7008718_1763585810646.ScreenRecording_11-19-2025_15-27-48_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021991669901004266767
• Upwork Job ID: 1991669901004266767
• Last Price Increase: 2025-11-28

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021991669901004266767

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pay button show original amount in approved second report after splitting amount again in first report

What is the root cause of that problem?

When editing the split, the total of any transaction's expense report is updated to the original amount of the split expense

App/src/libs/actions/IOU.ts

Line 14142 in cb4506d

newReportTotal: calculatedNewReportTotal,

What changes do you think we should make in order to solve the problem?

We should calculate the total for each expense report based on the amount of each transaction in this report

const reportTotal = splitExpenses.filter((expense) => expense.reportID === splitExpense?.reportID).reduce((acc, curr) => acc - (curr.amount ?? 0), 0);
newReportTotal: reportTotal,

App/src/libs/actions/IOU.ts

Line 14142 in cb4506d

newReportTotal: calculatedNewReportTotal,

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pay button show original amount in approved second report after splitting amount again in first report

What is the root cause of that problem?

When you split an expense into multiple child splits, each split can be moved to different reports (tracked via splitExpense.reportID)

When editing splits again (e.g., splitting one of the child splits further), the code calculated a single calculatedNewReportTotal based on the sum of ALL split expenses

This global total was then applied to every report that had a split, regardless of which report each split actually belonged to

Therefore, it causes Report 2 (the approved report) to incorrectly show the total of all splits instead of just the amount of the split that was moved to it

App/src/libs/actions/IOU.ts

Line 14000 in fea749b

const calculatedNewReportTotal = isCreationOfSplits ? reportTotal - changesInReportTotal : -sumOfCurrentSplits;

What changes do you think we should make in order to solve the problem?

Instead of using a single global calculatedNewReportTotal for all splits, we should groups split expenses by their reportID to understand which splits belong to which report, then calculate the new total for each unique report based only on the splits that belong to that specific report

    const splitExpensesByReportID = splitExpenses.reduce<Record<string, typeof splitExpenses>>((acc, split) => {
        const reportID = split.reportID ?? '';
        if (!acc[reportID]) {
            acc[reportID] = [];
        }
        acc[reportID].push(split);
        return acc;
    }, {});

    const newReportTotalsByReportID = Object.entries(splitExpensesByReportID).reduce<Record<string, number>>((acc, [reportID, splits]) => {
        const totalForReport = splits.reduce((sum, split) => sum + (split.amount ?? 0), 0);
        acc[reportID] = -totalForReport;
        return acc;
    }, {});

App/src/libs/actions/IOU.ts

Line 14001 in fea749b

Then use the correct per-report total when calling getMoneyRequestInformation for each split

        const splitReportID = splitExpense?.reportID ?? '';
        const newReportTotalForThisSplit = newReportTotalsByReportID[splitReportID] ?? calculatedNewReportTotal;

...

       newReportTotal: newReportTotalForThisSplit,

App/src/libs/actions/IOU.ts

Line 14079 in fea749b

newReportTotal: calculatedNewReportTotal,

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dukenv0307]

reviewing...