[$250] Unclear admin system message when update distance rates

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.63-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2155/folder/13176744/41237137/1035950355
Email or phone of affected tester (no customers): gocemate+b2155693@gmail.com
Issue reported by: Applause Internal Team
Device used: Lenovo 80ES / Windows 10 Pro
App Component: Chat Report View

Action Performed:

1. Create workspace
2. Enable distance rates
3. Add new rate
4. Disable the new rate
5. Go to #admin
6. Open the thread

Expected Result:

The last admin system message should clearly indicate the change that happened for the new rate

Actual Result:

generate 2 system messages :

• updated the enabled of the Distance rate "New Rate" from "enabled" to "disabled"
• updated the index of the Distance rate "New Rate" from "" to "1"

The second admin system message is unclear. It reads: "updated the index of the Distance rate "New Rate" from "" to "1" the "1" seems to be a placeholder and doesn't clearly state the change.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7012605_1764029726815.Recording__43.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021993382977909527240
• Upwork Job ID: 1993382977909527240
• Last Price Increase: 2025-12-23

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Rkdev09]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unclear admin system message when update distance rates

What is the root cause of that problem?

• The "enabled" and "index" field is not handles here:
  

  App/src/libs/ReportActionsUtils.ts

  Lines 2683 to 2719 in dbec56a

  	function getWorkspaceCustomUnitRateUpdatedMessage(action: ReportAction): string {
  	const {customUnitName, customUnitRateName, updatedField, oldValue, newValue, newTaxPercentage, oldTaxPercentage} =
  	getOriginalMessage(action as ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_CUSTOM_UNIT_RATE>) ?? {};
  	if (customUnitName && customUnitRateName && updatedField === 'rate' && typeof oldValue === 'string' && typeof newValue === 'string') {
  	// eslint-disable-next-line @typescript-eslint/no-deprecated
  	return translateLocal('workspaceActions.updatedCustomUnitRate', {
  	customUnitName,
  	customUnitRateName,
  	updatedField,
  	oldValue,
  	newValue,
  	});
  	}
  	if (customUnitRateName && updatedField === 'taxRateExternalID' && typeof newValue === 'string' && newTaxPercentage) {
  	// eslint-disable-next-line @typescript-eslint/no-deprecated
  	return translateLocal('workspaceActions.updatedCustomUnitTaxRateExternalID', {
  	customUnitRateName,
  	newValue,
  	newTaxPercentage,
  	oldTaxPercentage,
  	oldValue: oldValue as string | undefined,
  	});
  	}
  	if (customUnitRateName && updatedField === 'taxClaimablePercentage' && typeof newValue === 'number' && customUnitRateName) {
  	// eslint-disable-next-line @typescript-eslint/no-deprecated
  	return translateLocal('workspaceActions.updatedCustomUnitTaxClaimablePercentage', {
  	customUnitRateName,
  	newValue: parseFloat(parseFloat(newValue ?? 0).toFixed(2)),
  	oldValue: typeof oldValue === 'number' ? parseFloat(parseFloat(oldValue ?? 0).toFixed(2)) : undefined,
  	});
  	}
  	return getReportActionText(action);
  	}

What changes do you think we should make in order to solve the problem?

• We should handle those fields in the function:

    if (customUnitRateName && updatedField === 'enabled' && typeof newValue === 'boolean') {
        // eslint-disable-next-line @typescript-eslint/no-deprecated
        return translateLocal('workspaceActions.updatedCustomUnitRateEnabled', {
            customUnitRateName,
            newValue,
            oldValue: typeof oldValue === 'boolean' ? oldValue : undefined,
        });
    }

    if (customUnitRateName && updatedField === 'index' && typeof newValue === 'number') {
        // eslint-disable-next-line @typescript-eslint/no-deprecated
        return translateLocal('workspaceActions.updatedCustomUnitRateIndex', {
            customUnitRateName,
            newValue,
            oldValue: typeof oldValue === 'number' ? oldValue : undefined,
        });
    }

type UpdatedPolicyCustomUnitRateEnabledParams = {customUnitRateName: string; newValue: boolean; oldValue?: boolean};

type UpdatedPolicyCustomUnitRateIndexParams = {customUnitRateName: string; newValue: number; oldValue?: number};

    updatedCustomUnitRateEnabled: ({customUnitRateName, newValue, oldValue}: UpdatedPolicyCustomUnitRateEnabledParams) => {
        const newValueText = newValue ? 'enabled' : 'disabled';
        if (oldValue !== undefined) {
            const oldValueText = oldValue ? 'enabled' : 'disabled';
            return `changed the distance rate "${customUnitRateName}" to ${newValueText} (previously ${oldValueText})`;
        }
        return `set the distance rate "${customUnitRateName}" to ${newValueText}`;
    },
    updatedCustomUnitRateIndex: ({customUnitRateName, newValue, oldValue}: UpdatedPolicyCustomUnitRateIndexParams) => {
        if (oldValue !== undefined) {
            return `changed the index of the distance rate "${customUnitRateName}" to ${newValue} (previously ${oldValue})`;
        }
        return `set the index of the distance rate "${customUnitRateName}" to ${newValue}`;
    },

• Also handle other field if missing.
• Translations can be updated and changed during the PR work.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[Rkdev09]

I have updated my proposal. I hope that's not an issue.

[Christinadobrzyn]

Thanks for the proposal @Rkdev09! Adding a C+ to review. I can reproduce with the steps in the OP.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021993382977909527240

[melvin-bot]

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.