[Due for payment 2026-01-16] [Due for payment 2026-01-16] [$250] “From” field briefly flashes incorrect user on Expenses page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.63-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation (hyperlinked to channel name): #Quality

Action Performed:

1. Navigate to Reports > Expenses page
2. Click on any expense to open its details (From unvalidated user)
3. Observe the From field in the expense list
4. Notice that it briefly shows a different user before reverting to the correct user.

Expected Result:

The From field should consistently display the correct user.

Actual Result:

The From field momentarily displays the wrong user.
The UI briefly flickers between incorrect → correct data.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome / Edge
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1963.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021993717420381838570
• Upwork Job ID: 1993717420381838570
• Last Price Increase: 2025-12-03
• Automatic offers:
• FitseTLT | Reviewer | 109820304
• tsa321 | Contributor | 109820305

Issue Owner

Current Issue Owner: @FitseTLT

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[tsa321]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On report search page -> expense (transaction list), when user press a transaction which is from other user, the from value will be changed to himself briefly. Happens on the first click after logout -> login.

On the report search page -> expense (transaction list), when the user presses a transaction which is from another user, the from value will briefly change to himself. This happens on the first click after logout -> login (some data is not available yet).

What is the root cause of that problem?

On the expense search page:
After logout then login (some report or report actions data is not available yet), when the user presses an item which is not from himself/herself, the from field will briefly change to his/her account name.
This is because when the user selects/presses the row while the parent report action/data is not available yet:

App/src/components/Search/index.tsx

Line 665 in 11cdba6

const onSelectRow = useCallback(

the createAndOpenSearchTransactionThread or setOptimisticDataForTransactionThreadPreview will create an optimistic parent report action:

App/src/libs/actions/Search.ts

Lines 1065 to 1083 in 11cdba6

	if (!hasParentReportAction && moneyRequestReportActionID) {
	const optimisticIOUAction = buildOptimisticIOUReportAction({
	type: CONST.IOU.REPORT_ACTION_TYPE.CREATE,
	amount,
	currency,
	comment: '',
	participants: [],
	transactionID,
	iouReportID: reportID,
	created,
	reportActionID: moneyRequestReportActionID,
	linkedExpenseReportAction: {childReportID: transactionThreadReportID} as ReportAction,
	});
	optimisticIOUAction.pendingAction = undefined;
	onyxUpdates.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`,
	value: {[optimisticIOUAction.reportActionID]: optimisticIOUAction},
	});

but the buildOptimisticIOUReportAction will always set the actorAccountID to be the user:

App/src/libs/ReportUtils.ts

Line 7060 in 11cdba6

actorAccountID: currentUserAccountID,

This will make the from value change to the user's account and then change back when the data of the parent report action is retrieved.

What changes do you think we should make in order to solve the problem?

We could change the actorAccountID to be the correct id by adding:

optimisticIOUAction.actorAccountID = from?.accountID

below this line:

App/src/libs/actions/Search.ts

Line 1078 in c56e8e2

optimisticIOUAction.pendingAction = undefined;

and add from field in:

App/src/libs/actions/Search.ts

Line 1050 in c56e8e2

const {moneyRequestReportActionID, reportID, report, amount, currency, transactionID, created, transactionThreadReportID, policyID} = item;

Besides the from data, there are other fields from which the actor account can be extracted. We could use those as an alternative.

Before:

before.mp4

After:

after.mp4

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021993717420381838570

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @FitseTLT (External)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@FitseTLT 6 days overdue. This is scarier than being forced to listen to Vogon poetry!