[$250] Report-Expense report thread and reply title is shown as In workspace

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.2.63-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #74940
Email or phone of affected tester (no customers): dreamnitethedragon+yydyd373@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10S Android 13
App Component: User Settings

Action Performed:

Pre-condition:

1. Go to https://staging.new.expensify.com/home
2. In 1:1 chat , send a message and create a thread reply message
3. In workspace chat, create an expense
4. Open the expense
5. Send a message and create a thread reply message

Steps:

1. Go to https://staging.new.expensify.com/home
2. Open the 1:1 thread chat from LHN
3. Note header and chat details
4. Go to Reports - chat
5. Scroll down to 1:1 thread chat
6. Note thread title and message is shown correctly
7. Go to LHN
8. Open expense report thread page
9. Note header and chat details
10. Go to Reports - chat
11. Note parent message and reply thread title shows "workspace name" instead of "expense report"
12. Note the title of expense shown as "In expense report" correctly

Expected Result:

Expense report thread and reply title must be shown as In expense report.

Actual Result:

Expense report thread and reply title is shown as In workspace instead of In expense report.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7013196_1764084414272.Screenrecorder-2025-11-25-20-42-45-416.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021994480689444839637
• Upwork Job ID: 1994480689444839637
• Last Price Increase: 2025-12-05

Issue Owner

Current Issue Owner: @grgia

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021994480689444839637

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[mananjadhav]

Waiting for proposals.

[annaweber830]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense report thread and reply title must be shown as In expense report.

What is the root cause of that problem?

The root cause has two parts:

1. In ParentNavigationSubtitle.tsx: The component checks if the parent report is an expense report using isExpenseReport(report), but it was previously checking report?.type first before calling the function. When the report isn't fully loaded from Onyx, the check fails and defaults to showing workspace name.
   

   App/src/components/ParentNavigationSubtitle.tsx

   Lines 176 to 178 in fbed79d

   	{!!workspaceName && workspaceName !== reportName && (
   	<Text style={[styles.optionAlternateText, styles.textLabelSupporting, textStyles]}>{` ${translate('threads.in')} ${workspaceName}`}</Text>
   	)}

2. In getSearchReportName function (ReportUtils.ts): For chat threads, the original code always returned policy.name (workspace name) without checking if the thread's parent report was actually an expense report
   

   App/src/libs/ReportUtils.ts

   Lines 5959 to 5961 in fbed79d

   	if (isChatThread(report) && policy?.name) {
   	return policy.name;
   	}

   
   So the code treats all threads the same way that assuming they're always in a workspace chat.
   But in reality, threads can be nested inside expense reports, and those should display the expense report context instead of the workspace context.

What changes do you think we should make in order to solve the problem?

1. Fix ParentNavigationSubtitle.tsx:
   Add logic to determine whether to show "In expense report" or "In workspace" based on whether the parent report is an expense report

import {canUserPerformWriteAction as canUserPerformWriteActionReportUtils, isExpenseReport, isMoneyRequestReport} from '@libs/ReportUtils';

const isParentExpenseReport = isExpenseReport(report);
    const shouldShowInWorkspace = !!workspaceName && workspaceName !== reportName && !isParentExpenseReport;
    const shouldShowInExpenseReport = isParentExpenseReport && reportName;

{shouldShowInExpenseReport && (
                    <Text style={[styles.optionAlternateText, styles.textLabelSupporting, textStyles]}>{` ${translate('threads.in')} ${reportName}`}</Text>
                )}
                {shouldShowInWorkspace && (
                    <Text style={[styles.optionAlternateText, styles.textLabelSupporting, textStyles]}>{` ${translate('threads.in')} ${workspaceName}`}</Text>
                )}

2. Fix getSearchReportName function in ReportUtils.ts:
   If the chat thread has a parent expense report, return the parent’s name using getReportName()
   

   App/src/libs/ReportUtils.ts

   Lines 5959 to 5961 in fbed79d

   	if (isChatThread(report) && policy?.name) {
   	return policy.name;
   	}

if (isChatThread(report) && policy?.name) {
        // If the parent report is an expense report, return the expense report name instead of workspace name
        const parentReport = getParentReport(report);
        if (parentReport && isExpenseReport(parentReport)) {
            return getReportName(
                parentReport,
                policy,
                props.parentReportActionParam,
                props.personalDetails,
                props.invoiceReceiverPolicy,
                undefined,
                props.transactions,
                props.isReportArchived,
                props.reports,
                props.policies,
            );
        }
        return policy.name;
    }

What alternative solutions did you explore? (Optional)

[melvin-bot]

@mananjadhav Whoops! This issue is 2 days overdue. Let's get this updated quick!