-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Description
As part of our overall rules and workflows initiative, we're now turning our attention category rules.
Here’s what’s in scope: We’re expanding support for required category fields and coding. Specifically, we’ll add more category-based rules within each NewDot category. For example: “If the category is Meals & Entertainment, then require the Attendees field.”
This issue requires a BE component that will be planned internally, though for the FE the changes are:
Make Description hint more discoverable
Specifically, we'll move Description hint field below Payroll code and above Delete category.
There are no other changes to the existing Description hint field, though I'm including it below for posterity.
Add a Require fields push row
This new row contains options for both Require description and Require attendees, like so.
When clicked the user sees this page in the RHP.
When both fields are required, they'll appear like this (e.g. in the order the toggles appear in the RHP)
Require attendees logic
We'll flag an Attendees violation on an expense when either of the following is true:
- The attendees array is empty, or
- The length of the attendees array minus the expense creator is zero.
Inline violation
If a member doesn't add multiple attendees when required for a given category, we'll show an inline violation using standard patterns, like so. Attendees required for this category.
Admin policy logs
Enabled and disabling the requirement for attendee tracking on a given category will use one of two system messages:
- changed the "Advertising" category attendees to required (previously not required)
- changed the "Advertising" category attendees to not required (previously required)
Issue Owner
Current Issue Owner: @JmillsExpensifyMetadata
Metadata
Labels
Type
Projects
Status