[Payment due] [$250] Rules - RBR category description remain in report after toggle off the Rules

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.67-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2249/folder/13176707/41236896/1050639353
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Chat Report View

Action Performed:

Precondition: Use is an Admin of a Control Workspace and has set a description hint for a category ( ex, Advertising)

1. Open the NewDot app
2. Navigate to the Workspace chat
3. Submit an expense with the category that has the required description ( keep the description empty to get the RBR)
4. Navigate to the Workspace features, toggle off the Rules section
5. Open the workspace chat - preview report (have an RBR)
6. Open the report details

Expected Result:

The RBR disappeared after toggle off the Rules section

Actual Result:

The RBR "Description required for selected category" still displays in the Report details and LHN

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7018204_1764648962526.description_hint.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021997402847372221841
• Upwork Job ID: 1997402847372221841
• Last Price Increase: 2025-12-06
• Automatic offers:
• truph01 | Contributor | 109828107

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The RBR message "Description required for selected category" continues to display in the Report Details and LHN, even after the rule has been disabled.

What is the root cause of that problem?

• We are not performing an optimistic update on the transaction violations when the rule feature is enabled or disabled.

What changes do you think we should make in order to solve the problem?

1. Update the logic in shouldShowMissingComment

Update the following line in

App/src/libs/Violations/ViolationsUtils.ts

Line 382 in 075bb2e

const shouldShowMissingComment = !isInvoiceTransaction && policyCategories?.[categoryName ?? '']?.areCommentsRequired && !updatedTransaction.comment?.comment && isControlPolicy;

const shouldShowMissingComment =
    !isInvoiceTransaction &&
    policyCategories?.[categoryName ?? '']?.areCommentsRequired &&
    !updatedTransaction.comment?.comment &&
    isControlPolicy &&
    policy?.areRulesEnabled;

This ensures that when the rule feature is disabled, shouldShowMissingComment will return false.

2. Update enablePolicyRules to optimistically update transaction violations

In

App/src/libs/actions/Policy/Policy.ts

Line 4439 in 075bb2e

function enablePolicyRules(policyID: string, enabled: boolean, shouldGoBack = true) {

, enhance the enablePolicyRules function to include an optimistic violation update:

function enablePolicyRules(policyID: string, enabled: boolean, shouldGoBack = true, policyData: PolicyData) {
    ...
    ReportUtils.pushTransactionViolationsOnyxData(onyxData, policyData, {
        areRulesEnabled: enabled,
        preventSelfApproval: false,
        ...(!enabled ? DISABLED_MAX_EXPENSE_VALUES : {}),
        pendingFields: {
            areRulesEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
        },
    });
}

3. Ensure policyData is passed when calling enablePolicyRules

Wherever enablePolicyRules is invoked, pass the policyData as the fourth parameter:

const policyData = usePolicyData(policyID);
enablePolicyRules(policyID, enabled, shouldGoBack, policyData);

4. BE needs to update to sync with what we did in FE as well.

5. Optional: We can optimistically update the transaction violation upon editing the category as well (for example, when user toggles the description required field).

What alternative solutions did you explore? (Optional)

[melvin-bot]

@zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021997402847372221841

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[zanyrenney]

OOO until Friday 12th, adding bug buddy.