Remove deprecated report name functions in ReportUtils

[neil-marcellini]

Problem

In this PR we moved a bunch of functions to a ReportNameUtils file, made some modifications to make them pure functions and we marked the original source functions from ReportUtils as deprecated.

• Feat: refactor getReportName and move report name related functions #75357

We did that as part of this issue Refactor getReportName to prepare for formula computation which was the first step of this larger refactor - [HOLD 72613] Refactor optimistic custom report names to use Onyx derived values

Overall we didn't get too far before deciding to abandon this approach due to low ROI. Now we need to clean up the code.

Solution

Remove the deprecated functions. We might also want to rename the function computeReportName in ReportNameUtils to computeReportNameWithoutFormula or something similar to make its use more clear.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[lorretheboy]

I can help to open PR based on solution in OP if needed

[neil-marcellini]

Sure thanks, go for it!

[lorretheboy]

Daily update: The PR is almost ready, the PR is larger than I estimated, there are still several places of getReportName need to be updated to use new method (this func call is a complex than others). I expect it is ready for review tomorrow

Or maybe we can separate to handle the getReportName into another PR for easier to review and testing? What do you think? @neil-marcellini @eVoloshchak

Here is the current PR (WIP)