[HOLD for payment 2022-04-06] [$500] Split Money - Able to proceed with split request using first 3 digits of phone number

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com
2. Log in with any account
3. Tap on Fub menu and tap Split bill
4. Add one user
5. Tap on Search box and start typing the numbers
6. Delete some numbers and leave it only 3 digits
7. Click Split bill

Error message:

Unexpected error, please try it again

Expected Result:

Unable to proceed with split request using first 3 digits of phone number

Actual Result:

Able to proceed with split request using first 3 digits

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.38.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5447716_error.mp4

Recording.204.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[mdneyazahmad]

Proposal

Invalidate the phone number, if the number of digit is not atleast 4 digit.

App/src/libs/OptionsListUtils.js

Line 550 in d05fce8

&& ((Str.isValidEmail(searchValue) && !Str.isDomainEmail(searchValue)) || Str.isValidPhone(searchValue))

-        && ((Str.isValidEmail(searchValue) && !Str.isDomainEmail(searchValue)) || Str.isValidPhone(searchValue))

+        && ((Str.isValidEmail(searchValue) && !Str.isDomainEmail(searchValue)) || (searchValue.length > 3 && Str.isValidPhone(searchValue)))