[$250] Delete option is present for approved expense

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.74-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #76504
Email or phone of affected tester (no customers): gocemate+b2155773@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Lenovo 80ES / Windows 10 Pro
App Component: Money Requests

Action Performed:

1. Create a control policy and invite a submitter and approver
2. Navigate to Workspace > Workflows and update the submitter's approver to the approver account and the 2nd approver as the admin
3. As submitter, create and submit an expense
4. As approver, approve the expense
5. As submitter, try to delete the expense

Expected Result:

There shouldn't be Delete button on approved expense

Actual Result:

Delete option is present for approved expense and it leads to unexpected error when click Delete

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7024786_1765279348375.Recording__152.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021998444561376399397
• Upwork Job ID: 1998444561376399397
• Last Price Increase: 2025-12-09
• Automatic offers:
• huult | Reviewer | 109785804

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[DylanDylann]

@luacmartins This issue was already known during the PR implementation, and we were able to reproduce it even before merging. Therefore, it isn’t a regression.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-12-10 16:27:01 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Delete option is present for approved expense and it leads to unexpected error when click Delete

What is the root cause of that problem?

• Context menu action: we only prevent deleting the processing report, which has already been approved, if the instant submit is enabled

App/src/libs/ReportUtils.ts

Line 2759 in 6d9448e

if (isInstantSubmitEnabled(policy) && isProcessingReport(moneyRequestReport)) {

• Secondary action: We only check the report is open/processing without checking if the report is already approved

App/src/libs/ReportUtils.ts

Lines 2941 to 2970 in 6d9448e

	const isReportOpenOrProcessing = isOpenReport(report) || isProcessingReport(report);
	const isSingleTransaction = reportTransactions.length === 1;
	if (reportTransactions.length > 0 && reportTransactions.every((t) => isDemoTransaction(t))) {
	return true;
	}
	const isUnreported = isSelfDM(report);
	const canCardTransactionBeDeleted = canDeleteCardTransactionByLiabilityType(transaction);
	if (isUnreported) {
	return isOwner && canCardTransactionBeDeleted;
	}
	if (isInvoiceReport(report)) {
	return report?.ownerAccountID === currentUserAccountID && isReportOpenOrProcessing;
	}
	// Users cannot delete a report in the unreported or IOU cases, but they can delete individual transactions.
	// So we check if the reportTransactions length is 1 which means they're viewing a single transaction and thus can delete it.
	if (isIOUReport(report)) {
	return isSingleTransaction && isOwner && isReportOpenOrProcessing;
	}
	if (isExpenseReport(report)) {
	if (isSingleTransaction && !canCardTransactionBeDeleted) {
	return false;
	}
	const isReportSubmitter = isCurrentUserSubmitter(report);
	return isReportSubmitter && isReportOpenOrProcessing;

• On search page: canDelete of the transaction is true

App/src/pages/Search/SearchPage.tsx

Line 657 in 469d0a4

const shouldShowDeleteOption = !isOffline && selectedTransactionsKeys.every((id) => selectedTransactions[id].canDelete);

What changes do you think we should make in order to solve the problem?

• For context menu: We should remove isInstantSubmitEnabled(policy) check here

if (isProcessingReport(moneyRequestReport)) {
        return isAwaitingFirstLevelApproval(moneyRequestReport);
    }

App/src/libs/ReportUtils.ts

Line 2759 in 6d9448e

if (isInstantSubmitEnabled(policy) && isProcessingReport(moneyRequestReport)) {

• For secondary action: We should add the check to only show the delete option if the report is processing and awaiting on the first level approval

if (isExpenseReport(report)) {
        if (isSingleTransaction && !canCardTransactionBeDeleted) {
            return false;
        }

        const isReportSubmitter = isCurrentUserSubmitter(report);
        return isReportSubmitter && (isOpenReport(report) || (isProcessingReport(report) && isAwaitingFirstLevelApproval(report)));
    }

App/src/libs/ReportUtils.ts

Lines 2941 to 2970 in 6d9448e

	const isReportOpenOrProcessing = isOpenReport(report) || isProcessingReport(report);
	const isSingleTransaction = reportTransactions.length === 1;
	if (reportTransactions.length > 0 && reportTransactions.every((t) => isDemoTransaction(t))) {
	return true;
	}
	const isUnreported = isSelfDM(report);
	const canCardTransactionBeDeleted = canDeleteCardTransactionByLiabilityType(transaction);
	if (isUnreported) {
	return isOwner && canCardTransactionBeDeleted;
	}
	if (isInvoiceReport(report)) {
	return report?.ownerAccountID === currentUserAccountID && isReportOpenOrProcessing;
	}
	// Users cannot delete a report in the unreported or IOU cases, but they can delete individual transactions.
	// So we check if the reportTransactions length is 1 which means they're viewing a single transaction and thus can delete it.
	if (isIOUReport(report)) {
	return isSingleTransaction && isOwner && isReportOpenOrProcessing;
	}
	if (isExpenseReport(report)) {
	if (isSingleTransaction && !canCardTransactionBeDeleted) {
	return false;
	}
	const isReportSubmitter = isCurrentUserSubmitter(report);
	return isReportSubmitter && isReportOpenOrProcessing;

• For search page: The backend should return canDelete of the transaction as false if the transaction is already approver by first approver

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021998444561376399397

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @huult (External)