[Due for payment 2026-01-06] [$250] Expense preview increase when navigating a single expense & empty report with arrow

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.78-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #75886
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11 / Chrome, Android 13 / Xiaomi Poco F5, iOS 15.8.3 / iPhone 7 Plus
App Component: Other

Action Performed:

Preconditions:

• At least have a workspace

1. Go to https://staging.new.expensify.com/
2. Login with a Gmail account
3. Go to workspace chat
4. Create a single expense and an empty report
5. Go to Reports > Reports tab
6. Open created expense from step 4 (empty report or single expense)
7. Navigate between a single expense and an empty report using the arrow button several times

Expected Result:

One expense preview should only appear when navigating between a single expense and an empty report with the arrow button

Actual Result:

The expense preview will increase when navigating between a single expense and an empty report with the arrow button

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022000958985374988405
• Upwork Job ID: 2000958985374988405
• Last Price Increase: 2025-12-16
• Automatic offers:
• linhvovan29546 | Reviewer | 109869156

Issue Owner

Current Issue Owner: @TaduJR

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abbasifaizan70]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When navigating between a single expense and an empty report using arrow buttons, the expense preview duplicates and increases with each navigation instead of showing only one expense preview.

What is the root cause of that problem?

The getCombinedReportActions function filters out CREATE and TRACK actions from money request reports, but it does not filter out REPORT_PREVIEW actions. Report preview actions should only be displayed in workspace chats (parent reports), not in expense reports themselves.

When navigating between reports using arrow buttons, report preview actions are incorrectly included in the expense report's own report actions. This causes the expense to be displayed multiple times - once as the actual transaction and additional times as report preview actions.

The Problem Flow:

1. User navigates between single expense and empty report using arrow buttons
2. Report preview actions are included in expense report actions (incorrect)
3. Each navigation adds more report preview actions to the expense report
4. When viewing expense report → shows transaction + multiple report preview actions
5. Result: Expense preview duplicates and increases with each navigation ❌

What changes do you think we should make in order to solve the problem?

Filter out report preview actions from expense report actions in the getCombinedReportActions function. Report preview actions should only exist in workspace chats, not in expense reports (EXPENSE, IOU, or INVOICE type reports).

File: App/src/libs/ReportActionsUtils.ts

Update the getCombinedReportActions function to filter out report preview actions from money request reports:

Before:

const report = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];
const isSelfDM = report?.chatType === CONST.REPORT.CHAT_TYPE.SELF_DM;
// Filter out request and send money request actions because we don't want to show any preview actions for one transaction reports
const filteredReportActions = [...filteredParentReportActions, ...filteredTransactionThreadReportActions].filter((action) => {
    if (!isMoneyRequestAction(action)) {
        return true;
    }
    const actionType = getOriginalMessage(action)?.type ?? '';
    if (isSelfDM) {
        return actionType !== CONST.IOU.REPORT_ACTION_TYPE.CREATE;
    }
    return actionType !== CONST.IOU.REPORT_ACTION_TYPE.CREATE && actionType !== CONST.IOU.REPORT_ACTION_TYPE.TRACK;
});

After:

const report = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];
const isSelfDM = report?.chatType === CONST.REPORT.CHAT_TYPE.SELF_DM;
const isMoneyRequest = report?.type === CONST.REPORT.TYPE.EXPENSE || report?.type === CONST.REPORT.TYPE.IOU || report?.type === CONST.REPORT.TYPE.INVOICE;
// Filter out request and send money request actions because we don't want to show any preview actions for one transaction reports
// Also filter out report preview actions from money request reports (expense, IOU, invoice) as they should only exist in workspace chats
const filteredReportActions = [...filteredParentReportActions, ...filteredTransactionThreadReportActions].filter((action) => {
    // Filter out report preview actions from money request reports
    if (isMoneyRequest && isReportPreviewAction(action)) {
        return false;
    }
    if (!isMoneyRequestAction(action)) {
        return true;
    }
    const actionType = getOriginalMessage(action)?.type ?? '';
    if (isSelfDM) {
        return actionType !== CONST.IOU.REPORT_ACTION_TYPE.CREATE;
    }
    return actionType !== CONST.IOU.REPORT_ACTION_TYPE.CREATE && actionType !== CONST.IOU.REPORT_ACTION_TYPE.TRACK;
});

Changes:

1. Added check to identify money request reports: const isMoneyRequest = report?.type === CONST.REPORT.TYPE.EXPENSE || report?.type === CONST.REPORT.TYPE.IOU || report?.type === CONST.REPORT.TYPE.INVOICE;
2. Added filter condition to exclude report preview actions from money request reports: if (isMoneyRequest && isReportPreviewAction(action)) { return false; }
3. Updated comment to explain the additional filtering logic

Why this works:

1. Prevents duplicate display: Filters out report preview actions from expense reports, ensuring they only appear in workspace chats
2. Maintains correct view: Allows proper display of single expense reports without duplicate previews
3. Targeted fix: Only affects money request reports (EXPENSE, IOU, INVOICE), leaving workspace chats unaffected
4. Consistent with existing logic: Follows the same pattern as filtering CREATE and TRACK actions in the same function
5. Prevents accumulation: Stops report preview actions from accumulating when navigating between reports

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022000958985374988405

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @linhvovan29546 (External)

[linhvovan29546]

Reviewing...

[linhvovan29546]

@abbasifaizan70 Thanks for the proposal. I don’t understand the RCA, why does this happen when navigating with the arrow button and only when the workspace chat has an empty report? Also, the proposed solution doesn’t resolve the issue.

[TaduJR]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When navigating between reports using arrow buttons in the Search Money Request Report page, the expense preview count incorrectly increases. Duplicate IOU actions are created when navigating from an empty report to a single-transaction report.

What is the root cause of that problem?

The legacy thread creation useEffect proceeds while reportActions contains stale data from the previous report. This happens because when switching between reports, reportActions may temporarily contain data from the previous report before the new report's actions are loaded.

Root cause location:

App/src/pages/Search/SearchMoneyRequestReportPage.tsx

Lines 138 to 179 in 5f74dd2

	useEffect(() => {
	if (hasCreatedLegacyThreadRef.current || transactionThreadReportID || (Object.keys(allReportTransactions).length !== 1 && !snapshotTransaction)) {
	return;
	}
	// Use main collection transaction or fallback to snapshot
	const transaction = Object.values(allReportTransactions).at(0) ?? snapshotTransaction;
	if (!transaction || (transaction && transaction.reportID !== reportIDFromRoute)) {
	return;
	}
	// Check that reportActions belong to the current report to avoid using stale data from the previous report
	const hasMatchingReportActions = reportActions.some((action) => {
	const iouReportID = isMoneyRequestAction(action) ? getOriginalMessage(action)?.IOUReportID : undefined;
	return iouReportID?.toString() === reportIDFromRoute;
	});
	if (!hasMatchingReportActions && reportActions.length > 1) {
	return;
	}
	const iouAction = getIOUActionForTransactionID(reportActions, transaction.transactionID);
	if (iouAction || transaction?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD || !!transaction.linkedTrackedExpenseReportAction?.childReportID) {
	return;
	}
	hasCreatedLegacyThreadRef.current = true;
	const violations = allReportViolations[transaction.transactionID] ?? snapshotViolations;
	createTransactionThreadReport(report, undefined, transaction, violations);
	}, [
	allReportTransactions,
	allReportViolations,
	report,
	reportActions,
	reportIDFromRoute,
	reportMetadata?.isLoadingInitialReportActions,
	snapshot,
	snapshotTransaction,
	snapshotViolations,
	transactionThreadReportID,
	visibleTransactions,

Root cause flow:

1. User views Report A (empty, only CREATED action).

2. User navigates to Report B (single expense). reportIDFromRoute changes to Report B:
   

   App/src/pages/Search/SearchMoneyRequestReportPage.tsx

   Line 52 in 5f74dd2

   const reportIDFromRoute = getNonEmptyStringOnyxID(route.params?.reportID);

3. reportActions still contains stale CREATED action from Report A (length === 1).

4. The existing guard reportActions.length > 1 passes because length is 1:
   

   App/src/pages/Search/SearchMoneyRequestReportPage.tsx

   Lines 155 to 157 in 5f74dd2

   	if (!hasMatchingReportActions && reportActions.length > 1) {
   	return;
   	}

5. createTransactionThreadReport is called with stale data, creating duplicate IOU actions.

Key insight: The reportActions array doesn't belong to the current report during the transition. The IOU action IS available in Onyx for Report B - we just need to wait for it to load.

What changes do you think we should make in order to solve the problem?

Add a guard to verify that reportActions belongs to the current report before proceeding.

Location:

App/src/pages/Search/SearchMoneyRequestReportPage.tsx

Lines 138 to 179 in 5f74dd2

	useEffect(() => {
	if (hasCreatedLegacyThreadRef.current || transactionThreadReportID || (Object.keys(allReportTransactions).length !== 1 && !snapshotTransaction)) {
	return;
	}
	// Use main collection transaction or fallback to snapshot
	const transaction = Object.values(allReportTransactions).at(0) ?? snapshotTransaction;
	if (!transaction || (transaction && transaction.reportID !== reportIDFromRoute)) {
	return;
	}
	// Check that reportActions belong to the current report to avoid using stale data from the previous report
	const hasMatchingReportActions = reportActions.some((action) => {
	const iouReportID = isMoneyRequestAction(action) ? getOriginalMessage(action)?.IOUReportID : undefined;
	return iouReportID?.toString() === reportIDFromRoute;
	});
	if (!hasMatchingReportActions && reportActions.length > 1) {
	return;
	}
	const iouAction = getIOUActionForTransactionID(reportActions, transaction.transactionID);
	if (iouAction || transaction?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD || !!transaction.linkedTrackedExpenseReportAction?.childReportID) {
	return;
	}
	hasCreatedLegacyThreadRef.current = true;
	const violations = allReportViolations[transaction.transactionID] ?? snapshotViolations;
	createTransactionThreadReport(report, undefined, transaction, violations);
	}, [
	allReportTransactions,
	allReportViolations,
	report,
	reportActions,
	reportIDFromRoute,
	reportMetadata?.isLoadingInitialReportActions,
	snapshot,
	snapshotTransaction,
	snapshotViolations,
	transactionThreadReportID,
	visibleTransactions,

Solution:

1. Import getReportAction from ReportActionsUtils:
   

   App/src/libs/ReportActionsUtils.ts

   Line 1222 in 5f74dd2

   function getReportAction(reportID: string | undefined, reportActionID: string | undefined): ReportAction | undefined {

2. Add guard after the first early return check:

// Because when switching between reports, reportActions may contain data from the previous report.
// So we need to check that reportActions belongs to the current report.
const isFirstActionBelongsToCurrentReport = !!getReportAction(reportIDFromRoute, reportActions.at(0)?.reportActionID);
if (report?.reportID && reportActions.length === 1 && !isFirstActionBelongsToCurrentReport) {
    return;
}

How it works:

• getReportAction(reportIDFromRoute, actionID) looks up the action in Onyx's reportActions_{reportIDFromRoute}
• If the first action in reportActions doesn't exist in the current report's Onyx data, it's stale
• The guard returns early, waiting for the correct reportActions to load